[ndctl,4/4] ndctl, load-keys: fix a resource leak in load_dimm_keys()
diff mbox series

Message ID 20190202015253.20051-4-vishal.l.verma@intel.com
State New
Headers show
Series
  • [ndctl,1/4] ndctl, keys: fix a memory leak in dimm_create_key()
Related show

Commit Message

Verma, Vishal L Feb. 2, 2019, 1:52 a.m. UTC
Static analysis reports that we potentially leak 'fname' in the above
function. Fix by freeing it as well as 'blob' in the exit path.

Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 ndctl/load-keys.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Dan Williams Feb. 2, 2019, 2 a.m. UTC | #1
On Fri, Feb 1, 2019 at 5:53 PM Vishal Verma <vishal.l.verma@intel.com> wrote:
>
> Static analysis reports that we potentially leak 'fname' in the above
> function. Fix by freeing it as well as 'blob' in the exit path.
>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

Patch
diff mbox series

diff --git a/ndctl/load-keys.c b/ndctl/load-keys.c
index 184fa2d..95c4d4d 100644
--- a/ndctl/load-keys.c
+++ b/ndctl/load-keys.c
@@ -86,7 +86,7 @@  static int load_dimm_keys(struct loadkeys *lk_ctx)
 {
 	int rc;
 	struct dirent *dent;
-	char *fname, *id, *blob;
+	char *fname = NULL, *id, *blob = NULL;
 	char desc[ND_KEY_DESC_SIZE];
 	int size, count = 0;
 	key_serial_t key;
@@ -142,6 +142,8 @@  static int load_dimm_keys(struct loadkeys *lk_ctx)
 
 	printf("%d nvdimm keys loaded\n", count);
 
+	free(fname);
+	free(blob);
 	return 0;
 }