diff mbox series

[v2,1/2] config.mak.uname: remove obsolete SPARSE_FLAGS setting

Message ID 41d4bf8a-dea9-5ccd-9fad-e4604017661d@ramsayjones.plus.com (mailing list archive)
State New, archived
Headers show
Series Using sparse in a CI job | expand

Commit Message

Ramsay Jones Feb. 5, 2019, 2:25 a.m. UTC
An upcoming commit will change the semantics of the SPARSE_FLAGS
variable from an internal to a user only customisation variable.
The MinGW configuration section contains an obsolete setting for
this variable which was used (some years ago) to cater to an error
in the Win32 system header files. Since 'sparse' does not currently
support the MinGW platform, nobody on that platform can be relying
on this setting today. Remove this use of the SPARSE_FLAGS variable.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
 config.mak.uname | 1 -
 1 file changed, 1 deletion(-)

Comments

Johannes Schindelin Feb. 5, 2019, 11:26 a.m. UTC | #1
Hi Ramsay,

On Tue, 5 Feb 2019, Ramsay Jones wrote:

> 
> An upcoming commit will change the semantics of the SPARSE_FLAGS
> variable from an internal to a user only customisation variable.
> The MinGW configuration section contains an obsolete setting for
> this variable which was used (some years ago) to cater to an error
> in the Win32 system header files. Since 'sparse' does not currently
> support the MinGW platform, nobody on that platform can be relying
> on this setting today. Remove this use of the SPARSE_FLAGS variable.

ACK,
Dscho

> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  config.mak.uname | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/config.mak.uname b/config.mak.uname
> index 7b36a1dfe7..786bb2f913 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -555,7 +555,6 @@ ifneq (,$(findstring MINGW,$(uname_S)))
>  	RC = windres -O coff
>  	NATIVE_CRLF = YesPlease
>  	X = .exe
> -	SPARSE_FLAGS = -Wno-one-bit-signed-bitfield
>  ifneq (,$(wildcard ../THIS_IS_MSYSGIT))
>  	htmldir = doc/git/html/
>  	prefix =
> -- 
> 2.20.0
>
diff mbox series

Patch

diff --git a/config.mak.uname b/config.mak.uname
index 7b36a1dfe7..786bb2f913 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -555,7 +555,6 @@  ifneq (,$(findstring MINGW,$(uname_S)))
 	RC = windres -O coff
 	NATIVE_CRLF = YesPlease
 	X = .exe
-	SPARSE_FLAGS = -Wno-one-bit-signed-bitfield
 ifneq (,$(wildcard ../THIS_IS_MSYSGIT))
 	htmldir = doc/git/html/
 	prefix =