quirks patch for new T+A USB DAC
diff mbox series

Message ID b2d6f671-1cee-231d-bf1c-a6a58e31076b@thesycon.de
State New
Headers show
Series
  • quirks patch for new T+A USB DAC
Related show

Commit Message

Udo Eberhardt Feb. 5, 2019, 4:08 p.m. UTC
Hi all,

This is a patch for sound/usb/quirks.c which enables DSD support for a 
new T+A DAC for which we have developed the USB firmware. Here is a 
patch description:

This patch adds the T+A VID to the generic check in order to enable 
native DSD support for T+A devices. This works with the new T+A USB DAC 
model SD3100HV and will also work with future devices which support the 
XMOS/Thesycon style DSD format.


I hope you can apply this patch. Let me know if you need more info.

Thank you,
Udo

Comments

Udo Eberhardt Feb. 5, 2019, 4:18 p.m. UTC | #1
Here it is:

Signed-off-by: Udo Eberhardt <udo.eberhardt@thesycon.de>

I'm not familiar with your conventions, sorry for any inconvenience.

Thanks
Udo

On 05.02.2019 17:13, Takashi Iwai wrote:
> On Tue, 05 Feb 2019 17:08:51 +0100,
> Udo Eberhardt wrote:
>> Hi all,
>>
>> This is a patch for sound/usb/quirks.c which enables DSD support for a
>> new T+A DAC for which we have developed the USB firmware. Here is a
>> patch description:
>>
>> This patch adds the T+A VID to the generic check in order to enable
>> native DSD support for T+A devices. This works with the new T+A USB
>> DAC model SD3100HV and will also work with future devices which
>> support the XMOS/Thesycon style DSD format.
>>
>>
>> I hope you can apply this patch. Let me know if you need more info.
> Could you give your sign-off (Signed-off-by: xxx line) at least?
> This is mandatory for merging to the upstream.  I should have
> mentioned that in the previous conversation...
>
>
> thanks,
>
> Takashi
>
>> Thank you,
>> Udo
>>
>> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
>> index ef67d19117c4..f372c624bbf4 100644
>> --- a/sound/usb/quirks.c
>> +++ b/sound/usb/quirks.c
>> @@ -1553,6 +1553,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip,
>>   	case 0x20b1:  /* XMOS based devices */
>>   	case 0x152a:  /* Thesycon devices */
>>   	case 0x25ce:  /* Mytek devices */
>> +	case 0x2ab6:  /* T+A devices */
>>   		if (fp->dsd_raw)
>>   			return SNDRV_PCM_FMTBIT_DSD_U32_BE;
>>   		break;
>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Takashi Iwai Feb. 5, 2019, 4:20 p.m. UTC | #2
On Tue, 05 Feb 2019 17:18:56 +0100,
Udo Eberhardt wrote:
> 
> Here it is:
> 
> Signed-off-by: Udo Eberhardt <udo.eberhardt@thesycon.de>

Thanks.

> I'm not familiar with your conventions, sorry for any inconvenience.

The general rule for submitting a kernel patch is well described in
Documentation/process/submitting-patches.rst.


Takashi

> 
> Thanks
> Udo
> 
> On 05.02.2019 17:13, Takashi Iwai wrote:
> > On Tue, 05 Feb 2019 17:08:51 +0100,
> > Udo Eberhardt wrote:
> >> Hi all,
> >>
> >> This is a patch for sound/usb/quirks.c which enables DSD support for a
> >> new T+A DAC for which we have developed the USB firmware. Here is a
> >> patch description:
> >>
> >> This patch adds the T+A VID to the generic check in order to enable
> >> native DSD support for T+A devices. This works with the new T+A USB
> >> DAC model SD3100HV and will also work with future devices which
> >> support the XMOS/Thesycon style DSD format.
> >>
> >>
> >> I hope you can apply this patch. Let me know if you need more info.
> > Could you give your sign-off (Signed-off-by: xxx line) at least?
> > This is mandatory for merging to the upstream.  I should have
> > mentioned that in the previous conversation...
> >
> >
> > thanks,
> >
> > Takashi
> >
> >> Thank you,
> >> Udo
> >>
> >> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> >> index ef67d19117c4..f372c624bbf4 100644
> >> --- a/sound/usb/quirks.c
> >> +++ b/sound/usb/quirks.c
> >> @@ -1553,6 +1553,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip,
> >>   	case 0x20b1:  /* XMOS based devices */
> >>   	case 0x152a:  /* Thesycon devices */
> >>   	case 0x25ce:  /* Mytek devices */
> >> +	case 0x2ab6:  /* T+A devices */
> >>   		if (fp->dsd_raw)
> >>   			return SNDRV_PCM_FMTBIT_DSD_U32_BE;
> >>   		break;
> >> _______________________________________________
> >> Alsa-devel mailing list
> >> Alsa-devel@alsa-project.org
> >> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
Udo Eberhardt Feb. 5, 2019, 4:24 p.m. UTC | #3
Got it. Thanks for the tip. Will follow the rules next time.

Udo

On 05.02.2019 17:20, Takashi Iwai wrote:
> On Tue, 05 Feb 2019 17:18:56 +0100,
> Udo Eberhardt wrote:
>> Here it is:
>>
>> Signed-off-by: Udo Eberhardt <udo.eberhardt@thesycon.de>
> Thanks.
>
>> I'm not familiar with your conventions, sorry for any inconvenience.
> The general rule for submitting a kernel patch is well described in
> Documentation/process/submitting-patches.rst.
>
>
> Takashi
>
>> Thanks
>> Udo
>>
>> On 05.02.2019 17:13, Takashi Iwai wrote:
>>> On Tue, 05 Feb 2019 17:08:51 +0100,
>>> Udo Eberhardt wrote:
>>>> Hi all,
>>>>
>>>> This is a patch for sound/usb/quirks.c which enables DSD support for a
>>>> new T+A DAC for which we have developed the USB firmware. Here is a
>>>> patch description:
>>>>
>>>> This patch adds the T+A VID to the generic check in order to enable
>>>> native DSD support for T+A devices. This works with the new T+A USB
>>>> DAC model SD3100HV and will also work with future devices which
>>>> support the XMOS/Thesycon style DSD format.
>>>>
>>>>
>>>> I hope you can apply this patch. Let me know if you need more info.
>>> Could you give your sign-off (Signed-off-by: xxx line) at least?
>>> This is mandatory for merging to the upstream.  I should have
>>> mentioned that in the previous conversation...
>>>
>>>
>>> thanks,
>>>
>>> Takashi
>>>
>>>> Thank you,
>>>> Udo
>>>>
>>>> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
>>>> index ef67d19117c4..f372c624bbf4 100644
>>>> --- a/sound/usb/quirks.c
>>>> +++ b/sound/usb/quirks.c
>>>> @@ -1553,6 +1553,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip,
>>>>    	case 0x20b1:  /* XMOS based devices */
>>>>    	case 0x152a:  /* Thesycon devices */
>>>>    	case 0x25ce:  /* Mytek devices */
>>>> +	case 0x2ab6:  /* T+A devices */
>>>>    		if (fp->dsd_raw)
>>>>    			return SNDRV_PCM_FMTBIT_DSD_U32_BE;
>>>>    		break;
>>>> _______________________________________________
>>>> Alsa-devel mailing list
>>>> Alsa-devel@alsa-project.org
>>>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Patch
diff mbox series

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index ef67d19117c4..f372c624bbf4 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1553,6 +1553,7 @@  u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip,
 	case 0x20b1:  /* XMOS based devices */
 	case 0x152a:  /* Thesycon devices */
 	case 0x25ce:  /* Mytek devices */
+	case 0x2ab6:  /* T+A devices */
 		if (fp->dsd_raw)
 			return SNDRV_PCM_FMTBIT_DSD_U32_BE;
 		break;