[2/3] ALSA: opl4: Remove superfluous snd_info_register() calls
diff mbox series

Message ID 20190205160527.8815-3-tiwai@suse.de
State New
Headers show
Series
  • ALSA: Remove superfluous snd_info_register() calls
Related show

Commit Message

Takashi Iwai Feb. 5, 2019, 4:05 p.m. UTC
The calls of snd_info_register() are superfluous and should be avoided
at the procfs creation time.  They are called at the end of the whole
initialization via snd_card_register().  This patch drops such
superfluous calls.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/drivers/opl4/opl4_proc.c | 4 ----
 1 file changed, 4 deletions(-)

Patch
diff mbox series

diff --git a/sound/drivers/opl4/opl4_proc.c b/sound/drivers/opl4/opl4_proc.c
index 16b24091d799..f1b839a0e7b7 100644
--- a/sound/drivers/opl4/opl4_proc.c
+++ b/sound/drivers/opl4/opl4_proc.c
@@ -114,10 +114,6 @@  int snd_opl4_create_proc(struct snd_opl4 *opl4)
 		entry->c.ops = &snd_opl4_mem_proc_ops;
 		entry->module = THIS_MODULE;
 		entry->private_data = opl4;
-		if (snd_info_register(entry) < 0) {
-			snd_info_free_entry(entry);
-			entry = NULL;
-		}
 	}
 	opl4->proc_entry = entry;
 	return 0;