From patchwork Wed Feb 6 02:18:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yizhuo Zhai X-Patchwork-Id: 10798749 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 83EBF1390 for ; Wed, 6 Feb 2019 02:18:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6DBFC2AC21 for ; Wed, 6 Feb 2019 02:18:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5F8952AC40; Wed, 6 Feb 2019 02:18:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 121332AC21 for ; Wed, 6 Feb 2019 02:18:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=4KvQXgRd3TolDTgV393nqW2bQ1CXBg5hmmdBcqyWRSA=; b=Prn hZSjq4rnLFpdSMDOnJDDulaYZv8aPR0n+99wtPYsntgxavi/YLnxpUKaXEmrnSscUcsvpoW071igh IYsa7BX5YLCF89vdumQ1lucOB8DPvWUu7v12joE1xtpmavbEeatEoTIyOGVAmxLbccHjN7LQAPCnL mWTm9Oqv3eQ2zg/t1jedgjyKnb+AVmSw5ZrNgHqLKI8A6uo6mDvOliy27IP/bvpGEfVrj94H3ZyVE ArPI2/DiqkC1WdxMj9eC/6x15rFnxwomrLMcTKdAnxsE/k1qc5KpEQ47F3HMQdY83q67f7uQL1jZU vr2WI9cgMKOYJgyOEea9K7jSKa69Syw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1grCnd-0006J5-LC; Wed, 06 Feb 2019 02:18:53 +0000 Received: from mx1.ucr.edu ([138.23.248.2]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1grCnX-0006Hn-9A for linux-rockchip@lists.infradead.org; Wed, 06 Feb 2019 02:18:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1549419527; x=1580955527; h=from:to:cc:subject:date:message-id; bh=D0JGImJ9qrSJZ/loF6Jscsoui2BmjSV1/GLZh7cocuo=; b=cdlhx2OylaMq2wg8cB+Abu7RhPgUf9FX2/rhzdOB5y2ayoQuZIbEpRzj gel4R/eq8KsVuIYSHra0+JdtFEqXH7ae2h6Nbp+Y3xlM4FLpdTU329MIV OdKl8K2jzWpVHeWgsJp802co1YV7AMIrAx8OobEMrE+yrz2M29wa6qQuX oQDdPGB0CBPe8F9d7cL2uX37nz4t3UqNAkzQ3jSaJJ0D4GJRD7L1n2vb9 V3CYn5joNTW9Fy5SUuqAFCIZdnx9BaIkajDZFAHFV4Ii7Eii752zeQLZJ L+732lK8msYn8i09SvS1yd2fNwCuQyr02Yc7in+ERMNYV1tdUWyN8Bqwr Q==; IronPort-PHdr: 9a23:pnmBLxwc1Gv1FTjXCy+O+j09IxM/srCxBDY+r6Qd1OMSIJqq85mqBkHD//Il1AaPAd2Lraocw8Pt8InYEVQa5piAtH1QOLdtbDQizfssogo7HcSeAlf6JvO5JwYzHcBFSUM3tyrjaRsdF8nxfUDdrWOv5jAOBBr/KRB1JuPoEYLOksi7ze+/94HQbglSmDaxfa55IQmrownWqsQYm5ZpJLwryhvOrHtIeuBWyn1tKFmOgRvy5dq+8YB6/ShItP0v68BPUaPhf6QlVrNYFygpM3o05MLwqxbOSxaE62YGXWUXlhpIBBXF7A3/U5zsvCb2qvZx1S+HNsDtU7s6RSqt4LtqSB/wiScIKTg58H3MisdtiK5XuQ+tqwBjz4LRZoyVMft+frjGfdMbQ2pBUdtaWTJYDIihYYsPDvQOPeJFoILgo1cDoweyCQyqCejyyDFHm2X20LU63eo/DA/I0g8uEdUVvXjIsNn4LrseXPqpwKXUyzjIcvNY2S366IjNah0uo/CMXLNwccrMzkkkCgTIj1WRqIzlJTyV1/gBv3SV4ud7SOKgl3QnpxtvrTey28chk4/EjZ8WxFDc7Sh13po5KNmiREN4YdOoCoVcuzyaOodsXM8uX31ktD4nxrAHvZO3ZjYGxZonyhLFdfCKcpKE7xDsWeuXPDx2nmhqeKiliBa36UWgz+r8WdSq31tStSpFl8XMtmgK1xzO9siLUvt98Vml2TaIzw3T7/tLIUEwlabCM54hzaM8moMdsUjdAiP6hF/6jKCRdkUj9eio7/robq/6qZ+bMo94kgD+MqIwlcyjGek0LBQCUmyB9em/1LDv51P1TKhKg/EsjKXVrIzWKdwepqGjAg9V1ogj6wy4DzejyNkZnXgGLFJfdxKGk4TlJ1/DLevlDfijmVSgiilkyO3bPrH5GJXCMmDDkKv9fbZ680NczAszzdZC55NbE70BOvXzVVPytNPEDh85MhS0zv3jCNV8zYMeRXmPDrWYMKPUv1+I/PggLPSSa4APpTnxMf8l5+ThjSxxt0UaePyY3IkXdXfwSuV0I0yYOSK3qsoKCyEHshdoH7+is0GLTTMGPyX6ZKk7/DxuTd3+AA== X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BsAACjQ1pcgMjXVdFlHAEBAQQBAQcEAQGBUwUBAQsBgztKD4x8ixZPAQEBBoplGG2FWIJzhQ+BewEKAQEshECDFCI2Bw0BAwEBAgEBAgETAQEJDQkIGwwxgjopgl82UlY/AQUBNVuCRwGBdA2hETyMFzOIYwEHgUsJAQiHcIRBgQ+BB4NuhH+DVIJDAoEsAQEBkAiRSAEGAgGBZYFDjwwlgzaHAIgUAS2bPQIEAgQFAgUPIYEsBoIBTSWBbAqBRIJSjiweM4EHiyaCTQE X-IPAS-Result: A2BsAACjQ1pcgMjXVdFlHAEBAQQBAQcEAQGBUwUBAQsBgztKD4x8ixZPAQEBBoplGG2FWIJzhQ+BewEKAQEshECDFCI2Bw0BAwEBAgEBAgETAQEJDQkIGwwxgjopgl82UlY/AQUBNVuCRwGBdA2hETyMFzOIYwEHgUsJAQiHcIRBgQ+BB4NuhH+DVIJDAoEsAQEBkAiRSAEGAgGBZYFDjwwlgzaHAIgUAS2bPQIEAgQFAgUPIYEsBoIBTSWBbAqBRIJSjiweM4EHiyaCTQE X-IronPort-AV: E=Sophos;i="5.58,338,1544515200"; d="scan'208";a="1052826307" Received: from mail-pg1-f200.google.com ([209.85.215.200]) by smtp1.ucr.edu with ESMTP/TLS/AES128-GCM-SHA256; 05 Feb 2019 18:18:23 -0800 Received: by mail-pg1-f200.google.com with SMTP id s27so3615652pgm.4 for ; Tue, 05 Feb 2019 18:18:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vKCJp8IORvIsHrDyUZajuZHeMiJCJviDrMcOZ6kuFfg=; b=CahzudZH1j+QC9YnFjCFHMUIEia/lVC+voR5XVPFqYHEUeyXLzKV4iUhVi7z/Bz8qj bvgzqgntpgfxl4XFCfXThMLX60pMVFzfUZvmfIlO63S0hjK8uqtbMiYan9gFxmbogEuO 6oOi5zgfRX9B8uRdVwkjcGPKnHls8f3ztCJU4AVji09g2J9dH4nnPYAbTaph8lCWDiTw WuGqOffxTnNuefy/F/okOH26/0Cqajsw4qRWBYiuPQnQKGowOYw55s0KhwPJcMA9ZCyy 7sM1f+o0dk7xF6i/QKTsaEMWweDyBFBcI7tSj+qDGteiMnIPDMnmxm3lyMxBCPhva9fH dmQA== X-Gm-Message-State: AHQUAubTsicgW/NCcETB5j/pi0SCpiYgGDpoQQkzXE0f7dsbVr1BPOET TwaRpcXlS5AfwD4ouksqAcV/qk/YgcE5AekWBjOghqzRvl365Bv/f6slKRSqOHJ1FQnH/yw/kgE pbnregyYzpM4pPUi4Gj+/eBm+PKF4ly2j4w== X-Received: by 2002:a62:2f06:: with SMTP id v6mr8215635pfv.216.1549419502692; Tue, 05 Feb 2019 18:18:22 -0800 (PST) X-Google-Smtp-Source: AHgI3IZX1CcpPLb8Db6nC9eW9nN5ZiP7BmEjOoo6MOm0zKDcy9yHAdu7iX0RDp7j7avOaFBbWl3AZw== X-Received: by 2002:a62:2f06:: with SMTP id v6mr8215626pfv.216.1549419502430; Tue, 05 Feb 2019 18:18:22 -0800 (PST) Received: from Yizhuo.cs.ucr.edu (yizhuo.cs.ucr.edu. [169.235.26.74]) by smtp.googlemail.com with ESMTPSA id a13sm4893878pgq.65.2019.02.05.18.18.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Feb 2019 18:18:21 -0800 (PST) From: Yizhuo To: Subject: [PATCH] phy: rockchip-typec: Variable "val" of function rockchip_usb3_phy_power_on() could be uninitialized Date: Tue, 5 Feb 2019 18:18:10 -0800 Message-Id: <20190206021810.21596-1-yzhai003@ucr.edu> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190205_181847_466969_C43DE796 X-CRM114-Status: GOOD ( 12.58 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: csong@cs.ucr.edu, Heiko Stuebner , zhiyunq@cs.ucr.edu, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Yizhuo , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In function rockchip_usb3_phy_power_on(), local variable "val" could be uninitialized if function regmap_read() returns -EINVAL. However, this value is directly used in later context. This is potentially unsafe. Signed-off-by: Yizhuo Reviewed-by: Heiko Stuebner --- drivers/phy/rockchip/phy-rockchip-typec.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c index a958c9bced01..b1e24418cb2d 100644 --- a/drivers/phy/rockchip/phy-rockchip-typec.c +++ b/drivers/phy/rockchip/phy-rockchip-typec.c @@ -716,7 +716,10 @@ static int rockchip_usb3_phy_power_on(struct phy *phy) /* wait TCPHY for pipe ready */ for (timeout = 0; timeout < 100; timeout++) { - regmap_read(tcphy->grf_regs, reg->offset, &val); + ret = regmap_read(tcphy->grf_regs, reg->offset, &val); + if (ret) + goto unlock_ret; + if (!(val & BIT(reg->enable_bit))) { tcphy->mode |= new_mode & (MODE_DFP_USB | MODE_UFP_USB); goto unlock_ret;