[v2,1/2] ASoC: ssm2602: switch to SPDX identifier
diff mbox series

Message ID 20190206152947.2789-1-m.felsch@pengutronix.de
State New
Headers show
Series
  • [v2,1/2] ASoC: ssm2602: switch to SPDX identifier
Related show

Commit Message

Marco Felsch Feb. 6, 2019, 3:29 p.m. UTC
Drop old license header and switch to SPDX-License-Identifier.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
Changelog:
v2:
 - new created

 sound/soc/codecs/ssm2602.c | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

Comments

Marco Felsch Feb. 6, 2019, 4:29 p.m. UTC | #1
Hi Mark,

On 19-02-06 15:32, Mark Brown wrote:
> On Wed, Feb 06, 2019 at 04:29:46PM +0100, Marco Felsch wrote:
> 
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> >  /*
> >   * File:         sound/soc/codecs/ssm2602.c
> >   * Author:       Cliff Cai <Cliff.Cai@analog.com>
> 
> Please convert the entire comment to C++ style so it looks more
> intentional and is consistent with other ASoC stuff.

Okay, I will do this in the v3.

Regards,
Marco
Uwe Kleine-König Feb. 6, 2019, 4:51 p.m. UTC | #2
On Wed, Feb 06, 2019 at 03:32:44PM +0000, Mark Brown wrote:
> On Wed, Feb 06, 2019 at 04:29:46PM +0100, Marco Felsch wrote:
> 
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> >  /*
> >   * File:         sound/soc/codecs/ssm2602.c
> >   * Author:       Cliff Cai <Cliff.Cai@analog.com>
> 
> Please convert the entire comment to C++ style so it looks more
> intentional and is consistent with other ASoC stuff.

I don't know about how ASoC is special here, but I've seen the style
picked by Marco quite often and considered that the "usual" style.
Usually kernel code mandates C style comments and I though only the
SPDX-specifier is special.

So ASoC is different in this aspect?

Best regards
Uwe
Mark Brown Feb. 6, 2019, 4:57 p.m. UTC | #3
On Wed, Feb 06, 2019 at 05:51:05PM +0100, Uwe Kleine-König wrote:
> On Wed, Feb 06, 2019 at 03:32:44PM +0000, Mark Brown wrote:

> > Please convert the entire comment to C++ style so it looks more
> > intentional and is consistent with other ASoC stuff.

> I don't know about how ASoC is special here, but I've seen the style
> picked by Marco quite often and considered that the "usual" style.
> Usually kernel code mandates C style comments and I though only the
> SPDX-specifier is special.

> So ASoC is different in this aspect?

I'm doing the same for other subsystems - I was getting patches from
people converting the SPDX headers back to C comments and it just looks
ugly to me anyway to mix the styles on adjacent lines.

Patch
diff mbox series

diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c
index 501a4e73b185..580ab8916854 100644
--- a/sound/soc/codecs/ssm2602.c
+++ b/sound/soc/codecs/ssm2602.c
@@ -1,3 +1,4 @@ 
+// SPDX-License-Identifier: GPL-2.0-or-later
 /*
  * File:         sound/soc/codecs/ssm2602.c
  * Author:       Cliff Cai <Cliff.Cai@analog.com>
@@ -9,21 +10,6 @@ 
  *               Copyright 2008 Analog Devices Inc.
  *
  * Bugs:         Enter bugs at http://blackfin.uclinux.org/
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, see the file COPYING, or write
- * to the Free Software Foundation, Inc.,
- * 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
  */
 
 #include <linux/module.h>