| Message ID | 20190207064535.9226-8-wens@csie.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ARM: sun8i: a83t: Enable USB OTG | expand |
On Thu, 07 Feb 2019, Chen-Yu Tsai wrote: > From: Quentin Schulz <quentin.schulz@bootlin.com> > > The AXP813 has a VBUS power input. Now that the axp20x_usb_power driver > supports this variant, we can add an mfd cell for it to use it. > > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> > [wens@csie.org: add commit message] > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > drivers/mfd/axp20x.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 3c97f2c0fdfe..17b115845993 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -198,6 +198,12 @@ static const struct resource axp22x_usb_power_supply_resources[] = { > DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), > }; > > +/* AXP803 and AXP813/AXP818 share the same interrupts */ > +static struct resource axp803_usb_power_supply_resources[] = { > + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_PLUGIN, "VBUS_PLUGIN"), > + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), Nit: Why 2 spaces here? ^ With that fixed, you can add my: For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
On Thu, Feb 7, 2019 at 7:02 PM Lee Jones <lee.jones@linaro.org> wrote: > > On Thu, 07 Feb 2019, Chen-Yu Tsai wrote: > > > From: Quentin Schulz <quentin.schulz@bootlin.com> > > > > The AXP813 has a VBUS power input. Now that the axp20x_usb_power driver > > supports this variant, we can add an mfd cell for it to use it. > > > > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> > > [wens@csie.org: add commit message] > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > --- > > drivers/mfd/axp20x.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > > index 3c97f2c0fdfe..17b115845993 100644 > > --- a/drivers/mfd/axp20x.c > > +++ b/drivers/mfd/axp20x.c > > @@ -198,6 +198,12 @@ static const struct resource axp22x_usb_power_supply_resources[] = { > > DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), > > }; > > > > +/* AXP803 and AXP813/AXP818 share the same interrupts */ > > +static struct resource axp803_usb_power_supply_resources[] = { > > + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_PLUGIN, "VBUS_PLUGIN"), > > + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), > > Nit: Why 2 spaces here? ^ 2 spaces? I'm only seeing one. > With that fixed, you can add my: > > For my own reference: > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org> > > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
On Thu, Feb 07, 2019 at 02:45:33PM +0800, Chen-Yu Tsai wrote: > From: Quentin Schulz <quentin.schulz@bootlin.com> > > The AXP813 has a VBUS power input. Now that the axp20x_usb_power driver > supports this variant, we can add an mfd cell for it to use it. > > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> > [wens@csie.org: add commit message] > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > drivers/mfd/axp20x.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 3c97f2c0fdfe..17b115845993 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -198,6 +198,12 @@ static const struct resource axp22x_usb_power_supply_resources[] = { > DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), > }; > > +/* AXP803 and AXP813/AXP818 share the same interrupts */ > +static struct resource axp803_usb_power_supply_resources[] = { const, if possible? > + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_PLUGIN, "VBUS_PLUGIN"), > + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), > +}; > + > static const struct resource axp22x_pek_resources[] = { > DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_PEK_RIS_EDGE, "PEK_DBR"), > DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_PEK_FAL_EDGE, "PEK_DBF"), > @@ -793,6 +799,11 @@ static const struct mfd_cell axp813_cells[] = { > .of_compatible = "x-powers,axp813-ac-power-supply", > .num_resources = ARRAY_SIZE(axp20x_ac_power_supply_resources), > .resources = axp20x_ac_power_supply_resources, > + }, { > + .name = "axp20x-usb-power-supply", > + .num_resources = ARRAY_SIZE(axp803_usb_power_supply_resources), > + .resources = axp803_usb_power_supply_resources, > + .of_compatible = "x-powers,axp813-usb-power-supply", > }, > }; > > -- > 2.20.1 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.
On Thu, 07 Feb 2019, Chen-Yu Tsai wrote: > On Thu, Feb 7, 2019 at 7:02 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > On Thu, 07 Feb 2019, Chen-Yu Tsai wrote: > > > > > From: Quentin Schulz <quentin.schulz@bootlin.com> > > > > > > The AXP813 has a VBUS power input. Now that the axp20x_usb_power driver > > > supports this variant, we can add an mfd cell for it to use it. > > > > > > Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> > > > [wens@csie.org: add commit message] > > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > > --- > > > drivers/mfd/axp20x.c | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > > > index 3c97f2c0fdfe..17b115845993 100644 > > > --- a/drivers/mfd/axp20x.c > > > +++ b/drivers/mfd/axp20x.c > > > @@ -198,6 +198,12 @@ static const struct resource axp22x_usb_power_supply_resources[] = { > > > DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), > > > }; > > > > > > +/* AXP803 and AXP813/AXP818 share the same interrupts */ > > > +static struct resource axp803_usb_power_supply_resources[] = { > > > + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_PLUGIN, "VBUS_PLUGIN"), > > > + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), > > > > Nit: Why 2 spaces here? ^ > > 2 spaces? I'm only seeing one. Eh, that's odd. My eyes must be failing me. Just add my Ack then. :)
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index 3c97f2c0fdfe..17b115845993 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c @@ -198,6 +198,12 @@ static const struct resource axp22x_usb_power_supply_resources[] = { DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), }; +/* AXP803 and AXP813/AXP818 share the same interrupts */ +static struct resource axp803_usb_power_supply_resources[] = { + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_PLUGIN, "VBUS_PLUGIN"), + DEFINE_RES_IRQ_NAMED(AXP803_IRQ_VBUS_REMOVAL, "VBUS_REMOVAL"), +}; + static const struct resource axp22x_pek_resources[] = { DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_PEK_RIS_EDGE, "PEK_DBR"), DEFINE_RES_IRQ_NAMED(AXP22X_IRQ_PEK_FAL_EDGE, "PEK_DBF"), @@ -793,6 +799,11 @@ static const struct mfd_cell axp813_cells[] = { .of_compatible = "x-powers,axp813-ac-power-supply", .num_resources = ARRAY_SIZE(axp20x_ac_power_supply_resources), .resources = axp20x_ac_power_supply_resources, + }, { + .name = "axp20x-usb-power-supply", + .num_resources = ARRAY_SIZE(axp803_usb_power_supply_resources), + .resources = axp803_usb_power_supply_resources, + .of_compatible = "x-powers,axp813-usb-power-supply", }, };