[2/2] ARM: shmobile: Fix R-Car Gen2 regulator quirk
diff mbox series

Message ID 5347a0203709d5039a74d7c94e23519eee478094.1549622472.git.horms+renesas@verge.net.au
State Accepted
Commit 5347a0203709d5039a74d7c94e23519eee478094
Delegated to: Simon Horman
Headers show
  • [GIT,PULL] Renesas ARM Based SoC Updates for v5.1
Related show

Commit Message

Simon Horman Feb. 8, 2019, 11:14 a.m. UTC
From: Marek Vasut <marek.vasut@gmail.com>

The quirk code currently detects all compatible I2C chips with a shared
IRQ line on all I2C busses, adds them into a list, and registers a bus
notifier. For every chip for which the bus notifier triggers, the quirk
code performs I2C transfer on that I2C bus for all addresses in the list.
The problem is that this may generate transfers to non-existing chips on
systems with multiple I2C busses.

This patch adds a check to verify that the I2C bus to which the chip with
shared IRQ is attached to matches the I2C bus of the chip which triggered
the bus notifier and only starts the I2C transfer if they match.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Tested-by: Nguyen Viet Dung <dung.nguyen.aj@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
 arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c | 5 +++++
 1 file changed, 5 insertions(+)

diff mbox series

diff --git a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
index 8e50daa99151..dc526ef2e9b3 100644
--- a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
+++ b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
@@ -40,6 +40,7 @@ 
 struct regulator_quirk {
 	struct list_head		list;
 	const struct of_device_id	*id;
+	struct device_node		*np;
 	struct of_phandle_args		irq_args;
 	struct i2c_msg			i2c_msg;
 	bool				shared;	/* IRQ line is shared */
@@ -101,6 +102,9 @@  static int regulator_quirk_notify(struct notifier_block *nb,
 		if (!pos->shared)
+		if (pos->np->parent != client->dev.parent->of_node)
+			continue;
 		dev_info(&client->dev, "clearing %s@0x%02x interrupts\n",
 			 pos->id->compatible, pos->i2c_msg.addr);
@@ -165,6 +169,7 @@  static int __init rcar_gen2_regulator_quirk(void)
 		memcpy(&quirk->i2c_msg, id->data, sizeof(quirk->i2c_msg));
 		quirk->id = id;
+		quirk->np = np;
 		quirk->i2c_msg.addr = addr;
 		ret = of_irq_parse_one(np, 0, argsa);