arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues
diff mbox series

Message ID 20190210170214.12057-1-pgwipeout@gmail.com
State New
Headers show
Series
  • arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues
Related show

Commit Message

Peter Geis Feb. 10, 2019, 5:02 p.m. UTC
This patch is a port of the fix from
commit 73e42e186699 ("arm64: dts: rockchip: fix rock64 gmac2io stability
issues")

As per that patch, enabling thresh dma mode force disables checksuming.
This is necessary as tx checksuming does not work with packets larger
than 1498.

The rk3328-roc-cc board exhibits tx stability issues with large packets
similar to rock64's issues. This patch resolves that issue.
---
 arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Heiko Stuebner Feb. 10, 2019, 5:55 p.m. UTC | #1
Hi Peter,

Am Sonntag, 10. Februar 2019, 18:02:14 CET schrieb Peter Geis:
> This patch is a port of the fix from
> commit 73e42e186699 ("arm64: dts: rockchip: fix rock64 gmac2io stability
> issues")
> 
> As per that patch, enabling thresh dma mode force disables checksuming.
> This is necessary as tx checksuming does not work with packets larger
> than 1498.
> 
> The rk3328-roc-cc board exhibits tx stability issues with large packets
> similar to rock64's issues. This patch resolves that issue.

Patch itself looks good, but here you're missing a Signed-off-by line, see
	Documentation/process/submitting-patches.rst
section "11) Sign your work - the Developer's Certificate of Origin"
for reference


Heiko

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
index 99d0d9912950..33c44e857247 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
@@ -104,6 +104,7 @@ 
 	phy-mode = "rgmii";
 	pinctrl-names = "default";
 	pinctrl-0 = <&rgmiim1_pins>;
+	snps,force_thresh_dma_mode;
 	snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
 	snps,reset-active-low;
 	snps,reset-delays-us = <0 10000 50000>;