libertas_tf: lower the debug level of command trace
diff mbox series

Message ID 20190210194735.17939-1-lkundrak@v3.sk
State Accepted
Commit 744972b2c4d2f62e5a1dde28404ec0f359726771
Delegated to: Kalle Valo
Headers show
Series
  • libertas_tf: lower the debug level of command trace
Related show

Commit Message

Lubomir Rintel Feb. 10, 2019, 7:47 p.m. UTC
Logging each and every command response is way too much for INFO level.
Silence this, unless CONFIG_LIBERTAS_THINFIRM_DEBUG has been enabled.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 drivers/net/wireless/marvell/libertas_tf/cmd.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Steve deRosier Feb. 11, 2019, 1:23 p.m. UTC | #1
On Sun, Feb 10, 2019 at 11:47 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> Logging each and every command response is way too much for INFO level.
> Silence this, unless CONFIG_LIBERTAS_THINFIRM_DEBUG has been enabled.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  drivers/net/wireless/marvell/libertas_tf/cmd.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas_tf/cmd.c b/drivers/net/wireless/marvell/libertas_tf/cmd.c
> index 909ac3685010..64b147dd2432 100644
> --- a/drivers/net/wireless/marvell/libertas_tf/cmd.c
> +++ b/drivers/net/wireless/marvell/libertas_tf/cmd.c
> @@ -737,10 +737,9 @@ int lbtf_process_rx_command(struct lbtf_private *priv)
>         respcmd = le16_to_cpu(resp->command);
>         result = le16_to_cpu(resp->result);
>
> -       if (net_ratelimit())
> -               pr_info("libertastf: cmd response 0x%04x, seq %d, size %d\n",
> -                       respcmd, le16_to_cpu(resp->seqnum),
> -                       le16_to_cpu(resp->size));
> +       lbtf_deb_cmd("libertastf: cmd response 0x%04x, seq %d, size %d\n",
> +                    respcmd, le16_to_cpu(resp->seqnum),
> +                    le16_to_cpu(resp->size));
>
>         if (resp->seqnum != priv->cur_cmd->cmdbuf->seqnum) {
>                 spin_unlock_irqrestore(&priv->driver_lock, flags);
> --
> 2.20.1
>

Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
Kalle Valo Feb. 19, 2019, 3:10 p.m. UTC | #2
Lubomir Rintel <lkundrak@v3.sk> wrote:

> Logging each and every command response is way too much for INFO level.
> Silence this, unless CONFIG_LIBERTAS_THINFIRM_DEBUG has been enabled.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> Reviewed-by: Steve deRosier <derosier@cal-sierra.com>

Patch applied to wireless-drivers-next.git, thanks.

744972b2c4d2 libertas_tf: lower the debug level of command trace

Patch
diff mbox series

diff --git a/drivers/net/wireless/marvell/libertas_tf/cmd.c b/drivers/net/wireless/marvell/libertas_tf/cmd.c
index 909ac3685010..64b147dd2432 100644
--- a/drivers/net/wireless/marvell/libertas_tf/cmd.c
+++ b/drivers/net/wireless/marvell/libertas_tf/cmd.c
@@ -737,10 +737,9 @@  int lbtf_process_rx_command(struct lbtf_private *priv)
 	respcmd = le16_to_cpu(resp->command);
 	result = le16_to_cpu(resp->result);
 
-	if (net_ratelimit())
-		pr_info("libertastf: cmd response 0x%04x, seq %d, size %d\n",
-			respcmd, le16_to_cpu(resp->seqnum),
-			le16_to_cpu(resp->size));
+	lbtf_deb_cmd("libertastf: cmd response 0x%04x, seq %d, size %d\n",
+		     respcmd, le16_to_cpu(resp->seqnum),
+		     le16_to_cpu(resp->size));
 
 	if (resp->seqnum != priv->cur_cmd->cmdbuf->seqnum) {
 		spin_unlock_irqrestore(&priv->driver_lock, flags);