[GIT,PULL,1/8] lightnvm: pblk: stop taking the free lock in in pblk_lines_free
diff mbox series

Message ID 20190211122509.19910-2-mb@lightnvm.io
State New
Headers show
  • lightnvm updates for 5.1
Related show

Commit Message

Matias Bjørling Feb. 11, 2019, 12:25 p.m. UTC
From: Hans Holmberg <hans.holmberg@cnexlabs.com>

pblk_line_meta_free might sleep (it can end up calling vfree, depending
on how we allocate lba lists), and this can lead to a BUG()
if we wake up on a different cpu and release the lock.

As there is no point of grabbing the free lock when pblk has shut down,
remove the lock.

Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
 drivers/lightnvm/pblk-init.c | 2 --
 1 file changed, 2 deletions(-)

diff mbox series

diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index f9a3e47b6a93..eb0135c77805 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -584,14 +584,12 @@  static void pblk_lines_free(struct pblk *pblk)
 	struct pblk_line *line;
 	int i;
-	spin_lock(&l_mg->free_lock);
 	for (i = 0; i < l_mg->nr_lines; i++) {
 		line = &pblk->lines[i];
 		pblk_line_meta_free(l_mg, line);
-	spin_unlock(&l_mg->free_lock);