From patchwork Tue Feb 12 05:59:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 10807379 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AF16617E0 for ; Tue, 12 Feb 2019 06:00:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9E7B12AF01 for ; Tue, 12 Feb 2019 06:00:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9276F2AF10; Tue, 12 Feb 2019 06:00:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 28A882AF01 for ; Tue, 12 Feb 2019 06:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726269AbfBLGAr (ORCPT ); Tue, 12 Feb 2019 01:00:47 -0500 Received: from mout.gmx.net ([212.227.15.15]:46809 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725550AbfBLGAr (ORCPT ); Tue, 12 Feb 2019 01:00:47 -0500 Received: from localhost.localdomain ([218.18.229.179]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0Ma1pn-1geo9K3HCx-00LpQZ; Tue, 12 Feb 2019 07:00:38 +0100 From: Chengguang Xu To: alex.williamson@redhat.com, kwankhede@nvidia.com Cc: kvm@vger.kernel.org, Chengguang Xu Subject: [PATCH 2/4] samples/vfio-mdev/mbochs: expand minor range when registering chrdev region Date: Tue, 12 Feb 2019 13:59:30 +0800 Message-Id: <20190212055932.8825-2-cgxu519@gmx.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190212055932.8825-1-cgxu519@gmx.com> References: <20190212055932.8825-1-cgxu519@gmx.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:dwsh+CqzbspXqQsAwpObR/AKs+zmjVSt31cY2UNZBKGEdxDniqt 92MVwnXa9ykxXQqKCS3HZc4q6VnLFJ/gYJSRCikhdITOKNzxzv6dljpwcTJ4uYCbzIw6CnK y8k0kVukoDELaSELXdrfo/C0z7qv5mb26neQjr09L9FO1PPcglzLNbJwhuLc2PQDwFzEiIC nb2Qi5v04v7jAlPF4/h5g== X-UI-Out-Filterresults: notjunk:1;V03:K0:5MyLZwufjd8=:M35PP/ZfrDWS9qYksYarmd fOoo8s5eswRch/9eCv9pu4JZo0EXKmltQYpEm9ichq/GI6uVUwTAsUBqzIRxjrkZMSh4W407V jAy/WgKf5axobyIJUSNp4sVZnT3/3x81jL5YZMJpz36ocswGV1PtIJhAdYM7ZPMm8eTHjHmqz wUIllFXBKZ7umwrJKM+7YUvkyCQ0Bu/SxXWAJLg+ibcZJDmj+oGFKOjKAMaNUAIwVKmVkfu5S UuwoLay3wnSEKUGCuy1Xg0H9N16VC1LLn0ISJ7WTHaifTbUnAVZaKmFMeTVaok08rWVs03cYv wH0uHg8o+T4fZPy1UUtPAvkr1DkF4yUUhHUciPw7/A4S0WxLT24jpM3cFHpKcfLvN9AvvSK4+ W25ELpi0w6xDY7REf7BbJy05jVRreQGMH5swTPTh0Ur+kiSPGkFtcJLA420e1V/WRCyrwG2K+ wiLmAm9IyiVbpHpt6nl1XY+CSnTkV87ieZJfeDmJpw1Z30tScbDbFVhcg2fHWvUn0PJD1vZIs svCvQoTxE1DDNego3l0BXmGWaU1nfKQNkjglKF2u+y/RhE//lXz4kKFmDi3OfbP8/GIMocYTu IkkMUGaogE1mxSY0CIG8qlJkc4gQ76IAw50q8wavExDAqChyNZGuapcde8WokoWKKCAWMZxSx oj2rSSN4BGhWLuAzY6ZyfCuHvSiji235e9UD2MlK4hFRZewfoxJWYOx0vYxa4RuToFE4ady2h 7V8Ml3+DjZyD9Zv5MpgqZBey7UqX2t929ruly2KDIpUC3URsppvHWd/9Ug4XhHlmwZ8RcVDxq eHZ+3Z7UrH5rE7/tCtHX8VoZOOfH4cYeLYDLn+mqSdRmzb5j4M3JloPumGcHtz3HXOkcokwZ+ O9vLyhsHJHvlXMUCcLdmWQC6rFrvON12SKfVQ5+2ibCU/AZdtWrKvFhLqUuBya Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Actually, total amount of available minor number for a single major is MINORMARK + 1. So expand minor range when registering chrdev region. Signed-off-by: Chengguang Xu --- samples/vfio-mdev/mbochs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c index ca7960adf5a3..b038aa9f5a70 100644 --- a/samples/vfio-mdev/mbochs.c +++ b/samples/vfio-mdev/mbochs.c @@ -1448,13 +1448,13 @@ static int __init mbochs_dev_init(void) { int ret = 0; - ret = alloc_chrdev_region(&mbochs_devt, 0, MINORMASK, MBOCHS_NAME); + ret = alloc_chrdev_region(&mbochs_devt, 0, MINORMASK + 1, MBOCHS_NAME); if (ret < 0) { pr_err("Error: failed to register mbochs_dev, err: %d\n", ret); return ret; } cdev_init(&mbochs_cdev, &vd_fops); - cdev_add(&mbochs_cdev, mbochs_devt, MINORMASK); + cdev_add(&mbochs_cdev, mbochs_devt, MINORMASK + 1); pr_info("%s: major %d\n", __func__, MAJOR(mbochs_devt)); mbochs_class = class_create(THIS_MODULE, MBOCHS_CLASS_NAME); @@ -1483,7 +1483,7 @@ static int __init mbochs_dev_init(void) class_destroy(mbochs_class); failed1: cdev_del(&mbochs_cdev); - unregister_chrdev_region(mbochs_devt, MINORMASK); + unregister_chrdev_region(mbochs_devt, MINORMASK + 1); return ret; } @@ -1494,7 +1494,7 @@ static void __exit mbochs_dev_exit(void) device_unregister(&mbochs_dev); cdev_del(&mbochs_cdev); - unregister_chrdev_region(mbochs_devt, MINORMASK); + unregister_chrdev_region(mbochs_devt, MINORMASK + 1); class_destroy(mbochs_class); mbochs_class = NULL; }