From patchwork Tue Feb 12 05:59:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 10807381 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8A30913B4 for ; Tue, 12 Feb 2019 06:00:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A1A72AF01 for ; Tue, 12 Feb 2019 06:00:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6DED72AF10; Tue, 12 Feb 2019 06:00:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E19F2AF01 for ; Tue, 12 Feb 2019 06:00:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727018AbfBLGAy (ORCPT ); Tue, 12 Feb 2019 01:00:54 -0500 Received: from mout.gmx.net ([212.227.15.15]:45641 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726985AbfBLGAy (ORCPT ); Tue, 12 Feb 2019 01:00:54 -0500 Received: from localhost.localdomain ([218.18.229.179]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0MEFIm-1grECz254y-00FQCC; Tue, 12 Feb 2019 07:00:46 +0100 From: Chengguang Xu To: alex.williamson@redhat.com, kwankhede@nvidia.com Cc: kvm@vger.kernel.org, Chengguang Xu Subject: [PATCH 3/4] samples/vfio-mdev/mdpy: expand minor range when registering chrdev region Date: Tue, 12 Feb 2019 13:59:31 +0800 Message-Id: <20190212055932.8825-3-cgxu519@gmx.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190212055932.8825-1-cgxu519@gmx.com> References: <20190212055932.8825-1-cgxu519@gmx.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:bNJV7R7f12bEhmUf20yA9jI9aDx4yzfHLg5oarNLN7D480YO4y7 4Bha1w3pgwf9nAADz+J2Fh3qtTZQopYn/jzxdPf8rZk040yfdfvFt2R+03NCZYvdTc8Ai4Y NfnElkLYH1y9FzXXzYOIl9dFdSNUx/kVGp6Xf10Del5B8Xl4OEasvWe1haM7Al19mLQBnds 1ebIwm1G3Xc7Z5HYqm71Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:6fcl5Zn9CXE=:Wbq7N9ZfHbCLqoycrbwt0s Wjc0XxVV3hp/edK6SE5owSe8N7/VRdDi3dTzbYe6xkOn2aQc+y1WaBzmtECOTGYGnolNVBFeC XrGETGm2S4oftIyqAeWHOGzj/Sbf2GsdbZtlalSPaoq2tqCogmJryAWZB1YodJLapD6EfXLaV mhqWQlPVygNbUZcJ77wa+gdgurIxcadc+uB/RUK3GseAoSXu1LFTDFrOogDKjELlHjZ5dM8yq 3wH7KrBvT0ppjPaT7PqU+ii1L7Pmvq4dCGU8ybtHD5tHNxLsvrWLr+ewjLpgodF6yLFScdl21 mZ8krW7nbB2ZZeya7IT8uovrmW0AlynUWit6ZIFUvZv1pRqM2fTa0XYgflKtsm2HvuUl1eGqR KKQxkPJsjzDRXbnsRvOlizmhd25z73Q34sgSdVepfNC4cW2LTJ01Crf5jT/+ZlaaYmKSmUd1g ia+ITZ3+Bs5Ctqm3aLb/aMyDpb2DSPimTSPft90SCzEINLlIvc5hVKSk8iMhwrG8UQUgSP5iM MII1THftT2wzbr4hRq1tleJuq8UEv++p5ZzxJGkHevsbSNhgjKLJVfnGuFLH+IO9BmuHIgOFf E/aMtPS3USc+BVHAKYO2RHx4KjsQfe4U9XqRSYlYwrjfEMD9iMYsgn9JCqQdHW1rx1JvH1Syh mMnDVfnxoG1rUujRVn5ikt1lwsjkRrpu45x2IvilGHwuwkq1/QyGOdflTIfgr93bqFj3xJfyq RZi7kDEoVKbxiV4J6oWMBYjFUmmMSiL8zp8LFt4B7lc4veNpxupdkuvCwjwF9+iRMexc9mKIu /CXjvNWQ9KrFlUkZOapGL/GA+IEtA0Pw11sRgZXCl5K31V0KGWL9p3i//t5KVkUFRoAp/VNzE jcSYVsbq5dX2yUSGACFu09up8WXHhQjtLUstpIf3UkEbYmQ71Okxphimc0A6Wx Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Actually, total amount of available minor number for a single major is MINORMARK + 1. So expand minor range when registering chrdev region. Signed-off-by: Chengguang Xu --- samples/vfio-mdev/mdpy.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/samples/vfio-mdev/mdpy.c b/samples/vfio-mdev/mdpy.c index 96e7969c473a..cc86bf6566e4 100644 --- a/samples/vfio-mdev/mdpy.c +++ b/samples/vfio-mdev/mdpy.c @@ -752,13 +752,13 @@ static int __init mdpy_dev_init(void) { int ret = 0; - ret = alloc_chrdev_region(&mdpy_devt, 0, MINORMASK, MDPY_NAME); + ret = alloc_chrdev_region(&mdpy_devt, 0, MINORMASK + 1, MDPY_NAME); if (ret < 0) { pr_err("Error: failed to register mdpy_dev, err: %d\n", ret); return ret; } cdev_init(&mdpy_cdev, &vd_fops); - cdev_add(&mdpy_cdev, mdpy_devt, MINORMASK); + cdev_add(&mdpy_cdev, mdpy_devt, MINORMASK + 1); pr_info("%s: major %d\n", __func__, MAJOR(mdpy_devt)); mdpy_class = class_create(THIS_MODULE, MDPY_CLASS_NAME); @@ -787,7 +787,7 @@ static int __init mdpy_dev_init(void) class_destroy(mdpy_class); failed1: cdev_del(&mdpy_cdev); - unregister_chrdev_region(mdpy_devt, MINORMASK); + unregister_chrdev_region(mdpy_devt, MINORMASK + 1); return ret; } @@ -798,7 +798,7 @@ static void __exit mdpy_dev_exit(void) device_unregister(&mdpy_dev); cdev_del(&mdpy_cdev); - unregister_chrdev_region(mdpy_devt, MINORMASK); + unregister_chrdev_region(mdpy_devt, MINORMASK + 1); class_destroy(mdpy_class); mdpy_class = NULL; }