From patchwork Tue Feb 12 05:59:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengguang Xu X-Patchwork-Id: 10807383 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 85B1E13B4 for ; Tue, 12 Feb 2019 06:00:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74B782AF01 for ; Tue, 12 Feb 2019 06:00:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 692E82AF10; Tue, 12 Feb 2019 06:00:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1791D2AF01 for ; Tue, 12 Feb 2019 06:00:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbfBLGA4 (ORCPT ); Tue, 12 Feb 2019 01:00:56 -0500 Received: from mout.gmx.net ([212.227.15.19]:54773 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727045AbfBLGA4 (ORCPT ); Tue, 12 Feb 2019 01:00:56 -0500 Received: from localhost.localdomain ([218.18.229.179]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0LuxG5-1h2XrN313x-0105bZ; Tue, 12 Feb 2019 07:00:49 +0100 From: Chengguang Xu To: alex.williamson@redhat.com, kwankhede@nvidia.com Cc: kvm@vger.kernel.org, Chengguang Xu Subject: [PATCH 4/4] samples/vfio-mdev/mtty: expand minor range when registering chrdev region Date: Tue, 12 Feb 2019 13:59:32 +0800 Message-Id: <20190212055932.8825-4-cgxu519@gmx.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190212055932.8825-1-cgxu519@gmx.com> References: <20190212055932.8825-1-cgxu519@gmx.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:VBfOd3Lm60yGOT0PoFcjHdhuH82y7qxxdNxzl3hYlugkwCUkDmk eZQ0haajQGnhqRJvJNxxRSfjqCXN/zoZ1g4zvVe9BqSqE3fPKosB766rr4BpF43CvRC9QOW zdSYg/lai9GS0NeNHm0yVXh1U5ElVNuBjk45N/x3hy4LfinneCNZUCSwS+se9Eh7tCEnMB1 NmetQaM4vnkimcsVK5uYg== X-UI-Out-Filterresults: notjunk:1;V03:K0:/LZPKw/zugo=:AnJhRJ4WVgkljEvHwxoi3C LCYWEcThJX5TKJobul2dR6GZb2ffyMxdIXL9lgSjeUhjo1uW/FN2zlXCPyDOQCNb4Eu7Xrj5E 7h/Zs7r4oWLz8x8ULj9slCCRMfwFG0gDydLfoG8BmkX6o7NsE51e7bQHeIpZMAbUZZmNQgaXO ngyrDiyT0Wb3vjVhICGavt7wNlxkpikBbC5443LGVaV27r3mUKtGb2HVNpusVqlpGIs6woZtV GdRDX4GSJ1prmPrg29WZoQWUTQbKBmeA9Qgp0l6cg+bTYzUwia081ffzkFzIup4RJxHbI5E4e HjF5M6ZYU3JP5UFRcgcX4FKMD0snNakPCNcIcXThXLzX5R7D9rp2P0odPG3TC6AyUaslbkfMe de3gUJwqwyNhWGJKsQ/do2A38OB1Wcy5LOCVA3RPV/rv6yDiXYIFsbFWvBMNRpQfICnxIWmch 5gk/i8G9fGsaTUktiqotdwZokJNv8Z6tuseNTeGCEkuYlHMkFnFq54reC6wMQZKUl/MRLKPpR zz0CJpPuvfxeBBx3eo7ZnPdz/0mS85PPmAKTcZ2evcgl4Qbq7FhIhIW8mnepMRSfepaekeiMl IY/0bkTX2BaeckSpj4VOP4u0Lkw46U2+24ZIT5aDtmTNWkp6X5bItQ4VjdwjqAq73WvP3H570 EkNR6lF70S0Kchsb3oGbXHEgmdxcarS7BaUEWdGUl6Vt5nTn0Px8yUvxeANG2qqE7t3jMJ92Z iswPEtRqU4I780X8hTRGeLYotRzPdr/AB7RLEceQpxA9ejZsGixN+vvCoOSnrJmpJ5Bwy0pCC 6gZb4G5UnSYJTfhiRZh38VXAOAufzGs5WorwL0Mor2X/mxPlnV34V+CJJsuVJKKYFxPSJ6ldB QcFt+bAcv4xRqr/GiABCpF3AEsFew5i4T6Cj3JJd6NoaNr4PhNQQPTUbRCr2KI Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Actually, total amount of available minor number for a single major is MINORMARK + 1. So expand minor range when registering chrdev region. Signed-off-by: Chengguang Xu --- samples/vfio-mdev/mtty.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c index f6732aa16bb1..b9203a4fae12 100644 --- a/samples/vfio-mdev/mtty.c +++ b/samples/vfio-mdev/mtty.c @@ -1442,7 +1442,8 @@ static int __init mtty_dev_init(void) idr_init(&mtty_dev.vd_idr); - ret = alloc_chrdev_region(&mtty_dev.vd_devt, 0, MINORMASK, MTTY_NAME); + ret = alloc_chrdev_region(&mtty_dev.vd_devt, 0, MINORMASK + 1, + MTTY_NAME); if (ret < 0) { pr_err("Error: failed to register mtty_dev, err:%d\n", ret); @@ -1450,7 +1451,7 @@ static int __init mtty_dev_init(void) } cdev_init(&mtty_dev.vd_cdev, &vd_fops); - cdev_add(&mtty_dev.vd_cdev, mtty_dev.vd_devt, MINORMASK); + cdev_add(&mtty_dev.vd_cdev, mtty_dev.vd_devt, MINORMASK + 1); pr_info("major_number:%d\n", MAJOR(mtty_dev.vd_devt)); @@ -1487,7 +1488,7 @@ static int __init mtty_dev_init(void) failed1: cdev_del(&mtty_dev.vd_cdev); - unregister_chrdev_region(mtty_dev.vd_devt, MINORMASK); + unregister_chrdev_region(mtty_dev.vd_devt, MINORMASK + 1); all_done: return ret; @@ -1501,7 +1502,7 @@ static void __exit mtty_dev_exit(void) device_unregister(&mtty_dev.dev); idr_destroy(&mtty_dev.vd_idr); cdev_del(&mtty_dev.vd_cdev); - unregister_chrdev_region(mtty_dev.vd_devt, MINORMASK); + unregister_chrdev_region(mtty_dev.vd_devt, MINORMASK + 1); class_destroy(mtty_dev.vd_class); mtty_dev.vd_class = NULL; pr_info("mtty_dev: Unloaded!\n");