diff mbox series

[5/5] kernel-shark: Rename the method for deselecting the Active marker.

Message ID 20190212170402.10104-6-ykaradzhov@vmware.com (mailing list archive)
State Accepted
Commit ed60f0b6f6d40d674b3b868dfc006328ab95e985
Headers show
Series The right click of the button deselects the marker | expand

Commit Message

Yordan Karadzhov Feb. 12, 2019, 5:04 p.m. UTC 
This method deselects the Active marker regardless of its state (A or B).
The method is renamed in order to avoid confusion with the methods for
deselecting markers A and B.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=202327
Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
---
 kernel-shark/src/KsMainWindow.cpp | 8 ++++----
 kernel-shark/src/KsMainWindow.hpp | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
index 443b7b0..362b955 100644
--- a/kernel-shark/src/KsMainWindow.cpp
+++ b/kernel-shark/src/KsMainWindow.cpp
@@ -101,10 +101,10 @@  KsMainWindow::KsMainWindow(QWidget *parent)
 		&_view,		&KsTraceViewer::showRow);
 
 	connect(&_graph,	&KsTraceGraph::deselect,
-		this,		&KsMainWindow::_deselect);
+		this,		&KsMainWindow::_deselectActive);
 
 	connect(&_view,		&KsTraceViewer::deselect,
-		this,		&KsMainWindow::_deselect);
+		this,		&KsMainWindow::_deselectActive);
 
 	connect(&_data,		&KsDataStore::updateWidgets,
 		&_view,		&KsTraceViewer::update);
@@ -117,7 +117,7 @@  KsMainWindow::KsMainWindow(QWidget *parent)
 
 	_deselectShortcut.setKey(Qt::CTRL + Qt::Key_D);
 	connect(&_deselectShortcut,	&QShortcut::activated,
-		this,			&KsMainWindow::_deselect);
+		this,			&KsMainWindow::_deselectActive);
 
 	connect(&_mState,	&KsDualMarkerSM::deselectA,
 		this,		&KsMainWindow::_deselectA);
@@ -1136,7 +1136,7 @@  void KsMainWindow::_splitterMoved(int pos, int index)
 	_session.saveSplitterSize(_splitter);
 }
 
-void KsMainWindow::_deselect()
+void KsMainWindow::_deselectActive()
 {
 	_view.clearSelection();
 	_mState.activeMarker().remove();
diff --git a/kernel-shark/src/KsMainWindow.hpp b/kernel-shark/src/KsMainWindow.hpp
index abfe196..969b603 100644
--- a/kernel-shark/src/KsMainWindow.hpp
+++ b/kernel-shark/src/KsMainWindow.hpp
@@ -216,7 +216,7 @@  private:
 	void _error(const QString &text, const QString &errCode,
 		    bool resize, bool unloadPlugins);
 
-	void _deselect();
+	void _deselectActive();
 
 	void _deselectA();