[net] selftests: fix timestamping Makefile
diff mbox series

Message ID 20190213170914.11991-1-deepa.kernel@gmail.com
State Mainlined
Commit 39c133196237335e8ee9e3694ef7921241cf6a41
Headers show
Series
  • [net] selftests: fix timestamping Makefile
Related show

Commit Message

Deepa Dinamani Feb. 13, 2019, 5:09 p.m. UTC
The clean target in the makefile conflicts with the generic
kselftests lib.mk, and fails to properly remove the compiled
test programs.

Remove the redundant rule, the TEST_GEN_FILES will be already
removed by the CLEAN macro in lib.mk.

Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
---

* Changes since v1: as per review comments

 tools/testing/selftests/networking/timestamping/Makefile | 3 ---
 1 file changed, 3 deletions(-)

Comments

shuah Feb. 13, 2019, 6:17 p.m. UTC | #1
On 2/13/19 10:09 AM, Deepa Dinamani wrote:
> The clean target in the makefile conflicts with the generic
> kselftests lib.mk, and fails to properly remove the compiled
> test programs.
> 
> Remove the redundant rule, the TEST_GEN_FILES will be already
> removed by the CLEAN macro in lib.mk.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> ---
> 
> * Changes since v1: as per review comments
> 
>   tools/testing/selftests/networking/timestamping/Makefile | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
> index 9050eeea5f5f..1de8bd8ccf5d 100644
> --- a/tools/testing/selftests/networking/timestamping/Makefile
> +++ b/tools/testing/selftests/networking/timestamping/Makefile
> @@ -9,6 +9,3 @@ all: $(TEST_PROGS)
>   top_srcdir = ../../../../..
>   KSFT_KHDR_INSTALL := 1
>   include ../../lib.mk
> -
> -clean:
> -	rm -fr $(TEST_GEN_FILES)
> 

Thanks for the patch.

Acked-by: Shuah Khan <shuah@kernel.org>

thanks,
-- Shuah
David Miller Feb. 14, 2019, 5:03 p.m. UTC | #2
From: Deepa Dinamani <deepa.kernel@gmail.com>
Date: Wed, 13 Feb 2019 09:09:13 -0800

> The clean target in the makefile conflicts with the generic
> kselftests lib.mk, and fails to properly remove the compiled
> test programs.
> 
> Remove the redundant rule, the TEST_GEN_FILES will be already
> removed by the CLEAN macro in lib.mk.
> 
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>

Applied, thank you.

Patch
diff mbox series

diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile
index 9050eeea5f5f..1de8bd8ccf5d 100644
--- a/tools/testing/selftests/networking/timestamping/Makefile
+++ b/tools/testing/selftests/networking/timestamping/Makefile
@@ -9,6 +9,3 @@  all: $(TEST_PROGS)
 top_srcdir = ../../../../..
 KSFT_KHDR_INSTALL := 1
 include ../../lib.mk
-
-clean:
-	rm -fr $(TEST_GEN_FILES)