| Message ID | 20190214015152.124072-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 59e54d9aabc411e7d8628622526f38fad4a19b28 |
| Headers | show |
| Series | [-next] scsi: lpfc: Remove set but not used variable 'phys_id' | expand |
On 2/13/2019 5:51 PM, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpu_affinity_check': > drivers/scsi/lpfc/lpfc_init.c:10599:19: warning: > variable 'phys_id' set but not used [-Wunused-but-set-variable] > > It never used since introduction in commit 6a828b0f6192 ("scsi: lpfc: Support > non-uniform allocation of MSIX vectors to hardware queues") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/scsi/lpfc/lpfc_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > Looks fine. Thanks Signed-off-by: James Smart <james.smart@broadcom.com> -- james
On Thu, 2019-02-14 at 10:52 -0800, James Smart wrote: > > On 2/13/2019 5:51 PM, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/scsi/lpfc/lpfc_init.c: In function > > 'lpfc_cpu_affinity_check': > > drivers/scsi/lpfc/lpfc_init.c:10599:19: warning: > > variable 'phys_id' set but not used [-Wunused-but-set-variable] > > > > It never used since introduction in commit 6a828b0f6192 ("scsi: > > lpfc: Support > > non-uniform allocation of MSIX vectors to hardware queues") > > > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > --- > > drivers/scsi/lpfc/lpfc_init.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > Looks fine. Thanks > > Signed-off-by: James Smart <james.smart@broadcom.com> Under the DCO this can't be a Signed-off-by tag: signoffs track the patch transmission path under the DCO, so unless you send it you can't add your signoff. If you just want Martin to apply it now, and you don't want to gather and resend it with your other lpfc patches, I think the tag you want is Acked-by. James
James, > If you just want Martin to apply it now, and you don't want to gather > and resend it with your other lpfc patches, I think the tag you want > is Acked-by. I usually fix these up when I commit so no need to resend. But please make sure to use the right tag.
On 2/14/2019 11:39 AM, James Bottomley wrote: > On Thu, 2019-02-14 at 10:52 -0800, James Smart wrote: >> On 2/13/2019 5:51 PM, YueHaibing wrote: >>> Fixes gcc '-Wunused-but-set-variable' warning: >>> >>> drivers/scsi/lpfc/lpfc_init.c: In function >>> 'lpfc_cpu_affinity_check': >>> drivers/scsi/lpfc/lpfc_init.c:10599:19: warning: >>> variable 'phys_id' set but not used [-Wunused-but-set-variable] >>> >>> It never used since introduction in commit 6a828b0f6192 ("scsi: >>> lpfc: Support >>> non-uniform allocation of MSIX vectors to hardware queues") >>> >>> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >>> --- >>> drivers/scsi/lpfc/lpfc_init.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> >> Looks fine. Thanks >> >> Signed-off-by: James Smart <james.smart@broadcom.com> > Under the DCO this can't be a Signed-off-by tag: signoffs track the > patch transmission path under the DCO, so unless you send it you can't > add your signoff. > > If you just want Martin to apply it now, and you don't want to gather > and resend it with your other lpfc patches, I think the tag you want is > Acked-by. > > James I've been told multiple answers on which way to reply over the years. My initial position followed your statement, but a later rebuke (would have to look hard to find it) told me as maintainer that I should be doing something different. I'll go back to the DCO definitions and follow those. Thanks for cleaning it up Martin. -- james
On Thu, 2019-02-14 at 13:19 -0800, James Smart wrote: > > On 2/14/2019 11:39 AM, James Bottomley wrote: > > On Thu, 2019-02-14 at 10:52 -0800, James Smart wrote: > > > On 2/13/2019 5:51 PM, YueHaibing wrote: > > > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > > > > > drivers/scsi/lpfc/lpfc_init.c: In function > > > > 'lpfc_cpu_affinity_check': > > > > drivers/scsi/lpfc/lpfc_init.c:10599:19: warning: > > > > variable 'phys_id' set but not used [-Wunused-but-set- > > > > variable] > > > > > > > > It never used since introduction in commit 6a828b0f6192 ("scsi: > > > > lpfc: Support > > > > non-uniform allocation of MSIX vectors to hardware queues") > > > > > > > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > > > --- > > > > drivers/scsi/lpfc/lpfc_init.c | 3 +-- > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > > > > > > > Looks fine. Thanks > > > > > > Signed-off-by: James Smart <james.smart@broadcom.com> > > > > Under the DCO this can't be a Signed-off-by tag: signoffs track the > > patch transmission path under the DCO, so unless you send it you > > can't > > add your signoff. > > > > If you just want Martin to apply it now, and you don't want to > > gather and resend it with your other lpfc patches, I think the tag > > you want is Acked-by. > > > > James > > I've been told multiple answers on which way to reply over the years. > My initial position followed your statement, but a later rebuke > (would have to look hard to find it) If you could, that would help me find and correct the source ... > told me as maintainer that I should be doing something different. > I'll go back to the DCO definitions and follow > those. Great, thanks. Our only tag with formal requirements from the DCO is Signed-off-by: everything else is undefined by the DCO (and thus more prone to being argued over and having more per-subsystem meanings that lead to irreconcilable differences between subsystem use). James > Thanks for cleaning it up Martin. > > -- james >
Signed-off-by is like a legal document to say that you haven't added any proprietary SCO UNIXWARE code to the patch. You have sign every patch if you email it. Acked-by and Reviewed-by are less clear. Acked-by means you want it to be merged, I guess? I never use Acked by because I'm not a maintainer so it's not my place to approve things. regards, dan carpenter
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 900edae7ccc4..1ec1ec0d11de 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -10596,7 +10596,7 @@ lpfc_find_hyper(struct lpfc_hba *phba, int cpu, static void lpfc_cpu_affinity_check(struct lpfc_hba *phba, int vectors) { - int i, cpu, idx, phys_id; + int i, cpu, idx; int max_phys_id, min_phys_id; int max_core_id, min_core_id; struct lpfc_vector_map_info *cpup; @@ -10614,7 +10614,6 @@ lpfc_cpu_affinity_check(struct lpfc_hba *phba, int vectors) min_phys_id = 0xffff; max_core_id = 0; min_core_id = 0xffff; - phys_id = 0; /* Update CPU map with physical id and core id of each CPU */ for_each_present_cpu(cpu) {
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpu_affinity_check': drivers/scsi/lpfc/lpfc_init.c:10599:19: warning: variable 'phys_id' set but not used [-Wunused-but-set-variable] It never used since introduction in commit 6a828b0f6192 ("scsi: lpfc: Support non-uniform allocation of MSIX vectors to hardware queues") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/scsi/lpfc/lpfc_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)