diff mbox series

[v2,1/2] pNFS: Fix potential corruption of page being written

Message ID 480b4d46-e290-b612-7b8e-09eb3a488ee6@lab.ntt.co.jp (mailing list archive)
State New, archived
Headers show
Series pNFS block/SCSI layouts read-modify-write fix&improvement | expand

Commit Message

Kazuo Ito Feb. 14, 2019, 9:36 a.m. UTC 
nfs_want_read_modify_write() didn't check for !PagePrivate when pNFS
block or SCSI layout was in use, therefore we could lose data forever
if the page being written was filled by a read before completion.

Signed-off-by: Kazuo Ito <ito_kazuo_g3@lab.ntt.co.jp>
---
 fs/nfs/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 29553fdba8af..d8f25b1ae233 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -299,7 +299,7 @@  static int nfs_want_read_modify_write(struct file *file, struct page *page,
 	unsigned int end = offset + len;
 
 	if (pnfs_ld_read_whole_page(file->f_mapping->host)) {
-		if (!PageUptodate(page))
+		if (!PageUptodate(page) && !PagePrivate(page))
 			return 1;
 		return 0;
 	}