| Message ID | 1550159977-8949-5-git-send-email-rppt@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | provide a generic free_initmem implementation | expand |
On Thu, 14 Feb 2019 07:59:37 PST (-0800), rppt@linux.ibm.com wrote: > The riscv version of free_initmem() differs from the generic one only in > that it sets the freed memory to zero. > > Make ricsv use the generic version and poison the freed memory. > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> > --- > arch/riscv/mm/init.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > index 658ebf6..2af0010 100644 > --- a/arch/riscv/mm/init.c > +++ b/arch/riscv/mm/init.c > @@ -60,11 +60,6 @@ void __init mem_init(void) > mem_init_print_info(NULL); > } > > -void free_initmem(void) > -{ > - free_initmem_default(0); > -} > - > #ifdef CONFIG_BLK_DEV_INITRD > void free_initrd_mem(unsigned long start, unsigned long end) > { Reviewed-by: Palmer Dabbelt <palmer@sifive.com> I'm going to assume this goes in with the rest of the patch set, thanks!
Hi Mike, On Fri, Feb 15, 2019 at 2:19 AM Palmer Dabbelt <palmer@sifive.com> wrote: > > On Thu, 14 Feb 2019 07:59:37 PST (-0800), rppt@linux.ibm.com wrote: > > The riscv version of free_initmem() differs from the generic one only in > > that it sets the freed memory to zero. > > > > Make ricsv use the generic version and poison the freed memory. > > > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> Just for clarity, does same change applicable in below places - arch/openrisc/mm/init.c#L231 arch/alpha/mm/init.c#L290 arch/arc/mm/init.c#L213 arch/m68k/mm/init.c#L109 arch/nds32/mm/init.c#L247 arch/nios2/mm/init.c#L92 arch/openrisc/mm/init.c#L231 > > --- > > arch/riscv/mm/init.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > index 658ebf6..2af0010 100644 > > --- a/arch/riscv/mm/init.c > > +++ b/arch/riscv/mm/init.c > > @@ -60,11 +60,6 @@ void __init mem_init(void) > > mem_init_print_info(NULL); > > } > > > > -void free_initmem(void) > > -{ > > - free_initmem_default(0); > > -} > > - > > #ifdef CONFIG_BLK_DEV_INITRD > > void free_initrd_mem(unsigned long start, unsigned long end) > > { > > Reviewed-by: Palmer Dabbelt <palmer@sifive.com> > > I'm going to assume this goes in with the rest of the patch set, thanks! >
On Mon, Feb 18, 2019 at 6:16 PM Souptick Joarder <jrdr.linux@gmail.com> wrote: > > Hi Mike, > > On Fri, Feb 15, 2019 at 2:19 AM Palmer Dabbelt <palmer@sifive.com> wrote: > > > > On Thu, 14 Feb 2019 07:59:37 PST (-0800), rppt@linux.ibm.com wrote: > > > The riscv version of free_initmem() differs from the generic one only in > > > that it sets the freed memory to zero. > > > > > > Make ricsv use the generic version and poison the freed memory. > > > > > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> > > Just for clarity, does same change applicable in below places - > > arch/openrisc/mm/init.c#L231 > arch/alpha/mm/init.c#L290 > arch/arc/mm/init.c#L213 > arch/m68k/mm/init.c#L109 > arch/nds32/mm/init.c#L247 > arch/nios2/mm/init.c#L92 > arch/openrisc/mm/init.c#L231 Please ignore this query. just saw the other patches. Sorry for the noise. > > > > > --- > > > arch/riscv/mm/init.c | 5 ----- > > > 1 file changed, 5 deletions(-) > > > > > > diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c > > > index 658ebf6..2af0010 100644 > > > --- a/arch/riscv/mm/init.c > > > +++ b/arch/riscv/mm/init.c > > > @@ -60,11 +60,6 @@ void __init mem_init(void) > > > mem_init_print_info(NULL); > > > } > > > > > > -void free_initmem(void) > > > -{ > > > - free_initmem_default(0); > > > -} > > > - > > > #ifdef CONFIG_BLK_DEV_INITRD > > > void free_initrd_mem(unsigned long start, unsigned long end) > > > { > > > > Reviewed-by: Palmer Dabbelt <palmer@sifive.com> > > > > I'm going to assume this goes in with the rest of the patch set, thanks! > >
diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c index 658ebf6..2af0010 100644 --- a/arch/riscv/mm/init.c +++ b/arch/riscv/mm/init.c @@ -60,11 +60,6 @@ void __init mem_init(void) mem_init_print_info(NULL); } -void free_initmem(void) -{ - free_initmem_default(0); -} - #ifdef CONFIG_BLK_DEV_INITRD void free_initrd_mem(unsigned long start, unsigned long end) {
The riscv version of free_initmem() differs from the generic one only in that it sets the freed memory to zero. Make ricsv use the generic version and poison the freed memory. Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> --- arch/riscv/mm/init.c | 5 ----- 1 file changed, 5 deletions(-)