diff mbox series

[ndctl,2/2] autoconf: print more possible package names for keyutils.h

Message ID 20190214163422.15221-2-elliott@hpe.com (mailing list archive)
State New, archived
Headers show
Series [ndctl,1/2] autoconf: Check for MAP_SHARED_VALIDATE | expand

Commit Message

Elliott, Robert (Servers) Feb. 14, 2019, 4:34 p.m. UTC
The distro package names providing keyutils.h are inconsistent, so
print more than just one suggestion:
    keyutils-libs-devel (Red Hat)
    keyutils-devel (SUSE)
    libkeyutils-dev (Ubuntu)

Fixes: 86b078b44275 ("ndctl: add passphrase management commands")
Signed-off-by: Robert Elliott <elliott@hpe.com>
---
 configure.ac | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Dan Williams Feb. 14, 2019, 5:55 p.m. UTC | #1
On Thu, Feb 14, 2019 at 8:29 AM Robert Elliott <elliott@hpe.com> wrote:
>
> The distro package names providing keyutils.h are inconsistent, so
> print more than just one suggestion:
>     keyutils-libs-devel (Red Hat)
>     keyutils-devel (SUSE)
>     libkeyutils-dev (Ubuntu)
>
> Fixes: 86b078b44275 ("ndctl: add passphrase management commands")
> Signed-off-by: Robert Elliott <elliott@hpe.com>

Looks good to me.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index efbdcde..6c26934 100644
--- a/configure.ac
+++ b/configure.ac
@@ -171,8 +171,7 @@  AC_ARG_WITH([keyutils],
 
 if test "x$with_keyutils" = "xyes"; then
 	AC_CHECK_HEADERS([keyutils.h],,[
-		AC_MSG_ERROR([keyutils.h not found, consider installing
-			      keyutils-libs-devel.])
+		AC_MSG_ERROR([keyutils.h not found, consider installing the keyutils library development package (variously named keyutils-libs-devel, keyutils-devel, or libkeyutils-dev).])
 		])
 fi
 AS_IF([test "x$with_keyutils" = "xyes"],