soc: qcom: rpmhpd: Set 'active_only' for active only power domains
diff mbox series

Message ID 20190214173633.211000-1-dianders@chromium.org
State New, archived
Headers show
Series
  • soc: qcom: rpmhpd: Set 'active_only' for active only power domains
Related show

Commit Message

Doug Anderson Feb. 14, 2019, 5:36 p.m. UTC
The 'active_only' attribute was accidentally never set to true for any
power domains meaning that all the code handling this attribute was
dead.

NOTE that the RPM power domain code (as opposed to the RPMh one) gets
this right.

Fixes: 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/soc/qcom/rpmhpd.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stephen Boyd Feb. 14, 2019, 6:23 p.m. UTC | #1
Quoting Douglas Anderson (2019-02-14 09:36:33)
> The 'active_only' attribute was accidentally never set to true for any
> power domains meaning that all the code handling this attribute was
> dead.
> 
> NOTE that the RPM power domain code (as opposed to the RPMh one) gets
> this right.
> 
> Fixes: 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Rajendra Nayak Feb. 15, 2019, 2:32 a.m. UTC | #2
On 2/14/2019 11:06 PM, Douglas Anderson wrote:
> The 'active_only' attribute was accidentally never set to true for any
> power domains meaning that all the code handling this attribute was
> dead.
> 
> NOTE that the RPM power domain code (as opposed to the RPMh one) gets
> this right.
> 
> Fixes: 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Thanks for catching this. I seem to have introduced this bug when I moved
away from using the macros to define these static structs and failed to add
the property :/

Acked-by: Rajendra Nayak <rnayak@codeaurora.org>

> ---
> 
>   drivers/soc/qcom/rpmhpd.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> index 5741ec3fa814..51850cc68b70 100644
> --- a/drivers/soc/qcom/rpmhpd.c
> +++ b/drivers/soc/qcom/rpmhpd.c
> @@ -93,6 +93,7 @@ static struct rpmhpd sdm845_mx = {
>   
>   static struct rpmhpd sdm845_mx_ao = {
>   	.pd = { .name = "mx_ao", },
> +	.active_only = true,
>   	.peer = &sdm845_mx,
>   	.res_name = "mx.lvl",
>   };
> @@ -107,6 +108,7 @@ static struct rpmhpd sdm845_cx = {
>   
>   static struct rpmhpd sdm845_cx_ao = {
>   	.pd = { .name = "cx_ao", },
> +	.active_only = true,
>   	.peer = &sdm845_cx,
>   	.parent = &sdm845_mx_ao.pd,
>   	.res_name = "cx.lvl",
>
Doug Anderson Nov. 18, 2019, 4:19 p.m. UTC | #3
Bjorn / Andy,

On Thu, Feb 14, 2019 at 9:36 AM Douglas Anderson <dianders@chromium.org> wrote:
>
> The 'active_only' attribute was accidentally never set to true for any
> power domains meaning that all the code handling this attribute was
> dead.
>
> NOTE that the RPM power domain code (as opposed to the RPMh one) gets
> this right.
>
> Fixes: 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
>  drivers/soc/qcom/rpmhpd.c | 2 ++
>  1 file changed, 2 insertions(+)

Somehow this fell through the cracks and was never applied.  Can you
pick it up?  Given that it's been a year and nobody has noticed this
it seems like 5.5 is fine, but maybe you could add Cc: stable since it
seems like something that stable trees would want...

Thanks!

-Doug
Bjorn Andersson Nov. 20, 2019, 1:36 a.m. UTC | #4
On Mon 18 Nov 08:19 PST 2019, Doug Anderson wrote:

> Bjorn / Andy,
> 
> On Thu, Feb 14, 2019 at 9:36 AM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > The 'active_only' attribute was accidentally never set to true for any
> > power domains meaning that all the code handling this attribute was
> > dead.
> >
> > NOTE that the RPM power domain code (as opposed to the RPMh one) gets
> > this right.
> >
> > Fixes: 279b7e8a62cc ("soc: qcom: rpmhpd: Add RPMh power domain driver")
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> >
> >  drivers/soc/qcom/rpmhpd.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Somehow this fell through the cracks and was never applied.  Can you
> pick it up?  Given that it's been a year and nobody has noticed this
> it seems like 5.5 is fine, but maybe you could add Cc: stable since it
> seems like something that stable trees would want...
> 
> Thanks!
> 

Thanks for noticing, I've picked this up.

Regards,
Bjorn

Patch
diff mbox series

diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
index 5741ec3fa814..51850cc68b70 100644
--- a/drivers/soc/qcom/rpmhpd.c
+++ b/drivers/soc/qcom/rpmhpd.c
@@ -93,6 +93,7 @@  static struct rpmhpd sdm845_mx = {
 
 static struct rpmhpd sdm845_mx_ao = {
 	.pd = { .name = "mx_ao", },
+	.active_only = true,
 	.peer = &sdm845_mx,
 	.res_name = "mx.lvl",
 };
@@ -107,6 +108,7 @@  static struct rpmhpd sdm845_cx = {
 
 static struct rpmhpd sdm845_cx_ao = {
 	.pd = { .name = "cx_ao", },
+	.active_only = true,
 	.peer = &sdm845_cx,
 	.parent = &sdm845_mx_ao.pd,
 	.res_name = "cx.lvl",