From patchwork Thu Feb 14 21:08:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robin Meijboom X-Patchwork-Id: 10813797 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 326FB922 for ; Thu, 14 Feb 2019 21:20:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1ECFF2EC30 for ; Thu, 14 Feb 2019 21:20:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 132162ED45; Thu, 14 Feb 2019 21:20:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB65D2EC30 for ; Thu, 14 Feb 2019 21:20:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392750AbfBNVUv (ORCPT ); Thu, 14 Feb 2019 16:20:51 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.23]:36748 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387702AbfBNVUv (ORCPT ); Thu, 14 Feb 2019 16:20:51 -0500 X-Greylist: delayed 360 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Feb 2019 16:20:50 EST DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1550179249; s=strato-dkim-0002; d=meijboom.info; h=Date:Message-ID:Subject:From:Cc:To:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=iJ4iG9VYR3na3oXufsORgTjoIyXeH6pkLTUZUpnt4F8=; b=sHN377W62jZTo5WC9PNMVCCcSEFwAWOdAgEQ2WGweJO9VrPlbW9tuM8wRp2KMCpHBW I+BiPI0iJXX8kV6Sby6JHo8rGU0TARpLCgwsMOiOT1hmtWpmSd39NvH08VOt/2ILbe5o IM96AHdJ1nd0wXrA0JhD/y1AsIyfEvtHWpkKs0Pf5uPClDcYQGX30cmdd283UW8L1FKL o/PF2pNN03+1bRdWK0foNSE7/ev56KXdefPmA2QgbjPoxLeZPHFanp2+/yis/wianO7b OUsvzOFC/Tvq06ZMoZyqo2EIo3xaOQZ4+ZkXuSLLC6bA03OIJ9gQUAXkES3bWCPOEBfN DocA== X-RZG-AUTH: ":PmMGfE6IdvqAHB+m9QW4yaDHYCOxRCzlZ970PdgWeq6yv7GwjeuVf7+ozdQH6SSp//XNO4Y=" X-RZG-CLASS-ID: mo00 Received: from [192.168.8.106] by smtp.strato.com (RZmta 44.9 AUTH) with ESMTPSA id 60306av1EL8dbHQ (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Thu, 14 Feb 2019 22:08:39 +0100 (CET) To: Masahiro Yamada , Michal Marek Cc: linux-kbuild@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra From: Robin Meijboom Subject: [PATCH] objtool: remove generated files with make clean Message-ID: Date: Thu, 14 Feb 2019 22:08:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 Content-Language: en-US Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Make clean currently does not remove the generated files for objtool: tools/objtool/objtool, tools/objtool/fixdep, and tools/objtool/arch/x86/lib/inat-tables.c. Clean these files up as part of make clean. Fixes: b9ab5ebb14ec ("objtool: Add CONFIG_STACK_VALIDATION option") and bug report 199485 (https://bugzilla.kernel.org/show_bug.cgi?id=199485). Signed-off-by: Robin Meijboom --- In the discussions I didn't find a reason for keeping the files, so I assume it is an oversight. Otherwise I would have expected them to be removed at least by make distconfig (which they are not). Tested by compiling, cleaning, compiling again, and booting on x86_64. diff --git a/Makefile b/Makefile index 141653226f3c..81a8149a805f 100644 --- a/Makefile +++ b/Makefile @@ -1328,6 +1328,8 @@ endif # CONFIG_MODULES  # Directories & files removed with 'make clean'  CLEAN_DIRS  += $(MODVERDIR) include/ksym +CLEAN_FILES += tools/objtool/objtool tools/objtool/fixdep \ +           tools/objtool/arch/$(ARCH)/lib/inat-tables.c  # Directories & files removed with 'make mrproper'  MRPROPER_DIRS  += include/config usr/include include/generated          \