ARM: dts: rockchip: add chosen node on veyron chromebooks
diff mbox series

Message ID 20190215115150.32299-1-enric.balletbo@collabora.com
State New
Headers show
Series
  • ARM: dts: rockchip: add chosen node on veyron chromebooks
Related show

Commit Message

Enric Balletbo i Serra Feb. 15, 2019, 11:51 a.m. UTC
In order to use earlycon, the stdout-path property needs to be set
in the chosen node.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---

 arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Heiko Stuebner Feb. 15, 2019, 11:08 p.m. UTC | #1
Hi Enric,

Am Freitag, 15. Februar 2019, 12:51:50 CET schrieb Enric Balletbo i Serra:
> In order to use earlycon, the stdout-path property needs to be set
> in the chosen node.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

What's the reason for adding this only for the Chromebook variants?
Uart2 is pretty much the standard output for all devices, so I'd assume
at least all veyron boards should use uart2 as well, making this ideally
live in the rk3288-veyron.dtsi instead?

Heiko

> ---
> 
>  arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi index
> b54746df3661..8890967ed572 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
> @@ -62,6 +62,10 @@
>  		pwm-off-delay-ms = <10>;
>  	};
> 
> +	chosen {
> +		stdout-path = "serial2:115200n8";
> +	};
> +
>  	gpio-charger {
>  		compatible = "gpio-charger";
>  		charger-type = "mains";
Alexandru M Stan Feb. 16, 2019, 1:13 a.m. UTC | #2
On Fri, Feb 15, 2019 at 3:09 PM Heiko Stübner <heiko@sntech.de> wrote:
>
> Hi Enric,
>
> Am Freitag, 15. Februar 2019, 12:51:50 CET schrieb Enric Balletbo i Serra:
> > In order to use earlycon, the stdout-path property needs to be set
> > in the chosen node.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
> What's the reason for adding this only for the Chromebook variants?
> Uart2 is pretty much the standard output for all devices, so I'd assume
> at least all veyron boards should use uart2 as well, making this ideally
> live in the rk3288-veyron.dtsi instead?

Yep, all veyriants use uart 2, even when they're not chromebooks.
Feel free to put it in the other file instead.

Otherwise it'll make things like the Asus Chromebit (mickey), AOpen
Chromebox mini (fievel), and AOpen Chromebase (tiger) unhappy
while debugging.

The rk3288-veyron-chromebook.dtsi file is more for things that make
a chromebook portable. Ex: built in display, lid switch, cros-ec.

Note how we have no uart2 references either in our tree in the
chromebook specific dtsi:
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi

Alexandru Stan (amstan)
Heiko Stuebner Feb. 16, 2019, 8:28 p.m. UTC | #3
Am Samstag, 16. Februar 2019, 02:13:25 CET schrieb Alexandru M Stan:
> On Fri, Feb 15, 2019 at 3:09 PM Heiko Stübner <heiko@sntech.de> wrote:
> >
> > Hi Enric,
> >
> > Am Freitag, 15. Februar 2019, 12:51:50 CET schrieb Enric Balletbo i Serra:
> > > In order to use earlycon, the stdout-path property needs to be set
> > > in the chosen node.
> > >
> > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >
> > What's the reason for adding this only for the Chromebook variants?
> > Uart2 is pretty much the standard output for all devices, so I'd assume
> > at least all veyron boards should use uart2 as well, making this ideally
> > live in the rk3288-veyron.dtsi instead?
> 
> Yep, all veyriants use uart 2, even when they're not chromebooks.
> Feel free to put it in the other file instead.
> 
> Otherwise it'll make things like the Asus Chromebit (mickey), AOpen
> Chromebox mini (fievel), and AOpen Chromebase (tiger) unhappy
> while debugging.
> 
> The rk3288-veyron-chromebook.dtsi file is more for things that make
> a chromebook portable. Ex: built in display, lid switch, cros-ec.
> 
> Note how we have no uart2 references either in our tree in the
> chromebook specific dtsi:
> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi

thanks for the confirmation :-) .

I've moved the choosen node over to veyron.dtsi and applied the result
for 5.1

Thanks
Heiko
Enric Balletbo Serra Feb. 17, 2019, 8:38 p.m. UTC | #4
Hi,
Missatge de Heiko Stuebner <heiko@sntech.de> del dia ds., 16 de febr.
2019 a les 21:28:
>
> Am Samstag, 16. Februar 2019, 02:13:25 CET schrieb Alexandru M Stan:
> > On Fri, Feb 15, 2019 at 3:09 PM Heiko Stübner <heiko@sntech.de> wrote:
> > >
> > > Hi Enric,
> > >
> > > Am Freitag, 15. Februar 2019, 12:51:50 CET schrieb Enric Balletbo i Serra:
> > > > In order to use earlycon, the stdout-path property needs to be set
> > > > in the chosen node.
> > > >
> > > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > >
> > > What's the reason for adding this only for the Chromebook variants?
> > > Uart2 is pretty much the standard output for all devices, so I'd assume
> > > at least all veyron boards should use uart2 as well, making this ideally
> > > live in the rk3288-veyron.dtsi instead?
> >
> > Yep, all veyriants use uart 2, even when they're not chromebooks.
> > Feel free to put it in the other file instead.
> >
> > Otherwise it'll make things like the Asus Chromebit (mickey), AOpen
> > Chromebox mini (fievel), and AOpen Chromebase (tiger) unhappy
> > while debugging.
> >
> > The rk3288-veyron-chromebook.dtsi file is more for things that make
> > a chromebook portable. Ex: built in display, lid switch, cros-ec.
> >
> > Note how we have no uart2 references either in our tree in the
> > chromebook specific dtsi:
> > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-3.14/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
>
> thanks for the confirmation :-) .
>
> I've moved the choosen node over to veyron.dtsi and applied the result
> for 5.1
>

Perfect thanks, I was unsure about the non-chromebooks devices.


> Thanks
> Heiko
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
index b54746df3661..8890967ed572 100644
--- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi
@@ -62,6 +62,10 @@ 
 		pwm-off-delay-ms = <10>;
 	};
 
+	chosen {
+		stdout-path = "serial2:115200n8";
+	};
+
 	gpio-charger {
 		compatible = "gpio-charger";
 		charger-type = "mains";