From patchwork Mon Feb 18 08:29:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shengjiu Wang X-Patchwork-Id: 10817473 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1F7B613A4 for ; Mon, 18 Feb 2019 08:29:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B86A29B90 for ; Mon, 18 Feb 2019 08:29:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F39AC29B9C; Mon, 18 Feb 2019 08:29:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4590929B90 for ; Mon, 18 Feb 2019 08:29:20 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 958EF266B48; Mon, 18 Feb 2019 09:29:18 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0D80B266FA9; Mon, 18 Feb 2019 09:29:16 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80058.outbound.protection.outlook.com [40.107.8.58]) by alsa0.perex.cz (Postfix) with ESMTP id CFE4D266A9D for ; Mon, 18 Feb 2019 09:29:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FyxXtkXP5YCWFH3tIGQswjm55puIOWCCggnrgWoBSTw=; b=ux39ohlmLujFYZNqgFx3EIhyldkqyt+WP6O7KrzBgiHiBZvAyXQoRZd6lbOnbAimoZ65YiE2mxXw9JIE2DJHr6h+oIcLs9HQYPq4s3Myijxo9nzw/w2dgwo5v8eFBy3A7nX75iQt/pU9gDKFyMCCjQJZlGcwtc3vdCPpnGlVIRc= Received: from VI1PR0402MB3392.eurprd04.prod.outlook.com (52.134.1.153) by VI1PR0402MB3775.eurprd04.prod.outlook.com (52.134.15.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.19; Mon, 18 Feb 2019 08:29:11 +0000 Received: from VI1PR0402MB3392.eurprd04.prod.outlook.com ([fe80::407:6e30:6a9d:2a22]) by VI1PR0402MB3392.eurprd04.prod.outlook.com ([fe80::407:6e30:6a9d:2a22%3]) with mapi id 15.20.1622.018; Mon, 18 Feb 2019 08:29:11 +0000 From: "S.j. Wang" To: "timur@kernel.org" , "nicoleotsuka@gmail.com" , "Xiubo.Lee@gmail.com" , "festevam@gmail.com" , "broonie@kernel.org" , "alsa-devel@alsa-project.org" Thread-Topic: [PATCH V3] ASoC: fsl_esai: fix register setting issue in RIGHT_J mode Thread-Index: AQHUx2QG4koWp80wBUKbYM2+f0bVZQ== Date: Mon, 18 Feb 2019 08:29:11 +0000 Message-ID: <40b6cb9135dc5ec23f10d8f036ff7906daf223c2.1550478160.git.shengjiu.wang@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 1.9.1 x-clientproxiedby: HK0PR01CA0062.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::26) To VI1PR0402MB3392.eurprd04.prod.outlook.com (2603:10a6:803:3::25) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0f8dff07-5818-46c0-0fa4-08d6957b2863 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0402MB3775; x-ms-traffictypediagnostic: VI1PR0402MB3775: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; VI1PR0402MB3775; 23:dtTOpSb5s7OqBceAPty3INNnkeCUflmDCbYLx?= =?iso-8859-1?q?NjSGIG6XIo1yycciy?= =?iso-8859-1?q?3QMfiHmj4zKxMTyNIfDZD3cQGUGLbLQoBtw6DobJWP+K7f6vhoIOHfE2TtNq?= =?iso-8859-1?q?iL1qE0xGI+3re+9/trOYnfDeMy8u7eA9tWidKV86GRQQ0A4F9s2olqBmrb9z?= =?iso-8859-1?q?tGd8y1apR+veNgs4CTL0tkG7NiradSdzo4ROgN9KT/CGB8EiFjzIbcgmgxWu?= =?iso-8859-1?q?lGk+0ck1peQeb2qz6YXZLEvCZccGEUVFlyCpwxHUlh/JmHS/j6EpgBH/6Lai?= =?iso-8859-1?q?BWEA7/6jrcUTDINxj/xu13+KBf+iCtzgAGfwiKz1rpCUQ5XUouAJ6rhkDDWj?= =?iso-8859-1?q?yBWKvHMZWlPD9yMMhzVfAxm62+6ddU0CzkpHv4v2JLtk29b0KqioYs8E8dt/?= =?iso-8859-1?q?J0n09iL3TeKWmeB29bjnyjblfws9BqUlqZkk6JWBgrw+NiwU7DacXeCM1On6?= =?iso-8859-1?q?EbFR+WbCMKWgeEvl/Kzx9Am2TpoSOkuzsnUQPSa6m7NnF1PZ89T88mifEF3x?= =?iso-8859-1?q?gWw2sfWRCL/6eqv7m4ucvTPzcEAkbMiSyqwJbhkKDcTMhcOeFhLU5bZ5pGYU?= =?iso-8859-1?q?FhVTW924ikSLqs8j/kpGc7qq/I/DStUJ5Vxou2XDSAXUteAA/Z6qa7DSTGbc?= =?iso-8859-1?q?nC+UvkAZ74BjhQBiCGJxfM04tkizQqfNiz898YiyN5Ezz0OJYgl6d/BjeNhe?= =?iso-8859-1?q?ZweRMymBlSiflY1M+6eR+xDdViTNuYo6s3Z5kpebuOYa3IlMQ6/WYIHLeetG?= =?iso-8859-1?q?PXc3Z3a2NCJ12O/ta65xvc4o2y8sodv2Sy3VUaW/sxTIRxMMeAiLcsr/qgGh?= =?iso-8859-1?q?lJ/asMErlrimkBSwTLnzSCZ8vuWXDaDdUwdkZseDz8Ftmo3Y4m3sBGN7OmJ0?= =?iso-8859-1?q?UAhFK8IGgEGlJlaQ47dgH3LgZ0jpjHwdpTaajA6ylumyjZWWephSXadBrOBx?= =?iso-8859-1?q?pYK6xu3dRe3hPVbu5qqIM/y73sPN9OSusjZpBrwwyIBY4/YFOdH/6AspOVtt?= =?iso-8859-1?q?hgOj2PGAhbNbSqM+8RWPPF5mxsV9NpivgwsK/OnqTH1UZ9atS4T0JkSoYTyj?= =?iso-8859-1?q?hqczFxeAQ+XLZYSslA41jjmkGwlAlMp00Y0T1IvFCM6K2Djqfwk2JhQLXbmt?= =?iso-8859-1?q?CIJVlcCtYfeMzBt23A+ojNpJqAvNrzMTmdx5K/cgCMlTpDCckMJHIbJJ7lm7?= =?iso-8859-1?q?ZsIXZuyq0tXydhhR7y954J?= x-microsoft-antispam-prvs: x-forefront-prvs: 09525C61DB x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(366004)(396003)(39860400002)(199004)(189003)(5660300002)(486006)(2906002)(478600001)(8936002)(25786009)(97736004)(50226002)(110136005)(316002)(6486002)(2501003)(2201001)(86362001)(118296001)(2616005)(476003)(256004)(36756003)(53936002)(6436002)(6512007)(14454004)(26005)(14444005)(7736002)(6346003)(3846002)(186003)(6116002)(386003)(99286004)(102836004)(6506007)(81166006)(52116002)(66066001)(105586002)(81156014)(8676002)(106356001)(4326008)(71190400001)(68736007)(71200400001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB3775; H:VI1PR0402MB3392.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shengjiu.wang@nxp.com; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: A3r6ZqvcucfHyD9DQeM0BagZMNKa8hjOHwt4pBjDiMr2EVkbTodbMFUF1kofH+GbVNGuv98JdQHL3j0JlIkllqIzditTe5xiQodU65iwpgE0euzkZWqLyRPuGUoD5tvYH6q0J/aYUB7lF5nY8FAZQ1UR6rCSZfb1IdbgXukc6xlF/JtyrCe5Y/TghfFTKIQDOudByfcYJmtQu6dxNhjadpIA81c8jJDIDpaYLSSD1Rhh6Cg11Wjy19nxy/fTs6j3JnWBJ/I/OfuieBpY3J0oGQbeorhtdoEXdxuLzyJ7jKzmkR3QRP8LKx+yjkhsSlF1MGstGuFMviIG77RrltDBceZmRHtBbW59j8Fe3lNLcnboV1E1WpwXXdsNKZO04mSz2/YwrC2Q5O58LDtJBG09osIC0+dWPPA/IP4Xyhi5l3Q= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f8dff07-5818-46c0-0fa4-08d6957b2863 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2019 08:29:08.6353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3775 Cc: "linuxppc-dev@lists.ozlabs.org" Subject: [alsa-devel] [PATCH V3] ASoC: fsl_esai: fix register setting issue in RIGHT_J mode X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The ESAI_xCR_xWA is xCR's bit, not the xCCR's bit, driver set it to wrong register, correct it. Fixes 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver") Cc: Signed-off-by: Shengjiu Wang Reviewed-by: Fabio Estevam Ackedy-by: Nicolin Chen --- Changes in v3 - Add Cc: sound/soc/fsl/fsl_esai.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index 57b484768a58..afe67c865330 100644 --- a/sound/soc/fsl/fsl_esai.c +++ b/sound/soc/fsl/fsl_esai.c @@ -398,7 +398,8 @@ static int fsl_esai_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt) break; case SND_SOC_DAIFMT_RIGHT_J: /* Data on rising edge of bclk, frame high, right aligned */ - xccr |= ESAI_xCCR_xCKP | ESAI_xCCR_xHCKP | ESAI_xCR_xWA; + xccr |= ESAI_xCCR_xCKP | ESAI_xCCR_xHCKP; + xcr |= ESAI_xCR_xWA; break; case SND_SOC_DAIFMT_DSP_A: /* Data on rising edge of bclk, frame high, 1clk before data */ @@ -455,12 +456,12 @@ static int fsl_esai_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt) return -EINVAL; } - mask = ESAI_xCR_xFSL | ESAI_xCR_xFSR; + mask = ESAI_xCR_xFSL | ESAI_xCR_xFSR | ESAI_xCR_xWA; regmap_update_bits(esai_priv->regmap, REG_ESAI_TCR, mask, xcr); regmap_update_bits(esai_priv->regmap, REG_ESAI_RCR, mask, xcr); mask = ESAI_xCCR_xCKP | ESAI_xCCR_xHCKP | ESAI_xCCR_xFSP | - ESAI_xCCR_xFSD | ESAI_xCCR_xCKD | ESAI_xCR_xWA; + ESAI_xCCR_xFSD | ESAI_xCCR_xCKD; regmap_update_bits(esai_priv->regmap, REG_ESAI_TCCR, mask, xccr); regmap_update_bits(esai_priv->regmap, REG_ESAI_RCCR, mask, xccr);