[2/2] arm64: dts: rockchip: fix cts, rts pin assign of UART3 for rk3399
diff mbox series

Message ID 20190219140800.12624-2-katsuhiro@katsuster.net
State New
Headers show
Series
  • [1/2] arm64: dts: rockchip: replace GPIO number into macro for rk3399
Related show

Commit Message

Katsuhiro Suzuki Feb. 19, 2019, 2:08 p.m. UTC
This patch fixes pin assign of cts and rts signal of UART3.

Currently GPIO3_C2 and C3 pins are assigned but TRM says that
GPIO3_C0 and C1 are correct.

Refer:
  RK3399 TRM v1.4 - Table 19-1 UART Interface Description

Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Katsuhiro Suzuki March 4, 2019, 2 p.m. UTC | #1
ping...

On 2019/02/19 23:08, Katsuhiro Suzuki wrote:
> This patch fixes pin assign of cts and rts signal of UART3.
> 
> Currently GPIO3_C2 and C3 pins are assigned but TRM says that
> GPIO3_C0 and C1 are correct.
> 
> Refer:
>    RK3399 TRM v1.4 - Table 19-1 UART Interface Description
> 
> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> ---
>   arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 76fc2c7af80a..beaa92744a64 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -2535,12 +2535,12 @@
>   
>   			uart3_cts: uart3-cts {
>   				rockchip,pins =
> -					<3 RK_PC2 RK_FUNC_2 &pcfg_pull_none>;
> +					<3 RK_PC0 RK_FUNC_2 &pcfg_pull_none>;
>   			};
>   
>   			uart3_rts: uart3-rts {
>   				rockchip,pins =
> -					<3 RK_PC3 RK_FUNC_2 &pcfg_pull_none>;
> +					<3 RK_PC1 RK_FUNC_2 &pcfg_pull_none>;
>   			};
>   		};
>   
>
Katsuhiro Suzuki March 21, 2019, 2:55 p.m. UTC | #2
ping again...

Please let me know if there is problem in this patch.


On 2019/03/04 23:00, Katsuhiro Suzuki wrote:
> ping...
> 
> On 2019/02/19 23:08, Katsuhiro Suzuki wrote:
>> This patch fixes pin assign of cts and rts signal of UART3.
>>
>> Currently GPIO3_C2 and C3 pins are assigned but TRM says that
>> GPIO3_C0 and C1 are correct.
>>
>> Refer:
>>    RK3399 TRM v1.4 - Table 19-1 UART Interface Description
>>
>> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi 
>> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> index 76fc2c7af80a..beaa92744a64 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> @@ -2535,12 +2535,12 @@
>>               uart3_cts: uart3-cts {
>>                   rockchip,pins =
>> -                    <3 RK_PC2 RK_FUNC_2 &pcfg_pull_none>;
>> +                    <3 RK_PC0 RK_FUNC_2 &pcfg_pull_none>;
>>               };
>>               uart3_rts: uart3-rts {
>>                   rockchip,pins =
>> -                    <3 RK_PC3 RK_FUNC_2 &pcfg_pull_none>;
>> +                    <3 RK_PC1 RK_FUNC_2 &pcfg_pull_none>;
>>               };
>>           };
>>
> 
>

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 76fc2c7af80a..beaa92744a64 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -2535,12 +2535,12 @@ 
 
 			uart3_cts: uart3-cts {
 				rockchip,pins =
-					<3 RK_PC2 RK_FUNC_2 &pcfg_pull_none>;
+					<3 RK_PC0 RK_FUNC_2 &pcfg_pull_none>;
 			};
 
 			uart3_rts: uart3-rts {
 				rockchip,pins =
-					<3 RK_PC3 RK_FUNC_2 &pcfg_pull_none>;
+					<3 RK_PC1 RK_FUNC_2 &pcfg_pull_none>;
 			};
 		};