| Message ID | 20190220010232.18731-20-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | chardev: Convert qemu_chr_write() to take a size_t argument | expand |
On Wed, 20 Feb 2019 02:02:26 +0100 Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > include/hw/s390x/ebcdic.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/hw/s390x/ebcdic.h b/include/hw/s390x/ebcdic.h > index 69a04cab62..d89174e113 100644 > --- a/include/hw/s390x/ebcdic.h > +++ b/include/hw/s390x/ebcdic.h > @@ -83,18 +83,18 @@ static const uint8_t ascii2ebcdic[] = { > 0x90, 0x3F, 0x3F, 0x3F, 0x3F, 0xEA, 0x3F, 0xFF > }; > > -static inline void ebcdic_put(uint8_t *p, const char *ascii, int len) > +static inline void ebcdic_put(uint8_t *p, const char *ascii, size_t len) > { > - int i; > + size_t i; > > for (i = 0; i < len; i++) { > p[i] = ascii2ebcdic[(uint8_t)ascii[i]]; > } > } > > -static inline void ascii_put(uint8_t *p, const char *ebcdic, int len) > +static inline void ascii_put(uint8_t *p, const char *ebcdic, size_t len) > { > - int i; > + size_t i; > > for (i = 0; i < len; i++) { > p[i] = ebcdic2ascii[(uint8_t)ebcdic[i]]; Making the passed len parameter a size_t makes sense; but using a size_t as an array iterator looks a bit unidiomatic... it's not wrong, though. Acked-by: Cornelia Huck <cohuck@redhat.com>
On 2/20/19 10:40 AM, Cornelia Huck wrote: > On Wed, 20 Feb 2019 02:02:26 +0100 > Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> --- >> include/hw/s390x/ebcdic.h | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/include/hw/s390x/ebcdic.h b/include/hw/s390x/ebcdic.h >> index 69a04cab62..d89174e113 100644 >> --- a/include/hw/s390x/ebcdic.h >> +++ b/include/hw/s390x/ebcdic.h >> @@ -83,18 +83,18 @@ static const uint8_t ascii2ebcdic[] = { >> 0x90, 0x3F, 0x3F, 0x3F, 0x3F, 0xEA, 0x3F, 0xFF >> }; >> >> -static inline void ebcdic_put(uint8_t *p, const char *ascii, int len) >> +static inline void ebcdic_put(uint8_t *p, const char *ascii, size_t len) >> { >> - int i; >> + size_t i; >> >> for (i = 0; i < len; i++) { >> p[i] = ascii2ebcdic[(uint8_t)ascii[i]]; >> } >> } >> >> -static inline void ascii_put(uint8_t *p, const char *ebcdic, int len) >> +static inline void ascii_put(uint8_t *p, const char *ebcdic, size_t len) >> { >> - int i; >> + size_t i; >> >> for (i = 0; i < len; i++) { >> p[i] = ebcdic2ascii[(uint8_t)ebcdic[i]]; > > Making the passed len parameter a size_t makes sense; but using a > size_t as an array iterator looks a bit unidiomatic... it's not wrong, > though. This is to silent the "-Wsign-conversion -Wsign-compare" warnings... I am still not sure what is the best to do. > Acked-by: Cornelia Huck <cohuck@redhat.com> Thanks! Phil.
diff --git a/include/hw/s390x/ebcdic.h b/include/hw/s390x/ebcdic.h index 69a04cab62..d89174e113 100644 --- a/include/hw/s390x/ebcdic.h +++ b/include/hw/s390x/ebcdic.h @@ -83,18 +83,18 @@ static const uint8_t ascii2ebcdic[] = { 0x90, 0x3F, 0x3F, 0x3F, 0x3F, 0xEA, 0x3F, 0xFF }; -static inline void ebcdic_put(uint8_t *p, const char *ascii, int len) +static inline void ebcdic_put(uint8_t *p, const char *ascii, size_t len) { - int i; + size_t i; for (i = 0; i < len; i++) { p[i] = ascii2ebcdic[(uint8_t)ascii[i]]; } } -static inline void ascii_put(uint8_t *p, const char *ebcdic, int len) +static inline void ascii_put(uint8_t *p, const char *ebcdic, size_t len) { - int i; + size_t i; for (i = 0; i < len; i++) { p[i] = ebcdic2ascii[(uint8_t)ebcdic[i]];
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- include/hw/s390x/ebcdic.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)