| Message ID | 20190220153303.32081-1-jakllsch@kollasch.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: dts: allwinner: fix status LED on nanopi-neo-plus2 | expand |
Hi! A few generic comments before, you should send the patches to all the recipients in get_maintainers.pl, which means that in that case in particular, you forgot to send it to Chen-Yu Tsai. Also, when you're sending a new iteration, please provide the changes you made since the previous iteration after the ---. On Wed, Feb 20, 2019 at 09:33:03AM -0600, Jonathan A. Kollasch wrote: > The schematics[1][2] for both versions of the NanoPi NEO Plus2 place the > STAT status LED on GPIOA10, and describe it as being a blue LED. > > This change makes the blue status LED on my v1.0 board functional. > > Signed-off-by: Jonathan A. Kollasch <jakllsch@kollasch.net> > > [1]: http://wiki.friendlyarm.com/wiki/images/8/86/Schematic_NanoPi_NEO_Plus2-v1.0-1704.pdf > [2]: http://wiki.friendlyarm.com/wiki/images/b/bf/Schematic_NanoPi_NEO_Plus2-v1.1-1805.pdf URLs also have the tendency to become dead quite fast, while the git history is here for ever, so it'd be better to avoid having them in the commit message itself, but feel free to add them as reference after the --- Thanks! Maxime
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts index 506e25ba028a..b8eb43a0d007 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts @@ -71,8 +71,8 @@ }; status { - label = "nanopi:red:status"; - gpios = <&pio 0 20 GPIO_ACTIVE_HIGH>; + label = "nanopi:blue:status"; + gpios = <&pio 0 10 GPIO_ACTIVE_HIGH>; }; };
The schematics[1][2] for both versions of the NanoPi NEO Plus2 place the STAT status LED on GPIOA10, and describe it as being a blue LED. This change makes the blue status LED on my v1.0 board functional. Signed-off-by: Jonathan A. Kollasch <jakllsch@kollasch.net> [1]: http://wiki.friendlyarm.com/wiki/images/8/86/Schematic_NanoPi_NEO_Plus2-v1.0-1704.pdf [2]: http://wiki.friendlyarm.com/wiki/images/b/bf/Schematic_NanoPi_NEO_Plus2-v1.1-1805.pdf --- arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)