From patchwork Wed Feb 20 20:40:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10822715 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D417B14E1 for ; Wed, 20 Feb 2019 20:41:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C15172FA65 for ; Wed, 20 Feb 2019 20:41:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B52902FA6C; Wed, 20 Feb 2019 20:41:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4F0792FA2E for ; Wed, 20 Feb 2019 20:41:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 92AA9892DC; Wed, 20 Feb 2019 20:41:09 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E729892DC for ; Wed, 20 Feb 2019 20:41:07 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id m35so17142558ede.10 for ; Wed, 20 Feb 2019 12:41:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=S6f5ltKfmmbc/Y9tRkkr1Gep0E2+84qSjXYQazP6FGY=; b=Pyg4145a/hTB+2JZ3m1uJAxvjBgYH7JDaOeIr7/aRMvCMD4cvlH65ZzRjEy3dGmy27 8VC4bQ6RErPQqn8tGE+5iRibB2vaE8rm8S10rfs8CzZJ9h2uRmiXeqQWciONFRY1+Jk5 NOB9TXaLw17P6R+82LkAabJGpOX20l6dryLgtc601VLdmIeQRY93ylFoTdNYI9r6pf/Q 52bK2VDamo4UrK1mICLob9aNJzQsFOYaF9bNSDnbR3W6SFP/eh7VaQMRZoGAqiwsoTcn lj2gIN4GpEOFeVkEG4gqU3FDhIupJ4jdZTB8GlJIOoYSy5awVtYtUqNntByOksgk+yy/ tKmw== X-Gm-Message-State: AHQUAub8WsaZ7yRHi62JC6J/NRWwNlKPtnG+JG16UbAJ4GL6ZqfQfQs9 U+VVwnl8IX+GL5m170ZiSxWIP/Kl432sbQ== X-Google-Smtp-Source: AHgI3IagqA0mxBGHF+yEfWeC0mj2PH/FOucG9GisitYve7hjX3IsPJmMFQpogapUuhVj9T6XNVqoOw== X-Received: by 2002:a17:906:1602:: with SMTP id m2mr13654457ejd.228.1550695265590; Wed, 20 Feb 2019 12:41:05 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id j6sm6087946edd.43.2019.02.20.12.41.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Feb 2019 12:41:04 -0800 (PST) From: Daniel Vetter To: DRI Development , LKML Subject: [PATCH] mm: Don't let userspace spam allocations warnings Date: Wed, 20 Feb 2019 21:40:58 +0100 Message-Id: <20190220204058.11676-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=S6f5ltKfmmbc/Y9tRkkr1Gep0E2+84qSjXYQazP6FGY=; b=Qw7lFkV8yfgMQI7I1KxGwt8coeYmzppBGjv89An9g4411slsQYPWkWoHK5o6qTaZY8 mGVh03kx1JrDV9WJ5hZVsSPFHwCrg7JtjxyRHfwFNCmGCG1aNmrR3BweASg7EduzJRcC ZKEsPQaejvdqcHGTjwANDEGhQqLpqZ3r+9C+k= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Hocko , Kees Cook , "Michael S. Tsirkin" , Daniel Vetter , Bartosz Golaszewski , Huang Ying , Jan Stancek , linux-mm@kvack.org, Mike Rapoport , Andrey Ryabinin , Daniel Vetter , Andrew Morton , Roman Gushchin , Vlastimil Babka Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP memdump_user usually gets fed unchecked userspace input. Blasting a full backtrace into dmesg every time is a bit excessive - I'm not sure on the kernel rule in general, but at least in drm we're trying not to let unpriviledge userspace spam the logs freely. Definitely not entire warning backtraces. It also means more filtering for our CI, because our testsuite exercises these corner cases and so hits these a lot. Signed-off-by: Daniel Vetter Cc: Andrew Morton Cc: Mike Rapoport Cc: Michal Hocko Cc: Roman Gushchin Cc: Vlastimil Babka Cc: Jan Stancek Cc: Kees Cook Cc: Andrey Ryabinin Cc: "Michael S. Tsirkin" Cc: Huang Ying Cc: Bartosz Golaszewski Cc: linux-mm@kvack.org Reviewed-by: Kees Cook Acked-by: Michal Hocko --- mm/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/util.c b/mm/util.c index 1ea055138043..379319b1bcfd 100644 --- a/mm/util.c +++ b/mm/util.c @@ -150,7 +150,7 @@ void *memdup_user(const void __user *src, size_t len) { void *p; - p = kmalloc_track_caller(len, GFP_USER); + p = kmalloc_track_caller(len, GFP_USER | __GFP_NOWARN); if (!p) return ERR_PTR(-ENOMEM);