| Message ID | 1550824089-19961-4-git-send-email-christophe.roullier@st.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | stmmac: add some fixes for stm32 | expand |
On Fri, Feb 22, 2019 at 09:28:04AM +0100, Christophe Roullier wrote: > Add properties to support all Phy config > PHY_MODE (MII,GMII, RMII, RGMII) and in normal, PHY wo crystal (25Mhz), > PHY wo crystal (50Mhz), No 125Mhz from PHY config. > > Signed-off-by: Christophe Roullier <christophe.roullier@st.com> > --- > Documentation/devicetree/bindings/net/stm32-dwmac.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > index 1341012..f42dc68 100644 > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.txt > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > @@ -24,9 +24,9 @@ Required properties: > encompases the glue register, and the offset of the control register. > > Optional properties: > -- clock-names: For MPU family "mac-clk-ck" for PHY without quartz > -- st,int-phyclk (boolean) : valid only where PHY do not have quartz and need to be clock > - by RCC You can't just remove properties. > +- clock-names: For MPU family "eth-ck" for PHY without quartz > +- st,eth_clk_sel (boolean) : set this property in RGMII PHY when you do not want use 125Mhz > +- st,eth_ref_clk_sel (boolean) : set this property in RMII mode when you have PHY without crystal 50MHz s/_/-/ 'sel' I assume is short for select, but the naming here and description don't really tell me what I'm getting. Rob
On 2/23/19 1:16 AM, Rob Herring wrote: > On Fri, Feb 22, 2019 at 09:28:04AM +0100, Christophe Roullier wrote: >> Add properties to support all Phy config >> PHY_MODE (MII,GMII, RMII, RGMII) and in normal, PHY wo crystal (25Mhz), >> PHY wo crystal (50Mhz), No 125Mhz from PHY config. >> >> Signed-off-by: Christophe Roullier <christophe.roullier@st.com> >> --- >> Documentation/devicetree/bindings/net/stm32-dwmac.txt | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> index 1341012..f42dc68 100644 >> --- a/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt >> @@ -24,9 +24,9 @@ Required properties: >> encompases the glue register, and the offset of the control register. >> >> Optional properties: >> -- clock-names: For MPU family "mac-clk-ck" for PHY without quartz >> -- st,int-phyclk (boolean) : valid only where PHY do not have quartz and need to be clock >> - by RCC > > You can't just remove properties. There is no risk to remove/rename these 2 properties, because it is specific board which is never deployed. With new properties (renaming clock (eth-ck) + st,eth_clk_sel and st,eth_ref_clk_sel, we are managed all kind of specific boards stm32mp1 So no risk of backward compatible. > >> +- clock-names: For MPU family "eth-ck" for PHY without quartz >> +- st,eth_clk_sel (boolean) : set this property in RGMII PHY when you do not want use 125Mhz >> +- st,eth_ref_clk_sel (boolean) : set this property in RMII mode when you have PHY without crystal 50MHz > > s/_/-/ > > 'sel' I assume is short for select, but the naming here and description > don't really tell me what I'm getting. > Ok, Rob, I will update with your recommendations > Rob >
diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt index 1341012..f42dc68 100644 --- a/Documentation/devicetree/bindings/net/stm32-dwmac.txt +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt @@ -24,9 +24,9 @@ Required properties: encompases the glue register, and the offset of the control register. Optional properties: -- clock-names: For MPU family "mac-clk-ck" for PHY without quartz -- st,int-phyclk (boolean) : valid only where PHY do not have quartz and need to be clock - by RCC +- clock-names: For MPU family "eth-ck" for PHY without quartz +- st,eth_clk_sel (boolean) : set this property in RGMII PHY when you do not want use 125Mhz +- st,eth_ref_clk_sel (boolean) : set this property in RMII mode when you have PHY without crystal 50MHz Example:
Add properties to support all Phy config PHY_MODE (MII,GMII, RMII, RGMII) and in normal, PHY wo crystal (25Mhz), PHY wo crystal (50Mhz), No 125Mhz from PHY config. Signed-off-by: Christophe Roullier <christophe.roullier@st.com> --- Documentation/devicetree/bindings/net/stm32-dwmac.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)