| Message ID | 20190222104844.1847-1-Tianyu.Lan@microsoft.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT | expand |
On Fri, Feb 22, 2019 at 06:48:44PM +0800, lantianyu1986@gmail.com wrote: > From: Lan Tianyu <Tianyu.Lan@microsoft.com> > > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall > is equal with how many entries of union hv_gpa_page_range can be populated > into the input parameter page. The origin code lacks parenthesis around > PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it. > > Cc: <stable@vger.kernel.org> > Fixs: cc4edae4b9(x86/hyper-v: Add HvFlushGuestAddressList hypercall support) Please use this format instead: Fixes: cc4edae4b924 ("x86/hyper-v: Add HvFlushGuestAddressList hypercall support") And don't type it by hand, use a git alias for it: git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" You also messed up your To: line, keeping anyone from being able to respond to this message who do not know how to hand-edit the response line :( thanks, greg k-h
On Fri, Feb 22, 2019 at 10:32 PM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Fri, Feb 22, 2019 at 06:48:44PM +0800, lantianyu1986@gmail.com wrote: > > From: Lan Tianyu <Tianyu.Lan@microsoft.com> > > > > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall > > is equal with how many entries of union hv_gpa_page_range can be populated > > into the input parameter page. The origin code lacks parenthesis around > > PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it. > > > > Cc: <stable@vger.kernel.org> > > Fixs: cc4edae4b9(x86/hyper-v: Add HvFlushGuestAddressList hypercall support) > > Please use this format instead: > > Fixes: cc4edae4b924 ("x86/hyper-v: Add HvFlushGuestAddressList hypercall support") > > And don't type it by hand, use a git alias for it: > git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" > OK. Will update. Thanks. > You also messed up your To: line, keeping anyone from being able to > respond to this message who do not know how to hand-edit the response > line :( I put all expected reviewers in the Cc line and will put into To line. > > thanks, > > greg k-h
On 22/02/19 11:48, lantianyu1986@gmail.com wrote: > From: Lan Tianyu <Tianyu.Lan@microsoft.com> > > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall > is equal with how many entries of union hv_gpa_page_range can be populated > into the input parameter page. The origin code lacks parenthesis around > PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it. > > Cc: <stable@vger.kernel.org> > Fixs: cc4edae4b9(x86/hyper-v: Add HvFlushGuestAddressList hypercall support) > Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com> > --- > arch/x86/include/asm/hyperv-tlfs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h > index 705dafc2d11a..2bdbbbcfa393 100644 > --- a/arch/x86/include/asm/hyperv-tlfs.h > +++ b/arch/x86/include/asm/hyperv-tlfs.h > @@ -841,7 +841,7 @@ union hv_gpa_page_range { > * count is equal with how many entries of union hv_gpa_page_range can > * be populated into the input parameter page. > */ > -#define HV_MAX_FLUSH_REP_COUNT (PAGE_SIZE - 2 * sizeof(u64) / \ > +#define HV_MAX_FLUSH_REP_COUNT ((PAGE_SIZE - 2 * sizeof(u64)) / \ > sizeof(union hv_gpa_page_range)) > > struct hv_guest_mapping_flush_list { > Queued for after he merge window, with the fixed "Fixes" tag. Paolo
On Fri, 15 Mar 2019, Paolo Bonzini wrote: > On 22/02/19 11:48, lantianyu1986@gmail.com wrote: > > From: Lan Tianyu <Tianyu.Lan@microsoft.com> > > > > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall > > is equal with how many entries of union hv_gpa_page_range can be populated > > into the input parameter page. The origin code lacks parenthesis around > > PAGE_SIZE - 2 * sizeof(u64). This patch is to fix it. > > > > Cc: <stable@vger.kernel.org> > > Fixs: cc4edae4b9(x86/hyper-v: Add HvFlushGuestAddressList hypercall support) > > Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com> > > --- > > arch/x86/include/asm/hyperv-tlfs.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h > > index 705dafc2d11a..2bdbbbcfa393 100644 > > --- a/arch/x86/include/asm/hyperv-tlfs.h > > +++ b/arch/x86/include/asm/hyperv-tlfs.h > > @@ -841,7 +841,7 @@ union hv_gpa_page_range { > > * count is equal with how many entries of union hv_gpa_page_range can > > * be populated into the input parameter page. > > */ > > -#define HV_MAX_FLUSH_REP_COUNT (PAGE_SIZE - 2 * sizeof(u64) / \ > > +#define HV_MAX_FLUSH_REP_COUNT ((PAGE_SIZE - 2 * sizeof(u64)) / \ > > sizeof(union hv_gpa_page_range)) > > > > struct hv_guest_mapping_flush_list { > > > > Queued for after he merge window, with the fixed "Fixes" tag. That's upstream already: 9cd05ad2910b ("x86/hyper-v: Fix definition of HV_MAX_FLUSH_REP_COUNT") Thanks, tglx
diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h index 705dafc2d11a..2bdbbbcfa393 100644 --- a/arch/x86/include/asm/hyperv-tlfs.h +++ b/arch/x86/include/asm/hyperv-tlfs.h @@ -841,7 +841,7 @@ union hv_gpa_page_range { * count is equal with how many entries of union hv_gpa_page_range can * be populated into the input parameter page. */ -#define HV_MAX_FLUSH_REP_COUNT (PAGE_SIZE - 2 * sizeof(u64) / \ +#define HV_MAX_FLUSH_REP_COUNT ((PAGE_SIZE - 2 * sizeof(u64)) / \ sizeof(union hv_gpa_page_range)) struct hv_guest_mapping_flush_list {