diff mbox series

[v4,03/10] btrfs: trivial, fix c coding style

Message ID 1550857192-10513-4-git-send-email-anand.jain@oracle.com (mailing list archive)
State New, archived
Headers show
Series Misc props.c cleanups | expand

Commit Message

Anand Jain Feb. 22, 2019, 5:39 p.m. UTC 
Maintain the lines extented upto 80 char where possible, and indent the
argument.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
---
v4: none.
v3: changelog added.
 fs/btrfs/props.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

Comments

David Sterba Feb. 27, 2019, 4:05 p.m. UTC | #1 
On Sat, Feb 23, 2019 at 01:39:45AM +0800, Anand Jain wrote:
> Maintain the lines extented upto 80 char where possible, and indent the
> argument.
> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> Reviewed-by: Nikolay Borisov <nborisov@suse.com>

I don't think such patches are necessary, there's a lot of strange
formatting from the past and we could fix the ugly ones but otherwise
strive to fix everything before it gets merged.  I do a lot of fixups
just before the final merge, but having everybody follow the same coding
style is near to impossible.
Anand Jain Feb. 28, 2019, 9:50 a.m. UTC | #2 
On 2/28/19 12:05 AM, David Sterba wrote:
> On Sat, Feb 23, 2019 at 01:39:45AM +0800, Anand Jain wrote:
>> Maintain the lines extented upto 80 char where possible, and indent the
>> argument.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> 
> I don't think such patches are necessary, there's a lot of strange
> formatting from the past and we could fix the ugly ones but otherwise
> strive to fix everything before it gets merged.  I do a lot of fixups
> just before the final merge, but having everybody follow the same coding
> style is near to impossible.
> 

Ok. Will drop this.
diff mbox series

Patch

diff --git a/fs/btrfs/props.c b/fs/btrfs/props.c
index 77a03076b18e..3c15f19bfd2f 100644
--- a/fs/btrfs/props.c
+++ b/fs/btrfs/props.c
@@ -70,8 +70,8 @@  int btrfs_set_prop(struct btrfs_trans_handle *trans, struct inode *inode,
 		return -EINVAL;
 
 	if (value_len == 0) {
-		ret = btrfs_setxattr(trans, inode, handler->xattr_name,
-				       NULL, 0, flags);
+		ret = btrfs_setxattr(trans, inode, handler->xattr_name, NULL, 0,
+				     flags);
 		if (ret)
 			return ret;
 
@@ -101,12 +101,10 @@  int btrfs_set_prop(struct btrfs_trans_handle *trans, struct inode *inode,
 }
 
 static int iterate_object_props(struct btrfs_root *root,
-				struct btrfs_path *path,
-				u64 objectid,
+				struct btrfs_path *path, u64 objectid,
 				void (*iterator)(void *,
 						 const struct prop_handler *,
-						 const char *,
-						 size_t),
+						 const char *, size_t),
 				void *ctx)
 {
 	int ret;
@@ -211,10 +209,8 @@  static int iterate_object_props(struct btrfs_root *root,
 	return ret;
 }
 
-static void inode_prop_iterator(void *ctx,
-				const struct prop_handler *handler,
-				const char *value,
-				size_t len)
+static void inode_prop_iterator(void *ctx, const struct prop_handler *handler,
+				const char *value, size_t len)
 {
 	struct inode *inode = ctx;
 	struct btrfs_root *root = BTRFS_I(inode)->root;