arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound
diff mbox series

Message ID 20190225093604.25753-1-horms+renesas@verge.net.au
State New
Headers show
Series
  • arm64: dts: renesas: salvator: add dummy 2nd port to rcar_sound
Related show

Commit Message

Simon Horman Feb. 25, 2019, 9:36 a.m. UTC
Add dummy 2nd port node to rcar_sound ports node to satisfy dtc
recommendation that #address-cells / #size-cells is only needed.

This addresses the following warning:

arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary

This change should not have any run-time effect.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

---
Build tested against renesas-devel-20190214-v5.0-rc6
---
 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Geert Uytterhoeven Feb. 25, 2019, 9:49 a.m. UTC | #1
CC DT

On Mon, Feb 25, 2019 at 10:37 AM Simon Horman
<horms+renesas@verge.net.au> wrote:
> Add dummy 2nd port node to rcar_sound ports node to satisfy dtc
> recommendation that #address-cells / #size-cells is only needed.
>
> This addresses the following warning:
>
> arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
>
> This change should not have any run-time effect.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> ---
> Build tested against renesas-devel-20190214-v5.0-rc6
> ---
>  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index a225c2457274..20b35991bc17 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -716,6 +716,15 @@
>                                 capture  = <&ssi1 &src1 &dvc1>;
>                         };
>                 };
> +
> +               /* Dummy node to be overriden by board DT
> +                * Satisfies dtc recommendation that
> +                * #address-cells / #size-cells is only needed
> +                * for graph nodes with multiple child nodes.
> +                */
> +               rsnd_port1: port@1 {
> +                       reg = <1>;
> +               };
>         };
>  };

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven Feb. 25, 2019, 9:51 a.m. UTC | #2
Woops, this time using the Real Rob.

On Mon, Feb 25, 2019 at 10:49 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> CC DT
>
> On Mon, Feb 25, 2019 at 10:37 AM Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > Add dummy 2nd port node to rcar_sound ports node to satisfy dtc
> > recommendation that #address-cells / #size-cells is only needed.
> >
> > This addresses the following warning:
> >
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> >
> > This change should not have any run-time effect.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > ---
> > Build tested against renesas-devel-20190214-v5.0-rc6
> > ---
> >  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > index a225c2457274..20b35991bc17 100644
> > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > @@ -716,6 +716,15 @@
> >                                 capture  = <&ssi1 &src1 &dvc1>;
> >                         };
> >                 };
> > +
> > +               /* Dummy node to be overriden by board DT
> > +                * Satisfies dtc recommendation that
> > +                * #address-cells / #size-cells is only needed
> > +                * for graph nodes with multiple child nodes.
> > +                */
> > +               rsnd_port1: port@1 {
> > +                       reg = <1>;
> > +               };
> >         };
> >  };

Gr{oetje,eeting}s,

                        Geert
Kuninori Morimoto Feb. 26, 2019, 12:28 a.m. UTC | #3
Hi Simon

Thank you for your patch

> Add dummy 2nd port node to rcar_sound ports node to satisfy dtc
> recommendation that #address-cells / #size-cells is only needed.
> 
> This addresses the following warning:
> 
> arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> 
> This change should not have any run-time effect.
> 
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> ---
> Build tested against renesas-devel-20190214-v5.0-rc6
> ---
>  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index a225c2457274..20b35991bc17 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -716,6 +716,15 @@
>  				capture  = <&ssi1 &src1 &dvc1>;
>  			};
>  		};
> +
> +		/* Dummy node to be overriden by board DT
> +		 * Satisfies dtc recommendation that
> +		 * #address-cells / #size-cells is only needed
> +		 * for graph nodes with multiple child nodes.
> +		 */
> +		rsnd_port1: port@1 {
> +			reg = <1>;
> +		};
>  	};
>  };

This solution is strange for me.
I want to solve it, but I couldn't reproduce this.
Which branch, and how to reproduce it ?
Simon Horman Feb. 26, 2019, 10:08 a.m. UTC | #4
On Tue, Feb 26, 2019 at 09:28:53AM +0900, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> Thank you for your patch
> 
> > Add dummy 2nd port node to rcar_sound ports node to satisfy dtc
> > recommendation that #address-cells / #size-cells is only needed.
> > 
> > This addresses the following warning:
> > 
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi:703.8-719.4: Warning (graph_child_address): /soc/sound@ec500000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> > 
> > This change should not have any run-time effect.
> > 
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > 
> > ---
> > Build tested against renesas-devel-20190214-v5.0-rc6
> > ---
> >  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > index a225c2457274..20b35991bc17 100644
> > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > @@ -716,6 +716,15 @@
> >  				capture  = <&ssi1 &src1 &dvc1>;
> >  			};
> >  		};
> > +
> > +		/* Dummy node to be overriden by board DT
> > +		 * Satisfies dtc recommendation that
> > +		 * #address-cells / #size-cells is only needed
> > +		 * for graph nodes with multiple child nodes.
> > +		 */
> > +		rsnd_port1: port@1 {
> > +			reg = <1>;
> > +		};
> >  	};
> >  };
> 
> This solution is strange for me.
> I want to solve it, but I couldn't reproduce this.
> Which branch, and how to reproduce it ?

Thanks Morimoto-san,

I see this on renesas-devel-20190225-v5.0-rc8 using:

ARCH=arm64 make dtbs W=1
Kuninori Morimoto Feb. 27, 2019, 5 a.m. UTC | #5
Hi Simon

> > This solution is strange for me.
> > I want to solve it, but I couldn't reproduce this.
> > Which branch, and how to reproduce it ?
> 
> Thanks Morimoto-san,
> 
> I see this on renesas-devel-20190225-v5.0-rc8 using:
> 
> ARCH=arm64 make dtbs W=1

Thanks !!
I think we can avoid this WARNING if we added HDMI sound support at 77965.
I will post such patches.
I didn't/can't test it, but basically no problem.

# DT is not-flexible, picky, difficult...
# to be honest, I don't like DT...

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index a225c2457274..20b35991bc17 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -716,6 +716,15 @@ 
 				capture  = <&ssi1 &src1 &dvc1>;
 			};
 		};
+
+		/* Dummy node to be overriden by board DT
+		 * Satisfies dtc recommendation that
+		 * #address-cells / #size-cells is only needed
+		 * for graph nodes with multiple child nodes.
+		 */
+		rsnd_port1: port@1 {
+			reg = <1>;
+		};
 	};
 };