[PULL,03/11] hw/usb: don't set IN_ISDIR for inotify watch in MTP driver
diff mbox series

Message ID 20190225123111.30363-4-berrange@redhat.com
State New
Headers show
  • [PULL,01/11] util: add helper APIs for dealing with inotify in portable manner
Related show

Commit Message

Daniel P. Berrangé Feb. 25, 2019, 12:31 p.m. UTC
IN_ISDIR is not a bit that one can request when registering a
watch with inotify_add_watch. Rather it is a bit that is set
automatically when reading events from the kernel.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
 hw/usb/dev-mtp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff mbox series

diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index f1d20fa1b9..f0c52a476a 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -653,8 +653,7 @@  static void usb_mtp_inotify_cleanup(MTPState *s)
 static int usb_mtp_add_watch(int inotifyfd, char *path)
-    uint32_t mask = IN_CREATE | IN_DELETE | IN_MODIFY |
-        IN_ISDIR;
+    uint32_t mask = IN_CREATE | IN_DELETE | IN_MODIFY;
     return inotify_add_watch(inotifyfd, path, mask);