| Message ID | 20190225135405.108052-1-cychiang@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cdcdba5d624fc3fbad224230ca318c6ddf73795a |
| Headers | show |
| Series | ASoC: qcom: Kconfig: fix dependency for sdm845 | expand |
Hi, On 25/2/19 14:54, Cheng-Yi Chiang wrote: > SND_SOC_CROS_EC_CODEC depends on MFD_CROS_EC. > Add that dependency to SND_SOC_SDM845 to fix unmet direct dependencies > warning. > > Fixes: 74c6ecf4194e (ASoC: qcom: Kconfig: select dmic for sdm845) Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Thanks, Enric > --- > sound/soc/qcom/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig > index 8f206cb4fcc0..75ceb04d8bf0 100644 > --- a/sound/soc/qcom/Kconfig > +++ b/sound/soc/qcom/Kconfig > @@ -98,7 +98,7 @@ config SND_SOC_MSM8996 > > config SND_SOC_SDM845 > tristate "SoC Machine driver for SDM845 boards" > - depends on QCOM_APR > + depends on QCOM_APR && MFD_CROS_EC > select SND_SOC_QDSP6 > select SND_SOC_QCOM_COMMON > select SND_SOC_RT5663 >
On 2/25/19 6:37 AM, Enric Balletbo i Serra wrote: > Hi, > > On 25/2/19 14:54, Cheng-Yi Chiang wrote: >> SND_SOC_CROS_EC_CODEC depends on MFD_CROS_EC. >> Add that dependency to SND_SOC_SDM845 to fix unmet direct dependencies >> warning. >> >> Fixes: 74c6ecf4194e (ASoC: qcom: Kconfig: select dmic for sdm845) > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > >> Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> > > Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > Thanks, > Enric Works for me. Thanks. Tested-by: Randy Dunlap <rdunlap@infradead.org> >> --- >> sound/soc/qcom/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig >> index 8f206cb4fcc0..75ceb04d8bf0 100644 >> --- a/sound/soc/qcom/Kconfig >> +++ b/sound/soc/qcom/Kconfig >> @@ -98,7 +98,7 @@ config SND_SOC_MSM8996 >> >> config SND_SOC_SDM845 >> tristate "SoC Machine driver for SDM845 boards" >> - depends on QCOM_APR >> + depends on QCOM_APR && MFD_CROS_EC >> select SND_SOC_QDSP6 >> select SND_SOC_QCOM_COMMON >> select SND_SOC_RT5663 >>
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index 8f206cb4fcc0..75ceb04d8bf0 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -98,7 +98,7 @@ config SND_SOC_MSM8996 config SND_SOC_SDM845 tristate "SoC Machine driver for SDM845 boards" - depends on QCOM_APR + depends on QCOM_APR && MFD_CROS_EC select SND_SOC_QDSP6 select SND_SOC_QCOM_COMMON select SND_SOC_RT5663
SND_SOC_CROS_EC_CODEC depends on MFD_CROS_EC. Add that dependency to SND_SOC_SDM845 to fix unmet direct dependencies warning. Fixes: 74c6ecf4194e (ASoC: qcom: Kconfig: select dmic for sdm845) Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> --- sound/soc/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)