From patchwork Mon Feb 25 19:07:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Goldwyn Rodrigues X-Patchwork-Id: 10829051 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D291D17E9 for ; Mon, 25 Feb 2019 19:08:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B69F32B0D1 for ; Mon, 25 Feb 2019 19:08:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A57D32B946; Mon, 25 Feb 2019 19:08:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41EB62B0D1 for ; Mon, 25 Feb 2019 19:08:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726377AbfBYTH4 (ORCPT ); Mon, 25 Feb 2019 14:07:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:39130 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726320AbfBYTH4 (ORCPT ); Mon, 25 Feb 2019 14:07:56 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6DDD4AF7A for ; Mon, 25 Feb 2019 19:07:55 +0000 (UTC) From: Goldwyn Rodrigues To: linux-btrfs@vger.kernel.org Cc: Goldwyn Rodrigues Subject: [PATCH 1/3] btrfs: Initialize btrfs_io_ctl instead of memsetting it Date: Mon, 25 Feb 2019 13:07:42 -0600 Message-Id: <20190225190744.21664-1-rgoldwyn@suse.de> X-Mailer: git-send-email 2.16.4 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Goldwyn Rodrigues io_ctl_init() memsets it to zero anyways. However, I presume the memset was added to avoid the WARN_ON in io_ctl_init(). Signed-off-by: Goldwyn Rodrigues --- fs/btrfs/free-space-cache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index 74aa552f4793..c813378ebf08 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c @@ -3544,13 +3544,12 @@ int btrfs_write_out_ino_cache(struct btrfs_root *root, struct btrfs_fs_info *fs_info = root->fs_info; struct btrfs_free_space_ctl *ctl = root->free_ino_ctl; int ret; - struct btrfs_io_ctl io_ctl; + struct btrfs_io_ctl io_ctl = {0}; bool release_metadata = true; if (!btrfs_test_opt(fs_info, INODE_MAP_CACHE)) return 0; - memset(&io_ctl, 0, sizeof(io_ctl)); ret = __btrfs_write_out_cache(root, inode, ctl, NULL, &io_ctl, trans); if (!ret) { /*