[v1,1/3] dt-bindings: Add dma-burst-sz property for spi-pxa2xx
diff mbox series

Message ID 20190226092441.49198-1-andriy.shevchenko@linux.intel.com
State New
Headers show
Series
  • [v1,1/3] dt-bindings: Add dma-burst-sz property for spi-pxa2xx
Related show

Commit Message

Andy Shevchenko Feb. 26, 2019, 9:24 a.m. UTC
Add DMA burst size property to the SPI PXA2xx bindings.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 Documentation/devicetree/bindings/spi/spi-pxa2xx.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown Feb. 26, 2019, 11:02 a.m. UTC | #1
On Tue, Feb 26, 2019 at 12:24:39PM +0300, Andy Shevchenko wrote:
> Add DMA burst size property to the SPI PXA2xx bindings.

Shouldn't we be inferring this from the device specific compatible
string (or PCI identifier for x86)?  That way if there's other quirks
needed we don't need any binding changes.
Andy Shevchenko Feb. 26, 2019, 11:33 a.m. UTC | #2
On Tue, Feb 26, 2019 at 11:02:38AM +0000, Mark Brown wrote:
> On Tue, Feb 26, 2019 at 12:24:39PM +0300, Andy Shevchenko wrote:
> > Add DMA burst size property to the SPI PXA2xx bindings.
> 
> Shouldn't we be inferring this from the device specific compatible
> string (or PCI identifier for x86)?  That way if there's other quirks
> needed we don't need any binding changes.

Hmm... Yes, we may use PCI ID for that.

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt b/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
index e30e0c2a4bce..3b2e70ba7466 100644
--- a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
+++ b/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
@@ -11,6 +11,7 @@  Required properties:
 Optional properties:
 - cs-gpios: list of GPIO chip selects. See the SPI bus bindings,
   Documentation/devicetree/bindings/spi/spi-bus.txt
+- dma-burst-sz: DMA burst size
 - spi-slave: Empty property indicating the SPI controller is used in slave mode.
 - ready-gpios: GPIO used to signal a SPI master that the FIFO is filled
   and we're ready to service a transfer. Only useful in slave mode.