From patchwork Tue Feb 26 14:09:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 10830301 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 828E013B5 for ; Tue, 26 Feb 2019 14:09:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6DCAB2AC6A for ; Tue, 26 Feb 2019 14:09:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5C9022AE2B; Tue, 26 Feb 2019 14:09:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 026952AC6A for ; Tue, 26 Feb 2019 14:09:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726547AbfBZOJN (ORCPT ); Tue, 26 Feb 2019 09:09:13 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:37943 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbfBZOJN (ORCPT ); Tue, 26 Feb 2019 09:09:13 -0500 Received: by mail-wm1-f67.google.com with SMTP id v26so2390295wmh.3; Tue, 26 Feb 2019 06:09:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=fze605TjWJGBwvvZ8dLki8CksOvK2Lut9ulWz/B7j4Q=; b=jROqHXJZeWdu8P+qu5aIDD47ZhajoS9SGQthWmr7LsYeoYCkzpS2FFrt4fV29+PREo u6EZdVOQ+VkH+9p2qVKW/5y2ZOPy1QqLcCa8p/2TJEQT7ZHGOsdY2A+5YqNdE1PRpasq E9wvHjg8KkWDIXbHXqTrnWE56/WFdhga/vdlt9lPJqDMyIxsKWSqhSD8YyGBZa0HA2x7 Er0aiknEOiYJby3P6P902QAong2eqQs3HjqFkDVs/QKQASVt4FO6i3FlUkvRgdu0Be+C 8ybCagZ6yDFHo1IaW24XbKLqzTuf4yDWKkG/Xl3HfM5VkC/nngLP4rtMHXoCPna8MrjB OsYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fze605TjWJGBwvvZ8dLki8CksOvK2Lut9ulWz/B7j4Q=; b=tKE7hH88gRIQ5yTQhG/X+6rDRYQyiKO4M2KGlKA9Zd/2JCkGyGl5MXi464+JFPjtSa qnGHpCiNNlFxgsojK53xp7O61Vx6xgLRler4gSStvIVSosUQUsANXB5X/YTMhmeVceQO WmmJgNSOusO7raDV0wkia9gn/eCMEp9dfEuVOIw44abOya8nSVQgCm4u2gREGg3GOouj GyCavmqgB1hB6xXKWWztuVMoFTPihIIfq/HCrcN4uqmnPYxxJMKqZuzdX6KkU2X4Yjf8 MWhKkFsOOAR7EMEuPA/TQHYwMPTrMlXTVDIH1Ypyc/V1P1Q43kiGZ9Hxn6NpopI0ioYK lvjw== X-Gm-Message-State: AHQUAuYdajln5P0OxLWf9lE1JJnrGsthfw0En/DortIsWSXB8DjxkELr Pc9jzJWfLbyvKN0yYdikVGM= X-Google-Smtp-Source: AHgI3IYZBk2AMy6UTDr8x+Jn7PhcnXoRA/pvkhsV4gI10GqM/+T/Mm899z5RwGYrpD5+ruTIJuBbyg== X-Received: by 2002:a1c:9c02:: with SMTP id f2mr2705007wme.91.1551190150672; Tue, 26 Feb 2019 06:09:10 -0800 (PST) Received: from amir-VirtualBox.ctera.local (bzq-166-168-31-246.red.bezeqint.net. [31.168.166.246]) by smtp.gmail.com with ESMTPSA id 93sm40434831wrh.15.2019.02.26.06.09.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Feb 2019 06:09:09 -0800 (PST) From: Amir Goldstein To: Eryu Guan Cc: Miklos Szeredi , Eddie Horng , linux-unionfs@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH 1/2] generic/{436,445}: check falloc support Date: Tue, 26 Feb 2019 16:09:01 +0200 Message-Id: <20190226140902.32219-1-amir73il@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The sanity test case in those tests (i.e. 13..17) are all skipped in fs with no falloc support, but the tests are reported to pass. For example, from 445.full: File system supports the default behavior. File system does not support fallocate. Allocation size: 4096 17. Test file with unwritten extents, data-hole-data inside page Test skipped as fs doesn't support unwritten extents. Explicitly check for falloc support before running those tests so they would be properly reported as skipped. Signed-off-by: Amir Goldstein --- tests/generic/436 | 2 ++ tests/generic/445 | 2 ++ tests/generic/group | 4 ++-- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/generic/436 b/tests/generic/436 index 3ed22c96..a3ef70e5 100755 --- a/tests/generic/436 +++ b/tests/generic/436 @@ -24,6 +24,8 @@ _supported_os Linux _require_test _require_seek_data_hole +# All the seek sanity test cases here do falloc +_require_xfs_io_command "falloc" BASE_TEST_FILE=$TEST_DIR/seek_sanity_testfile diff --git a/tests/generic/445 b/tests/generic/445 index e697cca0..694913ae 100755 --- a/tests/generic/445 +++ b/tests/generic/445 @@ -24,6 +24,8 @@ _supported_os Linux _require_test _require_seek_data_hole +# All the seek sanity test cases here do falloc +_require_xfs_io_command "falloc" BASE_TEST_FILE=$TEST_DIR/seek_sanity_testfile diff --git a/tests/generic/group b/tests/generic/group index 31011ac8..15227b67 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -438,7 +438,7 @@ 433 auto quick copy 434 auto quick copy 435 auto encrypt -436 auto quick rw seek +436 auto quick rw seek prealloc 437 auto quick dax 438 auto 439 auto quick punch @@ -447,7 +447,7 @@ 442 blockdev 443 auto quick rw 444 auto quick acl -445 auto quick rw seek +445 auto quick rw seek prealloc 446 auto quick rw punch 447 auto clone 448 auto quick rw seek