| Message ID | 1551316741-7848-2-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V2,1/3] dt-bindings: memory-controllers: freescale: add MMDC binding doc | expand |
Hi Anson, On Wed, Feb 27, 2019 at 10:23 PM Anson Huang <anson.huang@nxp.com> wrote: > > i.MX7ULP has a MMDC module to control DDR, it reuses > i.MX6Q's MMDC module, add support for it. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > Changes since V1: > - use "memory-controller" as MMDC node name to make it more generic. > --- > arch/arm/boot/dts/imx7ulp.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi > index fca6e50..78f6117 100644 > --- a/arch/arm/boot/dts/imx7ulp.dtsi > +++ b/arch/arm/boot/dts/imx7ulp.dtsi > @@ -286,6 +286,12 @@ > status = "disabled"; > }; > > + mmdc: memory-controller@40ab0000 { It seems that the 'mmdc' label is not neeed. You could make it simpler as: memory-controller@40ab0000 {
Hi, Fabio Best Regards! Anson Huang > -----Original Message----- > From: Fabio Estevam [mailto:festevam@gmail.com] > Sent: 2019年2月28日 9:32 > To: Anson Huang <anson.huang@nxp.com> > Cc: robh+dt@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH V2 2/3] ARM: dts: imx7ulp: add mmdc support > > Hi Anson, > > On Wed, Feb 27, 2019 at 10:23 PM Anson Huang <anson.huang@nxp.com> > wrote: > > > > i.MX7ULP has a MMDC module to control DDR, it reuses i.MX6Q's MMDC > > module, add support for it. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > Changes since V1: > > - use "memory-controller" as MMDC node name to make it more > generic. > > --- > > arch/arm/boot/dts/imx7ulp.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx7ulp.dtsi > > b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e50..78f6117 100644 > > --- a/arch/arm/boot/dts/imx7ulp.dtsi > > +++ b/arch/arm/boot/dts/imx7ulp.dtsi > > @@ -286,6 +286,12 @@ > > status = "disabled"; > > }; > > > > + mmdc: memory-controller@40ab0000 { > > It seems that the 'mmdc' label is not neeed. > > You could make it simpler as: > > memory-controller@40ab0000 { If so, should I change other i.MX6 SoCs with single MMDC node as well? Remove them as well? Anson.
Hi Anson, On Wed, Feb 27, 2019 at 10:54 PM Anson Huang <anson.huang@nxp.com> wrote: > If so, should I change other i.MX6 SoCs with single MMDC node as well? > Remove them as well? Only imx6qp needs the mmdc label. I can send a patch removing it from the other i.MX SoCs, so don't need to worry about it in your series. Thanks
Hi, Fabio Best Regards! Anson Huang > -----Original Message----- > From: Fabio Estevam [mailto:festevam@gmail.com] > Sent: 2019年2月28日 9:57 > To: Anson Huang <anson.huang@nxp.com> > Cc: robh+dt@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH V2 2/3] ARM: dts: imx7ulp: add mmdc support > > Hi Anson, > > On Wed, Feb 27, 2019 at 10:54 PM Anson Huang <anson.huang@nxp.com> > wrote: > > > If so, should I change other i.MX6 SoCs with single MMDC node as well? > > Remove them as well? > > Only imx6qp needs the mmdc label. > > I can send a patch removing it from the other i.MX SoCs, so don't need to > worry about it in your series. Oops, I already sent out V3 patch series including all i.MX SoC MMDC label removed before seeing your mail, so you can remove it from your TODO list, please help review it, thanks! Anson. > > Thanks
diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e50..78f6117 100644 --- a/arch/arm/boot/dts/imx7ulp.dtsi +++ b/arch/arm/boot/dts/imx7ulp.dtsi @@ -286,6 +286,12 @@ status = "disabled"; }; + mmdc: memory-controller@40ab0000 { + compatible = "fsl,imx7ulp-mmdc", "fsl,imx6q-mmdc"; + reg = <0x40ab0000 0x1000>; + clocks = <&pcc3 IMX7ULP_CLK_MMDC>; + }; + iomuxc1: pinctrl@40ac0000 { compatible = "fsl,imx7ulp-iomuxc1"; reg = <0x40ac0000 0x1000>;
i.MX7ULP has a MMDC module to control DDR, it reuses i.MX6Q's MMDC module, add support for it. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- Changes since V1: - use "memory-controller" as MMDC node name to make it more generic. --- arch/arm/boot/dts/imx7ulp.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)