Message ID | 20190228144910.26488-3-daniel.vetter@ffwll.ch (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | some cleanups and uapi clarification for leases | expand |
On Thu, 28 Feb 2019 15:49:05 +0100 Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > We disallow subleasing, so no point checking whether the master holds > all the leases - it will. > > Spotted while typing exhaustive igt coverage for all these corner > cases. > > Cc: Keith Packard <keithp@keithp.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > drivers/gpu/drm/drm_lease.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c > index 1176d814cf7f..cce5d9dd52ff 100644 > --- a/drivers/gpu/drm/drm_lease.c > +++ b/drivers/gpu/drm/drm_lease.c > @@ -220,8 +220,6 @@ static struct drm_master *drm_lease_create(struct drm_master *lessor, struct idr > error = 0; > if (!idr_find(&dev->mode_config.object_idr, object)) > error = -ENOENT; > - else if (!_drm_lease_held_master(lessor, object)) > - error = -EACCES; > else if (_drm_has_leased(lessor, object)) > error = -EBUSY; >
diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c index 1176d814cf7f..cce5d9dd52ff 100644 --- a/drivers/gpu/drm/drm_lease.c +++ b/drivers/gpu/drm/drm_lease.c @@ -220,8 +220,6 @@ static struct drm_master *drm_lease_create(struct drm_master *lessor, struct idr error = 0; if (!idr_find(&dev->mode_config.object_idr, object)) error = -ENOENT; - else if (!_drm_lease_held_master(lessor, object)) - error = -EACCES; else if (_drm_has_leased(lessor, object)) error = -EBUSY;
We disallow subleasing, so no point checking whether the master holds all the leases - it will. Spotted while typing exhaustive igt coverage for all these corner cases. Cc: Keith Packard <keithp@keithp.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/drm_lease.c | 2 -- 1 file changed, 2 deletions(-)