| Message ID | 20190301015342.28888-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] fbdev: omap2: omapfb: trivial code cleanup | expand |
Hi, On 03/01/2019 02:53 AM, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > After commit 60d2fa0dad06 ("fbdev: omap2: no need to check > return value of debugfs_create functions"), there are corner > code need to be cleaned. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Thanks but I've already applied earlier patch from Anders Roxell: https://marc.info/?l=linux-fbdev&m=155004766902831&w=2 > --- > drivers/video/fbdev/omap2/omapfb/dss/core.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c > index 7e6a3eb..b5956a1 100644 > --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c > +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c > @@ -136,7 +136,6 @@ static inline void dss_uninitialize_debugfs(void) > } > void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) > { > - return 0; > } > #endif /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ > > @@ -169,8 +168,6 @@ static struct notifier_block omap_dss_pm_notif_block = { > > static int __init omap_dss_probe(struct platform_device *pdev) > { > - int r; > - > core.pdev = pdev; > > dss_features_init(omapdss_get_version()); Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
On 2019/3/1 22:50, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On 03/01/2019 02:53 AM, Yue Haibing wrote: >> From: YueHaibing <yuehaibing@huawei.com> >> >> After commit 60d2fa0dad06 ("fbdev: omap2: no need to check >> return value of debugfs_create functions"), there are corner >> code need to be cleaned. >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Thanks but I've already applied earlier patch from Anders Roxell: > > https://marc.info/?l=linux-fbdev&m=155004766902831&w=2 Good to know this, Thanks! > >> --- >> drivers/video/fbdev/omap2/omapfb/dss/core.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c >> index 7e6a3eb..b5956a1 100644 >> --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c >> +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c >> @@ -136,7 +136,6 @@ static inline void dss_uninitialize_debugfs(void) >> } >> void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) >> { >> - return 0; >> } >> #endif /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ >> >> @@ -169,8 +168,6 @@ static struct notifier_block omap_dss_pm_notif_block = { >> >> static int __init omap_dss_probe(struct platform_device *pdev) >> { >> - int r; >> - >> core.pdev = pdev; >> >> dss_features_init(omapdss_get_version()); > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics > >
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c index 7e6a3eb..b5956a1 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -136,7 +136,6 @@ static inline void dss_uninitialize_debugfs(void) } void dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)) { - return 0; } #endif /* CONFIG_FB_OMAP2_DSS_DEBUGFS */ @@ -169,8 +168,6 @@ static struct notifier_block omap_dss_pm_notif_block = { static int __init omap_dss_probe(struct platform_device *pdev) { - int r; - core.pdev = pdev; dss_features_init(omapdss_get_version());