| Message ID | 20190304025008.11986-1-xzhou@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | generic/294: skip on NFS | expand |
On Mon, Mar 04, 2019 at 10:50:08AM +0800, Murphy Zhou wrote: > Because NFS handles this differently, returning different values. > Details: > http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294 Any comments are helpful, :) Thanks M > > Signed-off-by: Murphy Zhou <xzhou@redhat.com> > --- > tests/generic/294 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/generic/294 b/tests/generic/294 > index b74579ac..f7e763a3 100755 > --- a/tests/generic/294 > +++ b/tests/generic/294 > @@ -27,6 +27,7 @@ _cleanup() > . ./common/filter > > # real QA test starts here > +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output" > > # Modify as appropriate. > _supported_fs generic > -- > 2.21.0 >
On Mon, Mar 04, 2019 at 10:50:08AM +0800, Xiong Zhou wrote: > Because NFS handles this differently, returning different values. > Details: > http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294 > > Signed-off-by: Murphy Zhou <xzhou@redhat.com> Sorry for the so long delay.. > --- > tests/generic/294 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/generic/294 b/tests/generic/294 > index b74579ac..f7e763a3 100755 > --- a/tests/generic/294 > +++ b/tests/generic/294 > @@ -27,6 +27,7 @@ _cleanup() > . ./common/filter > > # real QA test starts here > +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output" I think it's better to filter the output of NFS to follow the golden output, so when NFS changes behavior, filter fails and we could know that from test failure. Thanks, Eryu > > # Modify as appropriate. > _supported_fs generic > -- > 2.21.0 >
On Mon, Apr 15, 2019 at 12:03:09PM +0800, Eryu Guan wrote: > On Mon, Mar 04, 2019 at 10:50:08AM +0800, Xiong Zhou wrote: > > Because NFS handles this differently, returning different values. > > Details: > > http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294 > > > > Signed-off-by: Murphy Zhou <xzhou@redhat.com> > > Sorry for the so long delay.. Not at all, :) Sending v2. Thanks, Xiong > > --- > > tests/generic/294 | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/generic/294 b/tests/generic/294 > > index b74579ac..f7e763a3 100755 > > --- a/tests/generic/294 > > +++ b/tests/generic/294 > > @@ -27,6 +27,7 @@ _cleanup() > > . ./common/filter > > > > # real QA test starts here > > +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output" > > I think it's better to filter the output of NFS to follow the golden > output, so when NFS changes behavior, filter fails and we could know > that from test failure. > > Thanks, > Eryu > > > > > # Modify as appropriate. > > _supported_fs generic > > -- > > 2.21.0 > >
diff --git a/tests/generic/294 b/tests/generic/294 index b74579ac..f7e763a3 100755 --- a/tests/generic/294 +++ b/tests/generic/294 @@ -27,6 +27,7 @@ _cleanup() . ./common/filter # real QA test starts here +[ $FSTYP == "nfs" ] && _notrun "NFS behaves differently, breaks golden output" # Modify as appropriate. _supported_fs generic
Because NFS handles this differently, returning different values. Details: http://people.redhat.com/bcodding/nfs/2016/10/07/nfs_xfstest_generic/#generic294 Signed-off-by: Murphy Zhou <xzhou@redhat.com> --- tests/generic/294 | 1 + 1 file changed, 1 insertion(+)