| Message ID | 1fa6fadf644859e8a6a8ecce258444b49be8c7ee.1551716733.git.andreyknvl@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kasan: fix coccinelle warnings in kasan_p*_table | expand |
On 3/4/19 8:04 PM, Andrey Konovalov wrote: > kasan_p4d_table, kasan_pmd_table and kasan_pud_table are declared as > returning bool, but return 0 instead of false, which produces a coccinelle > warning. Fix it. > > Fixes: 0207df4fa1a8 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN") > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > --- Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com> > mm/kasan/init.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/kasan/init.c b/mm/kasan/init.c > index 45a1b5e38e1e..fcaa1ca03175 100644 > --- a/mm/kasan/init.c > +++ b/mm/kasan/init.c > @@ -42,7 +42,7 @@ static inline bool kasan_p4d_table(pgd_t pgd) > #else > static inline bool kasan_p4d_table(pgd_t pgd) > { > - return 0; > + return false; > } > #endif > #if CONFIG_PGTABLE_LEVELS > 3 > @@ -54,7 +54,7 @@ static inline bool kasan_pud_table(p4d_t p4d) > #else > static inline bool kasan_pud_table(p4d_t p4d) > { > - return 0; > + return false; > } > #endif > #if CONFIG_PGTABLE_LEVELS > 2 > @@ -66,7 +66,7 @@ static inline bool kasan_pmd_table(pud_t pud) > #else > static inline bool kasan_pmd_table(pud_t pud) > { > - return 0; > + return false; > } > #endif > pte_t kasan_early_shadow_pte[PTRS_PER_PTE] __page_aligned_bss; >
On Tue, Mar 5, 2019 at 9:43 PM Andrey Ryabinin <aryabinin@virtuozzo.com> wrote: > > > > On 3/4/19 8:04 PM, Andrey Konovalov wrote: > > kasan_p4d_table, kasan_pmd_table and kasan_pud_table are declared as > > returning bool, but return 0 instead of false, which produces a coccinelle > > warning. Fix it. > > > > Fixes: 0207df4fa1a8 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN") > > Reported-by: kbuild test robot <lkp@intel.com> > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > > --- > > Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com> > > > > mm/kasan/init.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/mm/kasan/init.c b/mm/kasan/init.c > > index 45a1b5e38e1e..fcaa1ca03175 100644 > > --- a/mm/kasan/init.c > > +++ b/mm/kasan/init.c > > @@ -42,7 +42,7 @@ static inline bool kasan_p4d_table(pgd_t pgd) > > #else > > static inline bool kasan_p4d_table(pgd_t pgd) > > { > > - return 0; > > + return false; > > } > > #endif > > #if CONFIG_PGTABLE_LEVELS > 3 > > @@ -54,7 +54,7 @@ static inline bool kasan_pud_table(p4d_t p4d) > > #else > > static inline bool kasan_pud_table(p4d_t p4d) > > { > > - return 0; > > + return false; > > } > > #endif > > #if CONFIG_PGTABLE_LEVELS > 2 > > @@ -66,7 +66,7 @@ static inline bool kasan_pmd_table(pud_t pud) > > #else > > static inline bool kasan_pmd_table(pud_t pud) > > { > > - return 0; > > + return false; > > } > > #endif > > pte_t kasan_early_shadow_pte[PTRS_PER_PTE] __page_aligned_bss; > > > Acked-by: Souptick Joarder <jrdr.linux@gmail.com>
diff --git a/mm/kasan/init.c b/mm/kasan/init.c index 45a1b5e38e1e..fcaa1ca03175 100644 --- a/mm/kasan/init.c +++ b/mm/kasan/init.c @@ -42,7 +42,7 @@ static inline bool kasan_p4d_table(pgd_t pgd) #else static inline bool kasan_p4d_table(pgd_t pgd) { - return 0; + return false; } #endif #if CONFIG_PGTABLE_LEVELS > 3 @@ -54,7 +54,7 @@ static inline bool kasan_pud_table(p4d_t p4d) #else static inline bool kasan_pud_table(p4d_t p4d) { - return 0; + return false; } #endif #if CONFIG_PGTABLE_LEVELS > 2 @@ -66,7 +66,7 @@ static inline bool kasan_pmd_table(pud_t pud) #else static inline bool kasan_pmd_table(pud_t pud) { - return 0; + return false; } #endif pte_t kasan_early_shadow_pte[PTRS_PER_PTE] __page_aligned_bss;
kasan_p4d_table, kasan_pmd_table and kasan_pud_table are declared as returning bool, but return 0 instead of false, which produces a coccinelle warning. Fix it. Fixes: 0207df4fa1a8 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN") Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Andrey Konovalov <andreyknvl@google.com> --- mm/kasan/init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)