diff mbox series

[2/4] hw/i386/pc_sysfw: Remove obsolete PcSysFwDevice

Message ID 20190304194857.9780-3-philmd@redhat.com (mailing list archive)
State New, archived
Headers show
Series pc: Support firmware configuration with -blockdev (splitted) | expand

Commit Message

Philippe Mathieu-Daudé March 4, 2019, 7:48 p.m. UTC 
This structure is not used since 6dd2a5c98a.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/i386/pc_sysfw.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Laszlo Ersek March 5, 2019, 5:19 p.m. UTC | #1 
On 03/04/19 20:48, Philippe Mathieu-Daudé wrote:
> This structure is not used since 6dd2a5c98a.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/i386/pc_sysfw.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c
> index 34727c5b1f..46b87afe23 100644
> --- a/hw/i386/pc_sysfw.c
> +++ b/hw/i386/pc_sysfw.c
> @@ -40,11 +40,6 @@
>  
>  #define BIOS_FILENAME "bios.bin"
>  
> -typedef struct PcSysFwDevice {
> -    SysBusDevice busdev;
> -    uint8_t isapc_ram_fw;
> -} PcSysFwDevice;
> -
>  static void pc_isa_bios_init(MemoryRegion *rom_memory,
>                               MemoryRegion *flash_mem,
>                               int ram_size)
> 

Looks sane, and the commit reference is precise.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo
diff mbox series

Patch

diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c
index 34727c5b1f..46b87afe23 100644
--- a/hw/i386/pc_sysfw.c
+++ b/hw/i386/pc_sysfw.c
@@ -40,11 +40,6 @@ 
 
 #define BIOS_FILENAME "bios.bin"
 
-typedef struct PcSysFwDevice {
-    SysBusDevice busdev;
-    uint8_t isapc_ram_fw;
-} PcSysFwDevice;
-
 static void pc_isa_bios_init(MemoryRegion *rom_memory,
                              MemoryRegion *flash_mem,
                              int ram_size)