diff mbox series

[2/3] drm/i915: Move PCH_NOP to -1

Message ID 20190304224830.8481-2-rodrigo.vivi@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/3] drm/i915/gen11+: First assume next platforms will inherit stuff | expand

Commit Message

Rodrigo Vivi March 4, 2019, 10:48 p.m. UTC
So we can later use PCH >= comparisons. The ultimate goal
is to make it easier for us to introduce a new platform
with south display engine on PCH just by reusing the previous
one.

Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lucas De Marchi March 5, 2019, 5:38 p.m. UTC | #1
On Mon, Mar 04, 2019 at 02:48:29PM -0800, Rodrigo Vivi wrote:
>So we can later use PCH >= comparisons. The ultimate goal
>is to make it easier for us to introduce a new platform
>with south display engine on PCH just by reusing the previous
>one.
>
>Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/i915/i915_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>index 453af7438e67..e6be327ba86d 100644
>--- a/drivers/gpu/drm/i915/i915_drv.h
>+++ b/drivers/gpu/drm/i915/i915_drv.h
>@@ -524,6 +524,7 @@ struct i915_psr {
> };
>
> enum intel_pch {
>+	PCH_NOP = -1,	/* PCH without south display */
> 	PCH_NONE = 0,	/* No PCH present */
> 	PCH_IBX,	/* Ibexpeak PCH */
> 	PCH_CPT,	/* Cougarpoint/Pantherpoint PCH */
>@@ -532,7 +533,6 @@ enum intel_pch {
> 	PCH_KBP,        /* Kaby Lake PCH */
> 	PCH_CNP,        /* Cannon Lake PCH */
> 	PCH_ICP,	/* Ice Lake PCH */
>-	PCH_NOP,	/* PCH without south display */
> };
>
> enum intel_sbi_destination {
>-- 
>2.20.1
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 453af7438e67..e6be327ba86d 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -524,6 +524,7 @@  struct i915_psr {
 };
 
 enum intel_pch {
+	PCH_NOP = -1,	/* PCH without south display */
 	PCH_NONE = 0,	/* No PCH present */
 	PCH_IBX,	/* Ibexpeak PCH */
 	PCH_CPT,	/* Cougarpoint/Pantherpoint PCH */
@@ -532,7 +533,6 @@  enum intel_pch {
 	PCH_KBP,        /* Kaby Lake PCH */
 	PCH_CNP,        /* Cannon Lake PCH */
 	PCH_ICP,	/* Ice Lake PCH */
-	PCH_NOP,	/* PCH without south display */
 };
 
 enum intel_sbi_destination {