| Message ID | 1551909125-20305-1-git-send-email-info@metux.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] drivers: watchdog: Kconfig: pedantic formatting | expand |
On Wed, Mar 06, 2019 at 10:52:05PM +0100, Enrico Weigelt, metux IT consult wrote: > Formatting of Kconfig files doesn't look so pretty, so just > take damp cloth and clean it up. > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Having said that, I would really discourage this kind of cleanup, and I was quite close to NACKing it. It doesn't fix a single checkpatch issue in the affected Kconfig file, and that file currently reports 42 checkpatch warnings. Those would be more important issues to fix than vertical help text alignments. I won't apply this patch to my branch, and will leave it up to Wim to decide what to do with it. Guenter > --- > drivers/watchdog/Kconfig | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 57f017d..38509d5 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -279,10 +279,10 @@ config ARMADA_37XX_WATCHDOG > select MFD_SYSCON > select WATCHDOG_CORE > help > - Say Y here to include support for the watchdog timer found on > - Marvell Armada 37xx SoCs. > - To compile this driver as a module, choose M here: the > - module will be called armada_37xx_wdt. > + Say Y here to include support for the watchdog timer found on > + Marvell Armada 37xx SoCs. > + To compile this driver as a module, choose M here: the > + module will be called armada_37xx_wdt. > > config ASM9260_WATCHDOG > tristate "Alphascale ASM9260 watchdog" > @@ -606,10 +606,10 @@ config MAX77620_WATCHDOG > tristate "Maxim Max77620 Watchdog Timer" > depends on MFD_MAX77620 || COMPILE_TEST > help > - This is the driver for the Max77620 watchdog timer. > - Say 'Y' here to enable the watchdog timer support for > - MAX77620 chips. To compile this driver as a module, > - choose M here: the module will be called max77620_wdt. > + This is the driver for the Max77620 watchdog timer. > + Say 'Y' here to enable the watchdog timer support for > + MAX77620 chips. To compile this driver as a module, > + choose M here: the module will be called max77620_wdt. > > config IMX2_WDT > tristate "IMX2+ Watchdog" > @@ -1632,10 +1632,10 @@ config BCM7038_WDT > depends on HAS_IOMEM > depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST > help > - Watchdog driver for the built-in hardware in Broadcom 7038 and > - later SoCs used in set-top boxes. BCM7038 was made public > - during the 2004 CES, and since then, many Broadcom chips use this > - watchdog block, including some cable modem chips. > + Watchdog driver for the built-in hardware in Broadcom 7038 and > + later SoCs used in set-top boxes. BCM7038 was made public > + during the 2004 CES, and since then, many Broadcom chips use this > + watchdog block, including some cable modem chips. > > config IMGPDC_WDT > tristate "Imagination Technologies PDC Watchdog Timer"
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 57f017d..38509d5 100644 --- a/drivers/watchdog/Kconfig +++ b/drivers/watchdog/Kconfig @@ -279,10 +279,10 @@ config ARMADA_37XX_WATCHDOG select MFD_SYSCON select WATCHDOG_CORE help - Say Y here to include support for the watchdog timer found on - Marvell Armada 37xx SoCs. - To compile this driver as a module, choose M here: the - module will be called armada_37xx_wdt. + Say Y here to include support for the watchdog timer found on + Marvell Armada 37xx SoCs. + To compile this driver as a module, choose M here: the + module will be called armada_37xx_wdt. config ASM9260_WATCHDOG tristate "Alphascale ASM9260 watchdog" @@ -606,10 +606,10 @@ config MAX77620_WATCHDOG tristate "Maxim Max77620 Watchdog Timer" depends on MFD_MAX77620 || COMPILE_TEST help - This is the driver for the Max77620 watchdog timer. - Say 'Y' here to enable the watchdog timer support for - MAX77620 chips. To compile this driver as a module, - choose M here: the module will be called max77620_wdt. + This is the driver for the Max77620 watchdog timer. + Say 'Y' here to enable the watchdog timer support for + MAX77620 chips. To compile this driver as a module, + choose M here: the module will be called max77620_wdt. config IMX2_WDT tristate "IMX2+ Watchdog" @@ -1632,10 +1632,10 @@ config BCM7038_WDT depends on HAS_IOMEM depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST help - Watchdog driver for the built-in hardware in Broadcom 7038 and - later SoCs used in set-top boxes. BCM7038 was made public - during the 2004 CES, and since then, many Broadcom chips use this - watchdog block, including some cable modem chips. + Watchdog driver for the built-in hardware in Broadcom 7038 and + later SoCs used in set-top boxes. BCM7038 was made public + during the 2004 CES, and since then, many Broadcom chips use this + watchdog block, including some cable modem chips. config IMGPDC_WDT tristate "Imagination Technologies PDC Watchdog Timer"
Formatting of Kconfig files doesn't look so pretty, so just take damp cloth and clean it up. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> --- drivers/watchdog/Kconfig | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)