[2/8] media: vimc: stream: fix thread state before sleep
diff mbox series

Message ID 20190306224244.21070-3-helen.koike@collabora.com
State New
Headers show
  • media: vimc: remove media bus code limitation
Related show

Commit Message

Helen Koike March 6, 2019, 10:42 p.m. UTC
The state TASK_UNINTERRUPTIBLE should be set just before
schedule_timeout() call, so it knows the sleep mode it should enter.
There is no point in setting TASK_UNINTERRUPTIBLE at the initialization
of the thread as schedule_timeout() will set the state back to

This fixes a warning in __might_sleep() call, as it's expecting the
task to be in TASK_RUNNING state just before changing the state to
a sleeping state.

Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Helen Koike <helen.koike@collabora.com>

 drivers/media/platform/vimc/vimc-streamer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

diff --git a/drivers/media/platform/vimc/vimc-streamer.c b/drivers/media/platform/vimc/vimc-streamer.c
index fcc897fb247b..392754c18046 100644
--- a/drivers/media/platform/vimc/vimc-streamer.c
+++ b/drivers/media/platform/vimc/vimc-streamer.c
@@ -120,7 +120,6 @@  static int vimc_streamer_thread(void *data)
 	int i;
-	set_current_state(TASK_UNINTERRUPTIBLE);
 	for (;;) {
@@ -137,6 +136,7 @@  static int vimc_streamer_thread(void *data)
 		//wait for 60hz
+		set_current_state(TASK_UNINTERRUPTIBLE);
 		schedule_timeout(HZ / 60);