[PULL] topic/hdr-formats
mbox series

Message ID f2485309-d645-bed4-95f4-e66ff312aa05@linux.intel.com
State New
Headers show
Series
  • [PULL] topic/hdr-formats
Related show

Pull-request

git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07

Message

Maarten Lankhorst March 7, 2019, 9:48 a.m. UTC
Hi Sean and Joonas,

Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?

Cheers,
Maarten

topic/hdr-formats-2019-03-07:
Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
The following changes since commit 4b057e73f28f1df13b77b77a52094238ffdf8abd:

  Merge tag 'drm-misc-fixes-2019-02-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-03-05 08:14:22 +1000)

are available in the Git repository at:

  git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07

for you to fetch changes up to 296e9b19eff6157e1e4f130fa436e105c45725e9:

  drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)

----------------------------------------------------------------
Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.

----------------------------------------------------------------
Juha-Pekka Heikkila (3):
      drm/i915: Add P010, P012, P016 plane control definitions
      drm/i915: Preparations for enabling P010, P012, P016 formats
      drm/i915: Enable P010, P012, P016 formats for primary and sprite planes

Swati Sharma (3):
      drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc
      drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions
      drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes

 drivers/gpu/drm/drm_fourcc.c              |   6 ++
 drivers/gpu/drm/i915/i915_reg.h           |   9 +++
 drivers/gpu/drm/i915/intel_atomic_plane.c |   2 +-
 drivers/gpu/drm/i915/intel_display.c      |  57 ++++++++++++++--
 drivers/gpu/drm/i915/intel_drv.h          |   1 +
 drivers/gpu/drm/i915/intel_pm.c           |  14 ++--
 drivers/gpu/drm/i915/intel_sprite.c       | 108 ++++++++++++++++++++++++++++--
 include/uapi/drm/drm_fourcc.h             |  16 +++++
 8 files changed, 194 insertions(+), 19 deletions(-)

Comments

Adam Jackson March 7, 2019, 5:12 p.m. UTC | #1
On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote:
> Hi Sean and Joonas,
> 
> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?

Could you also add Kevin Strasser's patch for FP16 formats? For that
matter I'd like to see FP32 added too, but I don't think there's been a
patch sent for that yet.

- ajax
Sean Paul March 7, 2019, 5:46 p.m. UTC | #2
On Thu, Mar 07, 2019 at 10:48:24AM +0100, Maarten Lankhorst wrote:
> Hi Sean and Joonas,
> 
> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> 
> Cheers,
> Maarten
> 
> topic/hdr-formats-2019-03-07:

Mentioned on IRC, but will do so here as well. The key that signed this tag
isn't published. While I'm pretty sure that you are you, I would feel better if
you could publish and verify the key id for me.

Sean

> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> The following changes since commit 4b057e73f28f1df13b77b77a52094238ffdf8abd:
> 
>   Merge tag 'drm-misc-fixes-2019-02-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-03-05 08:14:22 +1000)
> 
> are available in the Git repository at:
> 
>   git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07
> 
> for you to fetch changes up to 296e9b19eff6157e1e4f130fa436e105c45725e9:
> 
>   drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)
> 
> ----------------------------------------------------------------
> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> 
> ----------------------------------------------------------------
> Juha-Pekka Heikkila (3):
>       drm/i915: Add P010, P012, P016 plane control definitions
>       drm/i915: Preparations for enabling P010, P012, P016 formats
>       drm/i915: Enable P010, P012, P016 formats for primary and sprite planes
> 
> Swati Sharma (3):
>       drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc
>       drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions
>       drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes
> 
>  drivers/gpu/drm/drm_fourcc.c              |   6 ++
>  drivers/gpu/drm/i915/i915_reg.h           |   9 +++
>  drivers/gpu/drm/i915/intel_atomic_plane.c |   2 +-
>  drivers/gpu/drm/i915/intel_display.c      |  57 ++++++++++++++--
>  drivers/gpu/drm/i915/intel_drv.h          |   1 +
>  drivers/gpu/drm/i915/intel_pm.c           |  14 ++--
>  drivers/gpu/drm/i915/intel_sprite.c       | 108 ++++++++++++++++++++++++++++--
>  include/uapi/drm/drm_fourcc.h             |  16 +++++
>  8 files changed, 194 insertions(+), 19 deletions(-)
Maarten Lankhorst March 8, 2019, 12:45 p.m. UTC | #3
Op 07-03-2019 om 18:46 schreef Sean Paul:
> On Thu, Mar 07, 2019 at 10:48:24AM +0100, Maarten Lankhorst wrote:
>> Hi Sean and Joonas,
>>
>> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
>>
>> Cheers,
>> Maarten
>>
>> topic/hdr-formats-2019-03-07:
> Mentioned on IRC, but will do so here as well. The key that signed this tag
> isn't published. While I'm pretty sure that you are you, I would feel better if
> you could publish and verify the key id for me.

Key should be on keyservers.

But if you're paranoid.. https://db.debian.org/ and look me up, and download the gpg key there. :)

>
>> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
>> The following changes since commit 4b057e73f28f1df13b77b77a52094238ffdf8abd:
>>
>>   Merge tag 'drm-misc-fixes-2019-02-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-03-05 08:14:22 +1000)
>>
>> are available in the Git repository at:
>>
>>   git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07
>>
>> for you to fetch changes up to 296e9b19eff6157e1e4f130fa436e105c45725e9:
>>
>>   drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)
>>
>> ----------------------------------------------------------------
>> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
>>
>> ----------------------------------------------------------------
>> Juha-Pekka Heikkila (3):
>>       drm/i915: Add P010, P012, P016 plane control definitions
>>       drm/i915: Preparations for enabling P010, P012, P016 formats
>>       drm/i915: Enable P010, P012, P016 formats for primary and sprite planes
>>
>> Swati Sharma (3):
>>       drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc
>>       drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions
>>       drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes
>>
>>  drivers/gpu/drm/drm_fourcc.c              |   6 ++
>>  drivers/gpu/drm/i915/i915_reg.h           |   9 +++
>>  drivers/gpu/drm/i915/intel_atomic_plane.c |   2 +-
>>  drivers/gpu/drm/i915/intel_display.c      |  57 ++++++++++++++--
>>  drivers/gpu/drm/i915/intel_drv.h          |   1 +
>>  drivers/gpu/drm/i915/intel_pm.c           |  14 ++--
>>  drivers/gpu/drm/i915/intel_sprite.c       | 108 ++++++++++++++++++++++++++++--
>>  include/uapi/drm/drm_fourcc.h             |  16 +++++
>>  8 files changed, 194 insertions(+), 19 deletions(-)
Sean Paul March 8, 2019, 3:40 p.m. UTC | #4
On Thu, Mar 07, 2019 at 10:48:24AM +0100, Maarten Lankhorst wrote:
> Hi Sean and Joonas,
> 
> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> 

Applied to drm-misc-next, thanks for sending this out.

Sean

> Cheers,
> Maarten
> 
> topic/hdr-formats-2019-03-07:
> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> The following changes since commit 4b057e73f28f1df13b77b77a52094238ffdf8abd:
> 
>   Merge tag 'drm-misc-fixes-2019-02-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-03-05 08:14:22 +1000)
> 
> are available in the Git repository at:
> 
>   git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07
> 
> for you to fetch changes up to 296e9b19eff6157e1e4f130fa436e105c45725e9:
> 
>   drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)
> 
> ----------------------------------------------------------------
> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> 
> ----------------------------------------------------------------
> Juha-Pekka Heikkila (3):
>       drm/i915: Add P010, P012, P016 plane control definitions
>       drm/i915: Preparations for enabling P010, P012, P016 formats
>       drm/i915: Enable P010, P012, P016 formats for primary and sprite planes
> 
> Swati Sharma (3):
>       drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc
>       drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions
>       drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes
> 
>  drivers/gpu/drm/drm_fourcc.c              |   6 ++
>  drivers/gpu/drm/i915/i915_reg.h           |   9 +++
>  drivers/gpu/drm/i915/intel_atomic_plane.c |   2 +-
>  drivers/gpu/drm/i915/intel_display.c      |  57 ++++++++++++++--
>  drivers/gpu/drm/i915/intel_drv.h          |   1 +
>  drivers/gpu/drm/i915/intel_pm.c           |  14 ++--
>  drivers/gpu/drm/i915/intel_sprite.c       | 108 ++++++++++++++++++++++++++++--
>  include/uapi/drm/drm_fourcc.h             |  16 +++++
>  8 files changed, 194 insertions(+), 19 deletions(-)
Maarten Lankhorst March 11, 2019, 11:19 a.m. UTC | #5
Hey,

Op 07-03-2019 om 18:12 schreef Adam Jackson:
> On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote:
>> Hi Sean and Joonas,
>>
>> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> Could you also add Kevin Strasser's patch for FP16 formats? For that
> matter I'd like to see FP32 added too, but I don't think there's been a
> patch sent for that yet.

Added kevin to CC.

Is the mesa side considered completely reviewed then?

If so, I wouldn't mind sending a second pull req for fp16 support this week.

~Maarten
Joonas Lahtinen March 11, 2019, 11:57 a.m. UTC | #6
Quoting Maarten Lankhorst (2019-03-07 11:48:24)
> Hi Sean and Joonas,
> 
> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?

I was travelling on Fri, so sorry for delay. This is now pulled to dinq,
too.

Regards, Joonas

> 
> Cheers,
> Maarten
> 
> topic/hdr-formats-2019-03-07:
> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> The following changes since commit 4b057e73f28f1df13b77b77a52094238ffdf8abd:
> 
>   Merge tag 'drm-misc-fixes-2019-02-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-03-05 08:14:22 +1000)
> 
> are available in the Git repository at:
> 
>   git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07
> 
> for you to fetch changes up to 296e9b19eff6157e1e4f130fa436e105c45725e9:
> 
>   drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes (2019-03-05 12:49:00 +0100)
> 
> ----------------------------------------------------------------
> Add support for Y21x and Y41x to drm core and i915, and P01x support to i915.
> 
> ----------------------------------------------------------------
> Juha-Pekka Heikkila (3):
>       drm/i915: Add P010, P012, P016 plane control definitions
>       drm/i915: Preparations for enabling P010, P012, P016 formats
>       drm/i915: Enable P010, P012, P016 formats for primary and sprite planes
> 
> Swati Sharma (3):
>       drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc
>       drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions
>       drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes
> 
>  drivers/gpu/drm/drm_fourcc.c              |   6 ++
>  drivers/gpu/drm/i915/i915_reg.h           |   9 +++
>  drivers/gpu/drm/i915/intel_atomic_plane.c |   2 +-
>  drivers/gpu/drm/i915/intel_display.c      |  57 ++++++++++++++--
>  drivers/gpu/drm/i915/intel_drv.h          |   1 +
>  drivers/gpu/drm/i915/intel_pm.c           |  14 ++--
>  drivers/gpu/drm/i915/intel_sprite.c       | 108 ++++++++++++++++++++++++++++--
>  include/uapi/drm/drm_fourcc.h             |  16 +++++
>  8 files changed, 194 insertions(+), 19 deletions(-)
Maarten Lankhorst March 11, 2019, 12:05 p.m. UTC | #7
Op 11-03-2019 om 12:57 schreef Joonas Lahtinen:
> Quoting Maarten Lankhorst (2019-03-07 11:48:24)
>> Hi Sean and Joonas,
>>
>> Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> I was travelling on Fri, so sorry for delay. This is now pulled to dinq,
> too.
>
> Regards, Joonas
>
Thanks. :)

~Maarten
Adam Jackson March 11, 2019, 5:52 p.m. UTC | #8
On Mon, 2019-03-11 at 12:19 +0100, Maarten Lankhorst wrote:
> Hey,
> 
> Op 07-03-2019 om 18:12 schreef Adam Jackson:
> > On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote:
> > > Hi Sean and Joonas,
> > > 
> > > Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> > Could you also add Kevin Strasser's patch for FP16 formats? For that
> > matter I'd like to see FP32 added too, but I don't think there's been a
> > patch sent for that yet.
> 
> Added kevin to CC.
> 
> Is the mesa side considered completely reviewed then?

Is that strictly necessary for just adding a fourcc? I get wanting to
see a real userspace consumer first, but this is just allocating some
magic numbers not promising that a certain ioctl behaves a certain way.

That said, I did say r-b for the Mesa series as a whole. Daniel Stone
had some comments on 13/13 that made it sound like it (that specific
patch) was unnecessary/undesirable, but everything before that looked
great to me, and even if we only merged the first 12 we'd still have
FP16 wired through for the gbm EGL platform, meaning HDR scanout could
actually be a thing.

- ajax
Daniel Vetter March 11, 2019, 6:02 p.m. UTC | #9
On Mon, Mar 11, 2019 at 01:52:13PM -0400, Adam Jackson wrote:
> On Mon, 2019-03-11 at 12:19 +0100, Maarten Lankhorst wrote:
> > Hey,
> > 
> > Op 07-03-2019 om 18:12 schreef Adam Jackson:
> > > On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote:
> > > > Hi Sean and Joonas,
> > > > 
> > > > Here's a pull request for HDR format enabling in i915. Can this be pulled to drm-misc-next and dinq?
> > > Could you also add Kevin Strasser's patch for FP16 formats? For that
> > > matter I'd like to see FP32 added too, but I don't think there's been a
> > > patch sent for that yet.
> > 
> > Added kevin to CC.
> > 
> > Is the mesa side considered completely reviewed then?
> 
> Is that strictly necessary for just adding a fourcc? I get wanting to
> see a real userspace consumer first, but this is just allocating some
> magic numbers not promising that a certain ioctl behaves a certain way.

It's a bit a grey area, since uapi/drm/drm_fourcc.h is both a simple magic
number registry for userspace and also the source of truth for what that's
supposed to mean for AddFB. Which is uapi. Having the full mesa->kms
pipeline gives a bit more assurance we didn't flip something somewhere by
accident or some other silliness.

So for i915.ko stuff we've been pretty strict with this, just to make sure
we don't ship broken stuff. But we definitely merged other patches without
anything being able to consume/produce those formats in userspace (well
anything open source at least), fitting the magic number registry.

Imo this is an area each driver team can decide on how they want to handle
it (with my maintainer hat on).
-Daniel
> 
> That said, I did say r-b for the Mesa series as a whole. Daniel Stone
> had some comments on 13/13 that made it sound like it (that specific
> patch) was unnecessary/undesirable, but everything before that looked
> great to me, and even if we only merged the first 12 we'd still have
> FP16 wired through for the gbm EGL platform, meaning HDR scanout could
> actually be a thing.
> 
> - ajax
> 
> _______________________________________________
> dim-tools mailing list
> dim-tools@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dim-tools