diff mbox series

drm/stm: fix CONFIG_FB dependency

Message ID 20190307155323.2949975-1-arnd@arndb.de (mailing list archive)
State New, archived
Headers show
Series drm/stm: fix CONFIG_FB dependency | expand

Commit Message

Arnd Bergmann March 7, 2019, 3:53 p.m. UTC
The DRM_STM driver can be built independently of the framebuffer
layer, but it causes a Kconfig warning:

WARNING: unmet direct dependencies detected for FB_PROVIDE_GET_FB_UNMAPPED_AREA
  Depends on [n]: HAS_IOMEM [=y] && FB [=n]
  Selected by [y]:
  - DRM_STM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_STM32 [=n] || ARCH_MULTIPLATFORM [=y])

Selecting FB_PROVIDE_GET_FB_UNMAPPED_AREA actually has no effect
if CONFIG_FB is disabled, so we can make it a conditional 'select'
instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/stm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yannick FERTRE March 8, 2019, 3:50 p.m. UTC | #1
Reviewed-by: Yannick Fertré <yannick.fertre@st.com><mailto:yannick.fertre@st.com>


Arnd,
could you merge the patch?
I think that Benjamin could also merge it.

Best regards

Yannick Fertré


On 3/7/19 4:53 PM, Arnd Bergmann wrote:

The DRM_STM driver can be built independently of the framebuffer
layer, but it causes a Kconfig warning:

WARNING: unmet direct dependencies detected for FB_PROVIDE_GET_FB_UNMAPPED_AREA
  Depends on [n]: HAS_IOMEM [=y] && FB [=n]
  Selected by [y]:
  - DRM_STM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_STM32 [=n] || ARCH_MULTIPLATFORM [=y])

Selecting FB_PROVIDE_GET_FB_UNMAPPED_AREA actually has no effect
if CONFIG_FB is disabled, so we can make it a conditional 'select'
instead.

Signed-off-by: Arnd Bergmann <arnd@arndb.de><mailto:arnd@arndb.de>
---
 drivers/gpu/drm/stm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/stm/Kconfig b/drivers/gpu/drm/stm/Kconfig
index 35367ada3bc1..d15b10de1da6 100644
--- a/drivers/gpu/drm/stm/Kconfig
+++ b/drivers/gpu/drm/stm/Kconfig
@@ -6,7 +6,7 @@ config DRM_STM
        select DRM_KMS_CMA_HELPER
        select DRM_PANEL_BRIDGE
        select VIDEOMODE_HELPERS
-       select FB_PROVIDE_GET_FB_UNMAPPED_AREA
+       select FB_PROVIDE_GET_FB_UNMAPPED_AREA if FB

        help
          Enable support for the on-chip display controller on


--
Yannick Fertré | TINA: 166 7152 | Tel: +33 244027152 | Mobile: +33 620600270
Microcontrollers and Digital ICs Group | Microcontrolleurs Division
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<pre>Reviewed-by: Yannick Fertré <a class="moz-txt-link-rfc2396E" href="mailto:yannick.fertre@st.com">&lt;yannick.fertre@st.com&gt;</a> 
</pre>
<div class="moz-cite-prefix">Arnd, <br>
</div>
<div class="moz-cite-prefix">could you merge the patch?</div>
<div class="moz-cite-prefix">I think that Benjamin could also merge it.</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Best regards</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Yannick Fertré<br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">On 3/7/19 4:53 PM, Arnd Bergmann wrote:<br>
</div>
<blockquote type="cite" cite="mid:20190307155323.2949975-1-arnd@arndb.de">
<pre class="moz-quote-pre" wrap="">The DRM_STM driver can be built independently of the framebuffer
layer, but it causes a Kconfig warning:

WARNING: unmet direct dependencies detected for FB_PROVIDE_GET_FB_UNMAPPED_AREA
  Depends on [n]: HAS_IOMEM [=y] &amp;&amp; FB [=n]
  Selected by [y]:
  - DRM_STM [=y] &amp;&amp; HAS_IOMEM [=y] &amp;&amp; DRM [=y] &amp;&amp; (ARCH_STM32 [=n] || ARCH_MULTIPLATFORM [=y])

Selecting FB_PROVIDE_GET_FB_UNMAPPED_AREA actually has no effect
if CONFIG_FB is disabled, so we can make it a conditional 'select'
instead.

Signed-off-by: Arnd Bergmann <a class="moz-txt-link-rfc2396E" href="mailto:arnd@arndb.de">&lt;arnd@arndb.de&gt;</a>
---
 drivers/gpu/drm/stm/Kconfig | 2 &#43;-
 1 file changed, 1 insertion(&#43;), 1 deletion(-)

diff --git a/drivers/gpu/drm/stm/Kconfig b/drivers/gpu/drm/stm/Kconfig
index 35367ada3bc1..d15b10de1da6 100644
--- a/drivers/gpu/drm/stm/Kconfig
&#43;&#43;&#43; b/drivers/gpu/drm/stm/Kconfig
@@ -6,7 &#43;6,7 @@ config DRM_STM
 	select DRM_KMS_CMA_HELPER
 	select DRM_PANEL_BRIDGE
 	select VIDEOMODE_HELPERS
-	select FB_PROVIDE_GET_FB_UNMAPPED_AREA
&#43;	select FB_PROVIDE_GET_FB_UNMAPPED_AREA if FB
 
 	help
 	  Enable support for the on-chip display controller on
</pre>
</blockquote>
<div class="moz-signature">-- <br>
Yannick Fertré | TINA: 166 7152 | Tel: &#43;33 244027152 | Mobile: &#43;33 620600270<br>
Microcontrollers and Digital ICs Group | Microcontrolleurs Division</div>
</body>
</html>
Arnd Bergmann March 11, 2019, 2:24 p.m. UTC | #2
On Fri, Mar 8, 2019 at 4:50 PM Yannick FERTRE <yannick.fertre@st.com> wrote:
>
> Reviewed-by: Yannick Fertré <yannick.fertre@st.com>

Thanks,

> Arnd,
> could you merge the patch?
> I think that Benjamin could also merge it.

I think this should go through the drm tree, so someone with
access to that should merge it, not me.

     Arnd
Benjamin Gaignard March 11, 2019, 2:49 p.m. UTC | #3
Le lun. 11 mars 2019 à 15:24, Arnd Bergmann <arnd@arndb.de> a écrit :
>
> On Fri, Mar 8, 2019 at 4:50 PM Yannick FERTRE <yannick.fertre@st.com> wrote:
> >
> > Reviewed-by: Yannick Fertré <yannick.fertre@st.com>
>
> Thanks,
>
> > Arnd,
> > could you merge the patch?
> > I think that Benjamin could also merge it.
>
> I think this should go through the drm tree, so someone with
> access to that should merge it, not me.

Applied on drm-misc-next,
Thanks,

Benjamin
>
>      Arnd
diff mbox series

Patch

diff --git a/drivers/gpu/drm/stm/Kconfig b/drivers/gpu/drm/stm/Kconfig
index 35367ada3bc1..d15b10de1da6 100644
--- a/drivers/gpu/drm/stm/Kconfig
+++ b/drivers/gpu/drm/stm/Kconfig
@@ -6,7 +6,7 @@  config DRM_STM
 	select DRM_KMS_CMA_HELPER
 	select DRM_PANEL_BRIDGE
 	select VIDEOMODE_HELPERS
-	select FB_PROVIDE_GET_FB_UNMAPPED_AREA
+	select FB_PROVIDE_GET_FB_UNMAPPED_AREA if FB
 
 	help
 	  Enable support for the on-chip display controller on