| Message ID | 1552275991-34648-4-git-send-email-hsin-hsiung.wang@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Support for MediaTek PMIC MT6358 | expand |
Hi, Always put the patches about dt-binding changes at the head of the series to let the related maintainer more easily find them. On Sun, Mar 10, 2019 at 8:48 PM Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> wrote: > > This adds compatible for the MediaTek MT6358 PMIC. > > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > index 0ebd08a..62f1c17 100644 > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > @@ -17,22 +17,27 @@ Documentation/devicetree/bindings/soc/mediatek/pwrap.txt > This document describes the binding for MFD device and its sub module. > > Required properties: > -compatible: "mediatek,mt6397" or "mediatek,mt6323" > +compatible: > + "mediatek,mt6323" for PMIC MT6323 > + "mediatek,mt6358" for PMIC MT6358 > + "mediatek,mt6397" for PMIC MT6397 don't change anything not related MT6358 > > Optional subnodes: > > - rtc > Required properties: > - - compatible: "mediatek,mt6397-rtc" > + - compatible: "mediatek,mt6397-rtc" or "mediatek,mt6358-rtc" > - regulators > Required properties: > - compatible: "mediatek,mt6397-regulator" > see Documentation/devicetree/bindings/regulator/mt6397-regulator.txt > + - compatible: "mediatek,mt6358-regulator" > + see Documentation/devicetree/bindings/regulator/mt6358-regulator.txt > - compatible: "mediatek,mt6323-regulator" > see Documentation/devicetree/bindings/regulator/mt6323-regulator.txt > - codec > Required properties: > - - compatible: "mediatek,mt6397-codec" > + - compatible: "mediatek,mt6397-codec" or "mediatek,mt6358-sound" why didn't we use a more consistent naming as mt6358-codec? > - clk > Required properties: > - compatible: "mediatek,mt6397-clk" > -- > 1.9.1 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
On Mon, Mar 11, 2019 at 12:19:32PM -0700, Sean Wang wrote: > Hi, > > Always put the patches about dt-binding changes at the head of the > series to let the related maintainer more easily find them. > > On Sun, Mar 10, 2019 at 8:48 PM Hsin-Hsiung Wang > <hsin-hsiung.wang@mediatek.com> wrote: > > > > This adds compatible for the MediaTek MT6358 PMIC. > > > > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> > > --- > > Documentation/devicetree/bindings/mfd/mt6397.txt | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > > index 0ebd08a..62f1c17 100644 > > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > > @@ -17,22 +17,27 @@ Documentation/devicetree/bindings/soc/mediatek/pwrap.txt > > This document describes the binding for MFD device and its sub module. > > > > Required properties: > > -compatible: "mediatek,mt6397" or "mediatek,mt6323" > > +compatible: > > + "mediatek,mt6323" for PMIC MT6323 > > + "mediatek,mt6358" for PMIC MT6358 > > + "mediatek,mt6397" for PMIC MT6397 > > don't change anything not related MT6358 Reformatting like this is preferred. Rob
On Mon, Mar 11, 2019 at 3:06 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Mar 11, 2019 at 12:19:32PM -0700, Sean Wang wrote: > > Hi, > > > > Always put the patches about dt-binding changes at the head of the > > series to let the related maintainer more easily find them. > > > > On Sun, Mar 10, 2019 at 8:48 PM Hsin-Hsiung Wang > > <hsin-hsiung.wang@mediatek.com> wrote: > > > > > > This adds compatible for the MediaTek MT6358 PMIC. > > > > > > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> > > > --- > > > Documentation/devicetree/bindings/mfd/mt6397.txt | 11 ++++++++--- > > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > > > index 0ebd08a..62f1c17 100644 > > > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > > > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > > > @@ -17,22 +17,27 @@ Documentation/devicetree/bindings/soc/mediatek/pwrap.txt > > > This document describes the binding for MFD device and its sub module. > > > > > > Required properties: > > > -compatible: "mediatek,mt6397" or "mediatek,mt6323" > > > +compatible: > > > + "mediatek,mt6323" for PMIC MT6323 > > > + "mediatek,mt6358" for PMIC MT6358 > > > + "mediatek,mt6397" for PMIC MT6397 > > > > don't change anything not related MT6358 > > Reformatting like this is preferred. > Sure, it's fine to me for the purpose. > Rob
On Mon, 11 Mar 2019, Hsin-Hsiung Wang wrote: > This adds compatible for the MediaTek MT6358 PMIC. > > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt index 0ebd08a..62f1c17 100644 --- a/Documentation/devicetree/bindings/mfd/mt6397.txt +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt @@ -17,22 +17,27 @@ Documentation/devicetree/bindings/soc/mediatek/pwrap.txt This document describes the binding for MFD device and its sub module. Required properties: -compatible: "mediatek,mt6397" or "mediatek,mt6323" +compatible: + "mediatek,mt6323" for PMIC MT6323 + "mediatek,mt6358" for PMIC MT6358 + "mediatek,mt6397" for PMIC MT6397 Optional subnodes: - rtc Required properties: - - compatible: "mediatek,mt6397-rtc" + - compatible: "mediatek,mt6397-rtc" or "mediatek,mt6358-rtc" - regulators Required properties: - compatible: "mediatek,mt6397-regulator" see Documentation/devicetree/bindings/regulator/mt6397-regulator.txt + - compatible: "mediatek,mt6358-regulator" + see Documentation/devicetree/bindings/regulator/mt6358-regulator.txt - compatible: "mediatek,mt6323-regulator" see Documentation/devicetree/bindings/regulator/mt6323-regulator.txt - codec Required properties: - - compatible: "mediatek,mt6397-codec" + - compatible: "mediatek,mt6397-codec" or "mediatek,mt6358-sound" - clk Required properties: - compatible: "mediatek,mt6397-clk"
This adds compatible for the MediaTek MT6358 PMIC. Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> --- Documentation/devicetree/bindings/mfd/mt6397.txt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)