| Message ID | 20190311102712.8572-1-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of fprintf | expand |
Oops 'fprintf' -> 'printf' in patch subject. On 3/11/19 11:27 AM, Philippe Mathieu-Daudé wrote: > Avoid to clutter stdout until explicitly requested > (with -d guest_errors): > > $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta > Bad SWSTYLE=0x04 > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > Helge patch "pcnet: Avoid warning when switching back to 16bit mode" > remembered me I had this one somewhere. > --- > hw/net/pcnet.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c > index d9ba04bdfc..16683091c9 100644 > --- a/hw/net/pcnet.c > +++ b/hw/net/pcnet.c > @@ -36,6 +36,7 @@ > */ > > #include "qemu/osdep.h" > +#include "qemu/log.h" > #include "hw/qdev.h" > #include "net/net.h" > #include "net/eth.h" > @@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap, uint32_t val) > val |= 0x0300; > break; > default: > - printf("Bad SWSTYLE=0x%02x\n", val & 0xff); > + qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n", > + val & 0xff); > val = 0x0200; > break; > } >
On 11/03/2019 11.27, Philippe Mathieu-Daudé wrote: > Avoid to clutter stdout until explicitly requested > (with -d guest_errors): > > $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta > Bad SWSTYLE=0x04 > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > Helge patch "pcnet: Avoid warning when switching back to 16bit mode" > remembered me I had this one somewhere. > --- > hw/net/pcnet.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c > index d9ba04bdfc..16683091c9 100644 > --- a/hw/net/pcnet.c > +++ b/hw/net/pcnet.c > @@ -36,6 +36,7 @@ > */ > > #include "qemu/osdep.h" > +#include "qemu/log.h" > #include "hw/qdev.h" > #include "net/net.h" > #include "net/eth.h" > @@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap, uint32_t val) > val |= 0x0300; > break; > default: > - printf("Bad SWSTYLE=0x%02x\n", val & 0xff); > + qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n", > + val & 0xff); > val = 0x0200; > break; > } > Reviewed-by: Thomas Huth <thuth@redhat.com>
On 11/03/2019 11:27, Philippe Mathieu-Daudé wrote: > Avoid to clutter stdout until explicitly requested > (with -d guest_errors): > > $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta > Bad SWSTYLE=0x04 > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > Helge patch "pcnet: Avoid warning when switching back to 16bit mode" > remembered me I had this one somewhere. > --- > hw/net/pcnet.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c > index d9ba04bdfc..16683091c9 100644 > --- a/hw/net/pcnet.c > +++ b/hw/net/pcnet.c > @@ -36,6 +36,7 @@ > */ > > #include "qemu/osdep.h" > +#include "qemu/log.h" > #include "hw/qdev.h" > #include "net/net.h" > #include "net/eth.h" > @@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap, uint32_t val) > val |= 0x0300; > break; > default: > - printf("Bad SWSTYLE=0x%02x\n", val & 0xff); > + qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n", > + val & 0xff); > val = 0x0200; > break; > } > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c index d9ba04bdfc..16683091c9 100644 --- a/hw/net/pcnet.c +++ b/hw/net/pcnet.c @@ -36,6 +36,7 @@ */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/qdev.h" #include "net/net.h" #include "net/eth.h" @@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap, uint32_t val) val |= 0x0300; break; default: - printf("Bad SWSTYLE=0x%02x\n", val & 0xff); + qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n", + val & 0xff); val = 0x0200; break; }
Avoid to clutter stdout until explicitly requested (with -d guest_errors): $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta Bad SWSTYLE=0x04 Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- Helge patch "pcnet: Avoid warning when switching back to 16bit mode" remembered me I had this one somewhere. --- hw/net/pcnet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)